[GitHub] spark pull request: [SPARK-9708] [MESOS] Spark should create local...

[tnachen <gi...@git.apache.org>]

Github user tnachen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8358#discussion_r41939777
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -655,15 +655,19 @@ private[spark] object Utils extends Logging {
           // created the directories already, and that they are secured so that only the
           // user has access to them.
           getYarnLocalDirs(conf).split(",")
    +    } else if (conf.getenv("SPARK_LOCAL_DIRS") != null) {
    --- End diff --
    
    The origin complication was the shuffle service, but I think perhaps we should just keep it below as @vanzin mentioned since we added the check now. I also think that It's inconsistent to have the env variable take precendence where the spark.local.dir property doesn't.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org