You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/06/09 17:26:18 UTC
[GitHub] [httpcomponents-client] carterkozak opened a new pull request #227: HTTPCLIENT-2083: Fix NPE when classic client interceptors are added
carterkozak opened a new pull request #227:
URL: https://github.com/apache/httpcomponents-client/pull/227
Previously HttpClientBuilder methods addExecInterceptorFirst and
addExecInterceptorLast resulted in NullPointerExceptions because
the execInterceptors list had not been initialized yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] carterkozak commented on pull request #227: HTTPCLIENT-2083: Fix NPE when classic client interceptors are added
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #227:
URL: https://github.com/apache/httpcomponents-client/pull/227#issuecomment-641493905
That's true. I couldn't find prior art for test coverage across the client builder class, happy to add it :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] carterkozak commented on pull request #227: HTTPCLIENT-2083: Fix NPE when classic client interceptors are added
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #227:
URL: https://github.com/apache/httpcomponents-client/pull/227#issuecomment-642048426
Updated, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #227: HTTPCLIENT-2083: Fix NPE when classic client interceptors are added
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #227:
URL: https://github.com/apache/httpcomponents-client/pull/227#issuecomment-642074161
@carterkozak Great! I am going to merge the PR immediately after completion of the 5.0.1 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] garydgregory commented on pull request #227: HTTPCLIENT-2083: Fix NPE when classic client interceptors are added
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #227:
URL: https://github.com/apache/httpcomponents-client/pull/227#issuecomment-641487041
@carterkozak You are missing unit tests ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #227: HTTPCLIENT-2083: Fix NPE when classic client interceptors are added
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #227:
URL: https://github.com/apache/httpcomponents-client/pull/227#issuecomment-641907225
@carterkozak Could you please fix style violations and make sure that the build passes style checks? Otherwise looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c merged pull request #227: HTTPCLIENT-2083: Fix NPE when classic client interceptors are added
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #227:
URL: https://github.com/apache/httpcomponents-client/pull/227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org