You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "zuiyangqingzhou (via GitHub)" <gi...@apache.org> on 2024/05/15 06:54:05 UTC
[PR] fix(nacos discovery): nacos node failure should not corrupt in-memory data [apisix]
zuiyangqingzhou opened a new pull request, #11253:
URL: https://github.com/apache/apisix/pull/11253
### Description
fix: https://github.com/apache/apisix/issues/11252
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(nacos discovery): nacos node failure should not corrupt in-memory data [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11253:
URL: https://github.com/apache/apisix/pull/11253#issuecomment-2280767873
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(nacos discovery): nacos node failure should not corrupt in-memory data [apisix]
Posted by "zuiyangqingzhou (via GitHub)" <gi...@apache.org>.
zuiyangqingzhou commented on PR #11253:
URL: https://github.com/apache/apisix/pull/11253#issuecomment-2153897751
@shreemaan-abhishek
Take a look at this case. I don't think I caused this problem.
Thank you.
<img width="882" alt="image" src="https://github.com/apache/apisix/assets/17425270/975ab3f0-ed42-4f02-ac6f-159e8ac06fb4">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(nacos discovery): nacos node failure should not corrupt in-memory data [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11253:
URL: https://github.com/apache/apisix/pull/11253#issuecomment-2336625061
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(nacos discovery): nacos node failure should not corrupt in-memory data [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on PR #11253:
URL: https://github.com/apache/apisix/pull/11253#issuecomment-2153924311
@zuiyangqingzhou you migh wanna fix these first: 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(nacos discovery): nacos node failure should not corrupt in-memory data [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #11253: fix(nacos discovery): nacos node failure should not corrupt in-memory data
URL: https://github.com/apache/apisix/pull/11253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(nacos discovery): nacos node failure should not corrupt in-memory data [apisix]
Posted by "zuiyangqingzhou (via GitHub)" <gi...@apache.org>.
zuiyangqingzhou commented on PR #11253:
URL: https://github.com/apache/apisix/pull/11253#issuecomment-2159907808
> @zuiyangqingzhou you migh wanna fix these first: 😉 
@shreemaan-abhishek I just added a sixth test to `t/discovery/nacos2.t`. I don't think I caused other file problems such as `t/discovery/nacos.t` and `t/discovery/stream/nacos.t`, and the problems in these files are the same.
<img width="827" alt="image" src="https://github.com/apache/apisix/assets/17425270/1bd03463-31e4-46ba-9acf-5b890d1e80d7">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org