You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/03/28 01:49:22 UTC
[GitHub] [lucene] mocobeta opened a new pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.
mocobeta opened a new pull request #771:
URL: https://github.com/apache/lucene/pull/771
- Add `CONTRIBUTING.md`; this is based on https://cwiki.apache.org/confluence/display/lucene/HowToContribute
- Move `Building with Gradle` section in the README to CONTRIBUTING.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #771:
URL: https://github.com/apache/lucene/pull/771#issuecomment-1080405884
would anyone want to review this... i'll wait until tomorrow then merge it (if there are no objections).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836975410
##########
File path: CONTRIBUTING.md
##########
@@ -0,0 +1,124 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of all, you need the Lucene source code.
+
+Get the source code using: `git clone https://github.com/apache/lucene`
+
+### Notes for required Java version
+
+Be sure that you are using an appropriate version of the JDK. Please check [README](./README.md) for the required JDK version for current main branch.
+
+### Building with Gradle
+
+Lucene uses [Gradle](https://gradle.org/) for build control. Gradle is itself Java-based and may be incompatible with newer Java versions; you can still build and test Lucene with these Java releases, see [jvms.txt](./help/jvms.txt) for more information.
+
+Run "./gradlew help", this will show the main tasks that can be executed to show help sub-topics.
+
+If you want to build Lucene, type:
+
+```
+./gradlew assemble
+```
+
+NOTE: DO NOT use the `gradle` command that is perhaps installed on your machine. This may result in using a different gradle version than the project requires and this is known to lead to very cryptic errors. The "gradle wrapper" (gradlew script) does everything required to build the project from scratch: it downloads the correct version of gradle, sets up sane local configurations and is tested on multiple environments.
+
+The first time you run gradlew, it will create a file "gradle.properties" that contains machine-specific settings. Normally you can use this file as-is, but it can be modified if necessary.
+
+`./gradlew check` will assemble Lucene and run all validation
+ tasks (including tests).
+
+`./gradlew help` will print a list of help guides that introduce and explain
+ various parts of the build system, including typical workflow tasks.
+
+If you want to just build the documentation, type:
+
+```
+./gradlew documentation
+```
+
+### Checks
+
+Please make sure that all unit tests and validations succeed before constructing your patch: `./gradlew check`.
+
+To run a single test case from the lucene/core directory in your working copy: `./gradlew -p lucene/core test --tests NameOfYourUnitTest`. Run `./gradlew helpTests` to get more information about running tests.
+
+In case your contribution fixes a bug, please create a new test case that fails before your fix, to show the presence of the bug and ensure it never re-occurs. A test case showing the presence of a bug is also a good contribution by itself.
+
+### IDE support
+
+- *IntelliJ* - IntelliJ idea can import and build gradle-based projects out of the box.
+- *Eclipse* - Basic support ([help/IDEs.txt](https://github.com/apache/lucene/blob/main/help/IDEs.txt#L7)).
+- *Netbeans* - Not tested.
+
+## Contributing your work
+
+You have two options to contribute your work: you can either create a patch and attach it to an issue on [Jira](https://issues.apache.org/jira/browse/LUCENE), or open a pull request at https://github.com/apache/lucene - whichever works best for you.
+
+Please be patient. Committers are busy people too. If no one responds to your patch after a few days, please make friendly reminders. Please incorporate others' suggestions into into your patch if you think they're reasonable. Finally, remember that even a patch that is not committed is useful to the community.
+
+### Opening a pull request
+
+Please refer to [GitHub's documentation](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests) for an explanation of how to create a pull request. The pull request title should start with the Jira issue number that your work is related to, this way your pull request will get automatically linked from the Jira issue.
+
+### Creating a patch
+
+Note that you do not need to create a patch if you already opened a pull request on GitHub.
+
+Before creating your patch, you may want to get 'main' up to date with the latest from upstream. This will help avoid the possibility of others finding merge conflicts when applying your patch. This can be done with git pull if main is the current branch.
+
+If your changes are in your git working tree (i.e. not committed to a branch), then do this:
+
+1. Check to see what files you have modified with: `git status`
+2. Add any new files with: `git add src/.../MyNewClass.java`
+3. In order to create a patch, just type `git diff HEAD > LUCENE-NNNN.patch`
+
+If your changes are all committed to the current (feature) branch: `git diff main... > LUCENE-NNNN.patch`
+
+If some of your changes are committed to the current (feature) branch but you have working-copy changes too: `git diff {{git merge-base main head > LUCENE-NNNN.patch}}`. This will save a diff into the LUCENE-NNNN.patch file. Read the patch file. Make sure it includes ONLY the modifications required to fix a single issue.
+
+Patches should be attached to an issue in Jira.
+
+To enable automatic validation of Jira patches, switch the issue's status to "Patch Available" by clicking on the "Enable Patch Review" button near the top of the page. This will enqueue an ASF Jenkins job PreCommit-LUCENE-Build to run various quality checks on the patch and post a validation report as a comment (by "Lucene/Solr QA") on the issue. Expect a delay of 12 hours or so before the patch validation job actually runs. Note that in order for a patch file to trigger validation, its name must conform to the naming rules outlined here: https://yetus.apache.org/documentation/in-progress/precommit-patchnames/
Review comment:
note: I noticed the link to Yetus documentation is not available but can't find the moved page or alternative. I'm not sure what should we do on it, I deferred the decision here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836967733
##########
File path: CONTRIBUTING.md
##########
@@ -0,0 +1,128 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of all, you need the Lucene source code.
+
+Get the source code using: `git clone https://github.com/apache/lucene`
+
+### Notes for required Java version
+
+Be sure that you are using an appropriate version of the JDK. Please check [README](./README.md) for the required JDK version for current main branch.
+
+### Building with Gradle
+
+Lucene uses [Gradle](https://gradle.org/) for build control. Gradle is itself Java-based and may be incompatible with newer Java versions; you can still build and test Lucene with these Java releases, see [jvms.txt](./help/jvms.txt) for more information.
+
+Run "./gradlew help", this will show the main tasks that can be executed to show help sub-topics.
+
+If you want to build Lucene, type:
+
+```
+./gradlew assemble
+```
+
+NOTE: DO NOT use the `gradle` command that is perhaps installed on your machine. This may result in using a different gradle version than the project requires and this is known to lead to very cryptic errors. The "gradle wrapper" (gradlew script) does everything required to build the project from scratch: it downloads the correct version of gradle, sets up sane local configurations and is tested on multiple environments.
+
+The first time you run gradlew, it will create a file "gradle.properties" that contains machine-specific settings. Normally you can use this file as-is, but it can be modified if necessary.
+
+`./gradlew check` will assemble Lucene and run all validation
+ tasks (including tests).
+
+`./gradlew help` will print a list of help guides that introduce and explain
+ various parts of the build system, including typical workflow tasks.
+
+If you want to just build the documentation, type:
+
+```
+./gradlew documentation
+```
+
+### Unit tests
+
+Please make sure that all unit tests succeed before constructing your patch: `./gradlew test`.
+
+To run a single test case from the lucene/core directory in your working copy: `./gradlew -p lucene/core test --tests NameOfYourUnitTest`. Run `./gradlew helpTests` to get more information about running tests.
+
+In case your contribution fixes a bug, please create a new test case that fails before your fix, to show the presence of the bug and ensure it never re-occurs. A test case showing the presence of a bug is also a good contribution by itself.
+
+### Precommit
+
+Please run `./gradlew precommit` to identify problems that should be addressed before you contribute your changes.
Review comment:
this section was removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836967094
##########
File path: CONTRIBUTING.md
##########
@@ -0,0 +1,128 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of all, you need the Lucene source code.
+
+Get the source code using: `git clone https://github.com/apache/lucene`
+
+### Notes for required Java version
+
+Be sure that you are using an appropriate version of the JDK. Please check [README](./README.md) for the required JDK version for current main branch.
+
+### Building with Gradle
+
+Lucene uses [Gradle](https://gradle.org/) for build control. Gradle is itself Java-based and may be incompatible with newer Java versions; you can still build and test Lucene with these Java releases, see [jvms.txt](./help/jvms.txt) for more information.
+
+Run "./gradlew help", this will show the main tasks that can be executed to show help sub-topics.
+
+If you want to build Lucene, type:
+
+```
+./gradlew assemble
+```
+
+NOTE: DO NOT use the `gradle` command that is perhaps installed on your machine. This may result in using a different gradle version than the project requires and this is known to lead to very cryptic errors. The "gradle wrapper" (gradlew script) does everything required to build the project from scratch: it downloads the correct version of gradle, sets up sane local configurations and is tested on multiple environments.
+
+The first time you run gradlew, it will create a file "gradle.properties" that contains machine-specific settings. Normally you can use this file as-is, but it can be modified if necessary.
+
+`./gradlew check` will assemble Lucene and run all validation
+ tasks (including tests).
+
+`./gradlew help` will print a list of help guides that introduce and explain
+ various parts of the build system, including typical workflow tasks.
+
+If you want to just build the documentation, type:
+
+```
+./gradlew documentation
+```
+
+### Unit tests
+
+Please make sure that all unit tests succeed before constructing your patch: `./gradlew test`.
Review comment:
Changed this section to encourage to use "gradlew check".
https://github.com/mocobeta/lucene/blob/lucene-10184/CONTRIBUTING.md#checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836744907
##########
File path: CONTRIBUTING.md
##########
@@ -0,0 +1,128 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of all, you need the Lucene source code.
+
+Get the source code using: `git clone https://github.com/apache/lucene`
+
+### Notes for required Java version
+
+Be sure that you are using an appropriate version of the JDK. Please check [README](./README.md) for the required JDK version for current main branch.
+
+### Building with Gradle
+
+Lucene uses [Gradle](https://gradle.org/) for build control. Gradle is itself Java-based and may be incompatible with newer Java versions; you can still build and test Lucene with these Java releases, see [jvms.txt](./help/jvms.txt) for more information.
+
+Run "./gradlew help", this will show the main tasks that can be executed to show help sub-topics.
+
+If you want to build Lucene, type:
+
+```
+./gradlew assemble
+```
+
+NOTE: DO NOT use the `gradle` command that is perhaps installed on your machine. This may result in using a different gradle version than the project requires and this is known to lead to very cryptic errors. The "gradle wrapper" (gradlew script) does everything required to build the project from scratch: it downloads the correct version of gradle, sets up sane local configurations and is tested on multiple environments.
+
+The first time you run gradlew, it will create a file "gradle.properties" that contains machine-specific settings. Normally you can use this file as-is, but it can be modified if necessary.
+
+`./gradlew check` will assemble Lucene and run all validation
+ tasks (including tests).
+
+`./gradlew help` will print a list of help guides that introduce and explain
+ various parts of the build system, including typical workflow tasks.
+
+If you want to just build the documentation, type:
+
+```
+./gradlew documentation
+```
+
+### Unit tests
+
+Please make sure that all unit tests succeed before constructing your patch: `./gradlew test`.
+
+To run a single test case from the lucene/core directory in your working copy: `./gradlew -p lucene/core test --tests NameOfYourUnitTest`. Run `./gradlew helpTests` to get more information about running tests.
+
+In case your contribution fixes a bug, please create a new test case that fails before your fix, to show the presence of the bug and ensure it never re-occurs. A test case showing the presence of a bug is also a good contribution by itself.
+
+### Precommit
+
+Please run `./gradlew precommit` to identify problems that should be addressed before you contribute your changes.
Review comment:
Use "gradlew check" here. I'd be willing to phase out the non-convention "precommit" at some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836975410
##########
File path: CONTRIBUTING.md
##########
@@ -0,0 +1,124 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of all, you need the Lucene source code.
+
+Get the source code using: `git clone https://github.com/apache/lucene`
+
+### Notes for required Java version
+
+Be sure that you are using an appropriate version of the JDK. Please check [README](./README.md) for the required JDK version for current main branch.
+
+### Building with Gradle
+
+Lucene uses [Gradle](https://gradle.org/) for build control. Gradle is itself Java-based and may be incompatible with newer Java versions; you can still build and test Lucene with these Java releases, see [jvms.txt](./help/jvms.txt) for more information.
+
+Run "./gradlew help", this will show the main tasks that can be executed to show help sub-topics.
+
+If you want to build Lucene, type:
+
+```
+./gradlew assemble
+```
+
+NOTE: DO NOT use the `gradle` command that is perhaps installed on your machine. This may result in using a different gradle version than the project requires and this is known to lead to very cryptic errors. The "gradle wrapper" (gradlew script) does everything required to build the project from scratch: it downloads the correct version of gradle, sets up sane local configurations and is tested on multiple environments.
+
+The first time you run gradlew, it will create a file "gradle.properties" that contains machine-specific settings. Normally you can use this file as-is, but it can be modified if necessary.
+
+`./gradlew check` will assemble Lucene and run all validation
+ tasks (including tests).
+
+`./gradlew help` will print a list of help guides that introduce and explain
+ various parts of the build system, including typical workflow tasks.
+
+If you want to just build the documentation, type:
+
+```
+./gradlew documentation
+```
+
+### Checks
+
+Please make sure that all unit tests and validations succeed before constructing your patch: `./gradlew check`.
+
+To run a single test case from the lucene/core directory in your working copy: `./gradlew -p lucene/core test --tests NameOfYourUnitTest`. Run `./gradlew helpTests` to get more information about running tests.
+
+In case your contribution fixes a bug, please create a new test case that fails before your fix, to show the presence of the bug and ensure it never re-occurs. A test case showing the presence of a bug is also a good contribution by itself.
+
+### IDE support
+
+- *IntelliJ* - IntelliJ idea can import and build gradle-based projects out of the box.
+- *Eclipse* - Basic support ([help/IDEs.txt](https://github.com/apache/lucene/blob/main/help/IDEs.txt#L7)).
+- *Netbeans* - Not tested.
+
+## Contributing your work
+
+You have two options to contribute your work: you can either create a patch and attach it to an issue on [Jira](https://issues.apache.org/jira/browse/LUCENE), or open a pull request at https://github.com/apache/lucene - whichever works best for you.
+
+Please be patient. Committers are busy people too. If no one responds to your patch after a few days, please make friendly reminders. Please incorporate others' suggestions into into your patch if you think they're reasonable. Finally, remember that even a patch that is not committed is useful to the community.
+
+### Opening a pull request
+
+Please refer to [GitHub's documentation](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests) for an explanation of how to create a pull request. The pull request title should start with the Jira issue number that your work is related to, this way your pull request will get automatically linked from the Jira issue.
+
+### Creating a patch
+
+Note that you do not need to create a patch if you already opened a pull request on GitHub.
+
+Before creating your patch, you may want to get 'main' up to date with the latest from upstream. This will help avoid the possibility of others finding merge conflicts when applying your patch. This can be done with git pull if main is the current branch.
+
+If your changes are in your git working tree (i.e. not committed to a branch), then do this:
+
+1. Check to see what files you have modified with: `git status`
+2. Add any new files with: `git add src/.../MyNewClass.java`
+3. In order to create a patch, just type `git diff HEAD > LUCENE-NNNN.patch`
+
+If your changes are all committed to the current (feature) branch: `git diff main... > LUCENE-NNNN.patch`
+
+If some of your changes are committed to the current (feature) branch but you have working-copy changes too: `git diff {{git merge-base main head > LUCENE-NNNN.patch}}`. This will save a diff into the LUCENE-NNNN.patch file. Read the patch file. Make sure it includes ONLY the modifications required to fix a single issue.
+
+Patches should be attached to an issue in Jira.
+
+To enable automatic validation of Jira patches, switch the issue's status to "Patch Available" by clicking on the "Enable Patch Review" button near the top of the page. This will enqueue an ASF Jenkins job PreCommit-LUCENE-Build to run various quality checks on the patch and post a validation report as a comment (by "Lucene/Solr QA") on the issue. Expect a delay of 12 hours or so before the patch validation job actually runs. Note that in order for a patch file to trigger validation, its name must conform to the naming rules outlined here: https://yetus.apache.org/documentation/in-progress/precommit-patchnames/
Review comment:
note: I noticed the link to Yetus documentation is not available but couldn't find the moved page or alternative. I'm not sure what should we do on it, I deferred the decision here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836975410
##########
File path: CONTRIBUTING.md
##########
@@ -0,0 +1,124 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of all, you need the Lucene source code.
+
+Get the source code using: `git clone https://github.com/apache/lucene`
+
+### Notes for required Java version
+
+Be sure that you are using an appropriate version of the JDK. Please check [README](./README.md) for the required JDK version for current main branch.
+
+### Building with Gradle
+
+Lucene uses [Gradle](https://gradle.org/) for build control. Gradle is itself Java-based and may be incompatible with newer Java versions; you can still build and test Lucene with these Java releases, see [jvms.txt](./help/jvms.txt) for more information.
+
+Run "./gradlew help", this will show the main tasks that can be executed to show help sub-topics.
+
+If you want to build Lucene, type:
+
+```
+./gradlew assemble
+```
+
+NOTE: DO NOT use the `gradle` command that is perhaps installed on your machine. This may result in using a different gradle version than the project requires and this is known to lead to very cryptic errors. The "gradle wrapper" (gradlew script) does everything required to build the project from scratch: it downloads the correct version of gradle, sets up sane local configurations and is tested on multiple environments.
+
+The first time you run gradlew, it will create a file "gradle.properties" that contains machine-specific settings. Normally you can use this file as-is, but it can be modified if necessary.
+
+`./gradlew check` will assemble Lucene and run all validation
+ tasks (including tests).
+
+`./gradlew help` will print a list of help guides that introduce and explain
+ various parts of the build system, including typical workflow tasks.
+
+If you want to just build the documentation, type:
+
+```
+./gradlew documentation
+```
+
+### Checks
+
+Please make sure that all unit tests and validations succeed before constructing your patch: `./gradlew check`.
+
+To run a single test case from the lucene/core directory in your working copy: `./gradlew -p lucene/core test --tests NameOfYourUnitTest`. Run `./gradlew helpTests` to get more information about running tests.
+
+In case your contribution fixes a bug, please create a new test case that fails before your fix, to show the presence of the bug and ensure it never re-occurs. A test case showing the presence of a bug is also a good contribution by itself.
+
+### IDE support
+
+- *IntelliJ* - IntelliJ idea can import and build gradle-based projects out of the box.
+- *Eclipse* - Basic support ([help/IDEs.txt](https://github.com/apache/lucene/blob/main/help/IDEs.txt#L7)).
+- *Netbeans* - Not tested.
+
+## Contributing your work
+
+You have two options to contribute your work: you can either create a patch and attach it to an issue on [Jira](https://issues.apache.org/jira/browse/LUCENE), or open a pull request at https://github.com/apache/lucene - whichever works best for you.
+
+Please be patient. Committers are busy people too. If no one responds to your patch after a few days, please make friendly reminders. Please incorporate others' suggestions into into your patch if you think they're reasonable. Finally, remember that even a patch that is not committed is useful to the community.
+
+### Opening a pull request
+
+Please refer to [GitHub's documentation](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests) for an explanation of how to create a pull request. The pull request title should start with the Jira issue number that your work is related to, this way your pull request will get automatically linked from the Jira issue.
+
+### Creating a patch
+
+Note that you do not need to create a patch if you already opened a pull request on GitHub.
+
+Before creating your patch, you may want to get 'main' up to date with the latest from upstream. This will help avoid the possibility of others finding merge conflicts when applying your patch. This can be done with git pull if main is the current branch.
+
+If your changes are in your git working tree (i.e. not committed to a branch), then do this:
+
+1. Check to see what files you have modified with: `git status`
+2. Add any new files with: `git add src/.../MyNewClass.java`
+3. In order to create a patch, just type `git diff HEAD > LUCENE-NNNN.patch`
+
+If your changes are all committed to the current (feature) branch: `git diff main... > LUCENE-NNNN.patch`
+
+If some of your changes are committed to the current (feature) branch but you have working-copy changes too: `git diff {{git merge-base main head > LUCENE-NNNN.patch}}`. This will save a diff into the LUCENE-NNNN.patch file. Read the patch file. Make sure it includes ONLY the modifications required to fix a single issue.
+
+Patches should be attached to an issue in Jira.
+
+To enable automatic validation of Jira patches, switch the issue's status to "Patch Available" by clicking on the "Enable Patch Review" button near the top of the page. This will enqueue an ASF Jenkins job PreCommit-LUCENE-Build to run various quality checks on the patch and post a validation report as a comment (by "Lucene/Solr QA") on the issue. Expect a delay of 12 hours or so before the patch validation job actually runs. Note that in order for a patch file to trigger validation, its name must conform to the naming rules outlined here: https://yetus.apache.org/documentation/in-progress/precommit-patchnames/
Review comment:
note: I noticed the link to Yetus documentation is not available but couldn't find the moved page or alternative. I'm not sure what should we do on it, I'd defer the decision here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta merged pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.
Posted by GitBox <gi...@apache.org>.
mocobeta merged pull request #771:
URL: https://github.com/apache/lucene/pull/771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r837081228
##########
File path: CONTRIBUTING.md
##########
@@ -0,0 +1,124 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of all, you need the Lucene source code.
+
+Get the source code using: `git clone https://github.com/apache/lucene`
+
+### Notes for required Java version
+
+Be sure that you are using an appropriate version of the JDK. Please check [README](./README.md) for the required JDK version for current main branch.
+
+### Building with Gradle
+
+Lucene uses [Gradle](https://gradle.org/) for build control. Gradle is itself Java-based and may be incompatible with newer Java versions; you can still build and test Lucene with these Java releases, see [jvms.txt](./help/jvms.txt) for more information.
+
+Run "./gradlew help", this will show the main tasks that can be executed to show help sub-topics.
+
+If you want to build Lucene, type:
+
+```
+./gradlew assemble
+```
+
+NOTE: DO NOT use the `gradle` command that is perhaps installed on your machine. This may result in using a different gradle version than the project requires and this is known to lead to very cryptic errors. The "gradle wrapper" (gradlew script) does everything required to build the project from scratch: it downloads the correct version of gradle, sets up sane local configurations and is tested on multiple environments.
+
+The first time you run gradlew, it will create a file "gradle.properties" that contains machine-specific settings. Normally you can use this file as-is, but it can be modified if necessary.
+
+`./gradlew check` will assemble Lucene and run all validation
+ tasks (including tests).
+
+`./gradlew help` will print a list of help guides that introduce and explain
+ various parts of the build system, including typical workflow tasks.
+
+If you want to just build the documentation, type:
+
+```
+./gradlew documentation
+```
+
+### Checks
+
+Please make sure that all unit tests and validations succeed before constructing your patch: `./gradlew check`.
+
+To run a single test case from the lucene/core directory in your working copy: `./gradlew -p lucene/core test --tests NameOfYourUnitTest`. Run `./gradlew helpTests` to get more information about running tests.
+
+In case your contribution fixes a bug, please create a new test case that fails before your fix, to show the presence of the bug and ensure it never re-occurs. A test case showing the presence of a bug is also a good contribution by itself.
+
+### IDE support
+
+- *IntelliJ* - IntelliJ idea can import and build gradle-based projects out of the box.
+- *Eclipse* - Basic support ([help/IDEs.txt](https://github.com/apache/lucene/blob/main/help/IDEs.txt#L7)).
+- *Netbeans* - Not tested.
+
+## Contributing your work
+
+You have two options to contribute your work: you can either create a patch and attach it to an issue on [Jira](https://issues.apache.org/jira/browse/LUCENE), or open a pull request at https://github.com/apache/lucene - whichever works best for you.
+
+Please be patient. Committers are busy people too. If no one responds to your patch after a few days, please make friendly reminders. Please incorporate others' suggestions into into your patch if you think they're reasonable. Finally, remember that even a patch that is not committed is useful to the community.
+
+### Opening a pull request
+
+Please refer to [GitHub's documentation](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests) for an explanation of how to create a pull request. The pull request title should start with the Jira issue number that your work is related to, this way your pull request will get automatically linked from the Jira issue.
+
+### Creating a patch
+
+Note that you do not need to create a patch if you already opened a pull request on GitHub.
+
+Before creating your patch, you may want to get 'main' up to date with the latest from upstream. This will help avoid the possibility of others finding merge conflicts when applying your patch. This can be done with git pull if main is the current branch.
+
+If your changes are in your git working tree (i.e. not committed to a branch), then do this:
+
+1. Check to see what files you have modified with: `git status`
+2. Add any new files with: `git add src/.../MyNewClass.java`
+3. In order to create a patch, just type `git diff HEAD > LUCENE-NNNN.patch`
+
+If your changes are all committed to the current (feature) branch: `git diff main... > LUCENE-NNNN.patch`
+
+If some of your changes are committed to the current (feature) branch but you have working-copy changes too: `git diff {{git merge-base main head > LUCENE-NNNN.patch}}`. This will save a diff into the LUCENE-NNNN.patch file. Read the patch file. Make sure it includes ONLY the modifications required to fix a single issue.
+
+Patches should be attached to an issue in Jira.
+
+To enable automatic validation of Jira patches, switch the issue's status to "Patch Available" by clicking on the "Enable Patch Review" button near the top of the page. This will enqueue an ASF Jenkins job PreCommit-LUCENE-Build to run various quality checks on the patch and post a validation report as a comment (by "Lucene/Solr QA") on the issue. Expect a delay of 12 hours or so before the patch validation job actually runs. Note that in order for a patch file to trigger validation, its name must conform to the naming rules outlined here: https://yetus.apache.org/documentation/in-progress/precommit-patchnames/
Review comment:
I've no idea too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #771:
URL: https://github.com/apache/lucene/pull/771#issuecomment-1081544897
Merged. Thank you for your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836744402
##########
File path: CONTRIBUTING.md
##########
@@ -0,0 +1,128 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of all, you need the Lucene source code.
+
+Get the source code using: `git clone https://github.com/apache/lucene`
+
+### Notes for required Java version
+
+Be sure that you are using an appropriate version of the JDK. Please check [README](./README.md) for the required JDK version for current main branch.
+
+### Building with Gradle
+
+Lucene uses [Gradle](https://gradle.org/) for build control. Gradle is itself Java-based and may be incompatible with newer Java versions; you can still build and test Lucene with these Java releases, see [jvms.txt](./help/jvms.txt) for more information.
+
+Run "./gradlew help", this will show the main tasks that can be executed to show help sub-topics.
+
+If you want to build Lucene, type:
+
+```
+./gradlew assemble
+```
+
+NOTE: DO NOT use the `gradle` command that is perhaps installed on your machine. This may result in using a different gradle version than the project requires and this is known to lead to very cryptic errors. The "gradle wrapper" (gradlew script) does everything required to build the project from scratch: it downloads the correct version of gradle, sets up sane local configurations and is tested on multiple environments.
+
+The first time you run gradlew, it will create a file "gradle.properties" that contains machine-specific settings. Normally you can use this file as-is, but it can be modified if necessary.
+
+`./gradlew check` will assemble Lucene and run all validation
+ tasks (including tests).
+
+`./gradlew help` will print a list of help guides that introduce and explain
+ various parts of the build system, including typical workflow tasks.
+
+If you want to just build the documentation, type:
+
+```
+./gradlew documentation
+```
+
+### Unit tests
+
+Please make sure that all unit tests succeed before constructing your patch: `./gradlew test`.
Review comment:
I think it'd be good to run check instead of just test. We have so many validation checks that just the test alone won't do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org