You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2020/08/30 16:31:59 UTC
[GitHub] [incubator-pegasus] Smityz opened a new pull request #591: feat: add communication protocol of hotkey detection
Smityz opened a new pull request #591:
URL: https://github.com/apache/incubator-pegasus/pull/591
Ref: https://github.com/apache/incubator-pegasus/issues/588 (Step 1)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a change in pull request #591: feat: add communication protocol of hotkey detection
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on a change in pull request #591:
URL: https://github.com/apache/incubator-pegasus/pull/591#discussion_r480040072
##########
File path: src/idl/rrdb.thrift
##########
@@ -46,6 +46,20 @@ enum mutate_operation
MO_DELETE
}
+enum hotkey_type
+{
+ READ,
+ WRITE
+}
+
+enum hotkey_collector_operation
Review comment:
Would `hotkey_detect_action` be better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] neverchanje merged pull request #591: feat: add rpc structs for hotkey detection
Posted by GitBox <gi...@apache.org>.
neverchanje merged pull request #591:
URL: https://github.com/apache/incubator-pegasus/pull/591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] neverchanje commented on a change in pull request #591: feat: add communication protocol of hotkey detection
Posted by GitBox <gi...@apache.org>.
neverchanje commented on a change in pull request #591:
URL: https://github.com/apache/incubator-pegasus/pull/591#discussion_r484611155
##########
File path: src/idl/rrdb.thrift
##########
@@ -46,6 +46,20 @@ enum mutate_operation
MO_DELETE
}
+enum hotkey_type
+{
+ READ,
+ WRITE
+}
+
+enum hotkey_detect_action
+{
+ START,
+ STOP
+}
+
+
+
Review comment:
remove these empty lines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org