You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "breautek (via GitHub)" <gi...@apache.org> on 2023/05/03 13:10:05 UTC

[GitHub] [cordova-ios] breautek opened a new pull request, #1323: feat!: Bump minimum deployment target to 12.0

breautek opened a new pull request, #1323:
URL: https://github.com/apache/cordova-ios/pull/1323

   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   iOS
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Some features are being introduced (such as #1309) which requires iOS 12+
   
   ### Description
   <!-- Describe your changes in detail -->
   
   Bump all occurrences `IPHONEOS_DEPLOYMENT_TARGET` to `12.0`, including the app project template, CordovaLib, and test files.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   Letting CI do the testing.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] dpogue commented on pull request #1323: feat!: Bump minimum deployment target to 12.0

Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #1323:
URL: https://github.com/apache/cordova-ios/pull/1323#issuecomment-1546715677

   > I don't think we have any particular deadlines to meet so we can wait to see what XCode 15 will support when it's beta comes out.
   
   WWDC is June 5th, so we should be able to find out fairly soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] breautek closed pull request #1323: feat!: Bump minimum deployment target to 12.0

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek closed pull request #1323: feat!: Bump minimum deployment target to 12.0
URL: https://github.com/apache/cordova-ios/pull/1323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] jcesarmobile commented on pull request #1323: feat!: Bump minimum deployment target to 12.0

Posted by "jcesarmobile (via GitHub)" <gi...@apache.org>.
jcesarmobile commented on PR #1323:
URL: https://github.com/apache/cordova-ios/pull/1323#issuecomment-1578156972

   One thing that was mentioned on the Android minSDK bump was the Chrome version. We bumped to minSDK 24 and was mentioned that the Chrome version included in the Android image was 52, so we would stick to Chrome's 52 features/support on the javascript side.
   Any idea if iOS 11 WebView supports same features as Chrome 52?
   
   In example the eslint changes from latest `@cordova/eslint-config` made the code of [screen orientation plugin](https://github.com/apache/cordova-plugin-screen-orientation/pull/112) not compatible with old android versions just because it uses let/const instead of var.
   That doesn't seem an issue on iOS 11, but not sure if other rule changes could be not compatible with iOS 11.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] jcesarmobile commented on pull request #1323: feat!: Bump minimum deployment target to 12.0

Posted by "jcesarmobile (via GitHub)" <gi...@apache.org>.
jcesarmobile commented on PR #1323:
URL: https://github.com/apache/cordova-ios/pull/1323#issuecomment-1533102929

   It's still not clear if we are going to merge https://github.com/apache/cordova-ios/pull/1309 since some people might want to keep using different icons for different devices or for push notifications.
   
   We should have a more formal mail (or vote?) about bumping the deployment target.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] breautek commented on pull request #1323: feat!: Bump minimum deployment target to 12.0

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #1323:
URL: https://github.com/apache/cordova-ios/pull/1323#issuecomment-1578872888

   Sounds like we prefer to keep iOS 11 as the minimum target, so I'll close this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] breautek commented on pull request #1323: feat!: Bump minimum deployment target to 12.0

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #1323:
URL: https://github.com/apache/cordova-ios/pull/1323#issuecomment-1546702740

   > Can it be confirmed if CordovaLib can stay at 11.0, but only bump the project template to 12.0?
   > 
   > Maybe the project template could be increased to support new features (one-icon), but allowing anyone else who use only the CordovaLib in their non-Cordova project to continue to support iOS 11.
   
   I didn't test via code change, but setting the deployment targets manually in xcode will still allows us to build as long as the App target is >= the deployment target of `CordovaLib` target.
   
   The bigger concern is how XCode behaves if you attempt to configure a target to a version that it no longer supports (and is not selectable via the UI). To test this, I installed cordova-ios@5 platform which tries to set the deployment target to 10.0.
   
   The observed behaviour is in the XCode UI, under the App target, you see Deployment Target 10 (when it's normally not selectable in the dropdown menu). Under the `CordovaLib` target, the target is set to `default`
   
   ![Screenshot 2023-05-13 at 9 02 41 AM](https://github.com/apache/cordova-ios/assets/11200662/c3f5be49-e350-4dba-b244-04d6612e7d74)
   
   When attempting to build this project, the following errors are produced:
   
   ```
   note: Building targets in dependency order
   /Users/norman/development/cordova/test/iostest/platforms/ios/CordovaLib/CordovaLib.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 10.0, but the range of supported deployment target versions is 11.0 to 16.4.99. (in target 'CordovaLib' from project 'CordovaLib')
   /Users/norman/development/cordova/test/iostest/platforms/ios/HelloCordova.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 10.0, but the range of supported deployment target versions is 11.0 to 16.4.99. (in target 'HelloCordova' from project 'HelloCordova')
   /Users/norman/development/cordova/test/iostest/platforms/ios/HelloCordova.xcodeproj: error: Signing for "HelloCordova" requires a development team. Select a development team in the Signing & Capabilities editor. (in target 'HelloCordova' from project 'HelloCordova')
   warning: Run script build phase 'Copy www directory' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'HelloCordova' from project 'HelloCordova')
   ** ARCHIVE FAILED **
   ```
   
   So there are two parts:
   
   ```
   /Users/norman/development/cordova/test/iostest/platforms/ios/CordovaLib/CordovaLib.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 10.0, but the range of supported deployment target versions is 11.0 to 16.4.99. (in target 'CordovaLib' from project 'CordovaLib')
   ```
   
   Shows that despite the UI, CordovaLib **is** being attempted to built with a deployment target of 10.0, as expected for Cordova-ios@5, but XCode 14.3 is refusing to build it since it can only build deployment targets 11+
   
   Likewise, the same erroris also reproduced for the app target:
   
   ```
   /Users/norman/development/cordova/test/iostest/platforms/ios/HelloCordova.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 10.0, but the range of supported deployment target versions is 11.0 to 16.4.99. (in target 'HelloCordova' from project 'HelloCordova')
   ```
   
   This is further reinforced by their documentation for minimum SDK and requirements:
   
   ![image](https://github.com/apache/cordova-ios/assets/11200662/ef9bb3f5-966e-4f91-a825-57d015a1e4cb)
   
   So based on this current behaviour there is a chance that XCode 15 will drop support for iOS 11. If that happens and if we aren't proactive on it, then we may need to make another major release to drop support for iOS 11 at that time. I don't think we have any particular deadlines to meet so we can wait to see what XCode 15 will support when it's beta comes out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] breautek commented on pull request #1323: feat!: Bump minimum deployment target to 12.0

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #1323:
URL: https://github.com/apache/cordova-ios/pull/1323#issuecomment-1578858120

   > One thing that was mentioned on the Android minSDK bump was the Chrome version. We bumped to minSDK 24 and was mentioned that the Chrome version included in the Android image was 52, so we would stick to Chrome's 52 features/support on the javascript side. Any idea if iOS 11 WebView supports same features as Chrome 52?
   > 
   > In example the eslint changes from latest `@cordova/eslint-config` made the code of [screen orientation plugin](https://github.com/apache/cordova-plugin-screen-orientation/pull/112) not compatible with old android versions just because it uses let/const instead of var. That doesn't seem an issue on iOS 11, but not sure if other rule changes could be not compatible with iOS 11.
   
   It is good point,
   
   ES6 (which includes stuff liek arrow functions, native promises, let/const, etc...) has good support since iOS 10, and since Chrome 51.
   
   Specific ES6 features like `let` keyword may show slightly different compatibility, for example [caniuse](https://caniuse.com/let) says it's only supported in iOS 11 (iOS 10 had a buggy version of it), and chrome supported it in Chrome 49, or 41 if strict mode was enabled.
   
   But overall, ES6 features should be pretty safe to use without any external tools, even if we keep iOS 11 as our minimum requirement.
   
   https://caniuse.com/?search=ES6


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] breautek commented on pull request #1323: feat!: Bump minimum deployment target to 12.0

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #1323:
URL: https://github.com/apache/cordova-ios/pull/1323#issuecomment-1533106766

   > It's still not clear if we are going to merge #1309 since some people might want to keep using different icons for different devices or for push notifications.
   > 
   > We should have a more formal mail (or vote?) about bumping the deployment target.
   
   I had the same thought and a discuss thread should be arriving shortly. Will post link once it appears in ponymail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] dpogue commented on pull request #1323: feat!: Bump minimum deployment target to 12.0

Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #1323:
URL: https://github.com/apache/cordova-ios/pull/1323#issuecomment-1533102839

   Question: When we override the iOS deployment target via a preference, does that apply to just the app project or also to CordovaLib?
   
   Essentially, if somebody wanted to provide all the old icon sizes using a hook or something, can they lower the deployment target back to 11 using config.xml, or will Xcode error because CordovaLib requires a higher version (even though there's not actually anything in CordovaLib that requires iOS 12)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] dpogue commented on pull request #1323: feat!: Bump minimum deployment target to 12.0

Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #1323:
URL: https://github.com/apache/cordova-ios/pull/1323#issuecomment-1577814699

   Testing with Xcode 15 reveals that it has iOS 12 as the minimum supported SDK, and produces a warning (for each project) if the target version is lower. But it builds and runs fine with no issues.
   
   I don't think there's a way to get rid of that warning without bumping the version number, but there's also no specific need to bump it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] erisu commented on pull request #1323: feat!: Bump minimum deployment target to 12.0

Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on PR #1323:
URL: https://github.com/apache/cordova-ios/pull/1323#issuecomment-1537330168

   Can it be confirmed if CordovaLib can stay at 11.0, but only bump the project template to 12.0?
   
   Maybe the project template could be increased to support new features (one-icon), but allowing anyone else who use only the CordovaLib in their non-Cordova project to continue to support iOS 11.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] codecov-commenter commented on pull request #1323: (WIP) feat!: Bump minimum deployment target to 12.0

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1323:
URL: https://github.com/apache/cordova-ios/pull/1323#issuecomment-1533027060

   ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1323?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1323](https://app.codecov.io/gh/apache/cordova-ios/pull/1323?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (15145bf) into [master](https://app.codecov.io/gh/apache/cordova-ios/commit/1a5cd45e2243b239b5045a0ade9d2da1d779b72a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a5cd45) will **not change** coverage.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1323   +/-   ##
   =======================================
     Coverage   78.51%   78.51%           
   =======================================
     Files          15       15           
     Lines        1778     1778           
   =======================================
     Hits         1396     1396           
     Misses        382      382           
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/cordova-ios/pull/1323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [lib/Podfile.js](https://app.codecov.io/gh/apache/cordova-ios/pull/1323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL1BvZGZpbGUuanM=) | `75.12% <100.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] breautek commented on pull request #1323: feat!: Bump minimum deployment target to 12.0

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #1323:
URL: https://github.com/apache/cordova-ios/pull/1323#issuecomment-1533006859

   ![Screenshot 2023-05-03 at 9 48 57 AM](https://user-images.githubusercontent.com/11200662/235925590-662a0a6c-c335-4d67-a129-6f10799ebc15.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org