You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "costajohnt (via GitHub)" <gi...@apache.org> on 2026/01/26 23:50:27 UTC
[PR] fix: rename 'Truncate Axis' to 'Truncate Y Axis' in bar chart [superset]
costajohnt opened a new pull request, #37457:
URL: https://github.com/apache/superset/pull/37457
## Summary
- Renames the "Truncate Axis" label to "Truncate Y Axis" in bar chart controls
- Updates the description text to match
This clarifies which axis the control applies to, making it consistent with "Truncate X Axis".
## Test plan
- [x] Verified no tests reference the label text directly
- [x] Visual change only - no functional changes
Closes #37400
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: rename 'Truncate Axis' to 'Truncate Y Axis' in bar chart [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #37457:
URL: https://github.com/apache/superset/pull/37457#discussion_r2733289729
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx:
##########
@@ -243,10 +243,10 @@ function createAxisControl(axis: 'x' | 'y'): ControlSetRow[] {
name: 'truncateYAxis',
config: {
type: 'CheckboxControl',
- label: t('Truncate Axis'),
+ label: t('Truncate Y Axis'),
Review Comment:
Does this need to be made dynamic for when the user switches between horizontal and vertical mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: rename 'Truncate Axis' to 'Truncate Y Axis' in bar chart [superset]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #37457:
URL: https://github.com/apache/superset/pull/37457#discussion_r2733347035
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx:
##########
@@ -243,10 +243,10 @@ function createAxisControl(axis: 'x' | 'y'): ControlSetRow[] {
name: 'truncateYAxis',
config: {
type: 'CheckboxControl',
- label: t('Truncate Axis'),
+ label: t('Truncate Y Axis'),
default: truncateYAxis,
renderTrigger: true,
- description: t('It’s not recommended to truncate axis in Bar chart.'),
+ description: t('It’s not recommended to truncate Y axis in Bar chart.'),
Review Comment:
In this bar chart control panel, `truncateYAxis` is used as the “value axis truncation” flag and the axis configs are swapped when `orientation === Horizontal` (see `Timeseries/transformProps.ts` where `[xAxis, yAxis] = [yAxis, xAxis]`). Because of that, this checkbox is visible under the **X Axis** section for horizontal bars (via the `visibility` callback) and effectively truncates the rendered X axis, not Y. Hardcoding the label/description to “Y Axis” will be misleading in horizontal orientation. Consider making the label/description orientation-aware (e.g., show “Truncate X Axis” when horizontal and “Truncate Y Axis” when vertical) or using an orientation-agnostic term like “Truncate value axis” to stay accurate in both modes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: rename 'Truncate Axis' to 'Truncate Y Axis' in bar chart [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke closed pull request #37457: fix: rename 'Truncate Axis' to 'Truncate Y Axis' in bar chart
URL: https://github.com/apache/superset/pull/37457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: rename 'Truncate Axis' to 'Truncate Y Axis' in bar chart [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37457:
URL: https://github.com/apache/superset/pull/37457#issuecomment-3806791118
<!-- Bito Reply -->
The visibility of the truncate axis control is already dynamic, appearing only when the chart mode matches (horizontal for X-axis, vertical for Y-axis). The label specifies 'Y Axis' as the control targets the Y-axis in vertical bar charts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: rename 'Truncate Axis' to 'Truncate Y Axis' in bar chart [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37457:
URL: https://github.com/apache/superset/pull/37457#issuecomment-3802324882
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: rename 'Truncate Axis' to 'Truncate Y Axis' in bar chart [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #37457:
URL: https://github.com/apache/superset/pull/37457#issuecomment-3819641431
Closing this in favor of https://github.com/apache/superset/pull/37403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: rename 'Truncate Axis' to 'Truncate Y Axis' in bar chart [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #37457:
URL: https://github.com/apache/superset/pull/37457#issuecomment-3819644369
Thank you for your contribution but someone else had already opened a pull request to fix this and it had been linked to that issue. Closing this in favor of https://github.com/apache/superset/pull/37403 but if you find another issue to contribute on, that would be great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org