You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/11/03 19:42:25 UTC
[GitHub] [fineract] IOhacker opened a new pull request #1951: Idempotency Support (FINERACT-1420)
IOhacker opened a new pull request #1951:
URL: https://github.com/apache/fineract/pull/1951
## Description
This PR is being sent for the initial review of the proposal implementation documented in the FINERACT-1420 Jira Ticket. Only one class SavingsProductsApiResource.java has in the POST the proposed solution for accepting incoming x-idempotency-key headers.
I will be glad to hear for your opinions.
A more detailed information can be found here
https://docs.google.com/presentation/d/13lw2JqE9ujHVFwmynjJcVIUA3NfcDkbs729VLgadIXE/edit?usp=sharing
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [X] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [X] Create/update unit or integration tests for verifying the changes made.
- [X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [X] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1951: Idempotency Support (FINERACT-1420)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1951:
URL: https://github.com/apache/fineract/pull/1951#issuecomment-986139376
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1951: Idempotency Support (FINERACT-1420)
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1951:
URL: https://github.com/apache/fineract/pull/1951#issuecomment-960333145
Hello James,
It is queued, not running in TravisCI, waiting for the excution
https://app.travis-ci.com/github/apache/fineract/builds/241137906
El mié, 3 nov 2021 a las 17:50, James D ***@***.***>)
escribió:
> This looks like a good set of changes. What is failing on the Travis CI?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1951#issuecomment-960300857>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZAWSUIN7IRFCI2VO5SDUKHKDXANCNFSM5HJY6I2Q>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola closed pull request #1951: Idempotency Support (FINERACT-1420)
Posted by GitBox <gi...@apache.org>.
ptuomola closed pull request #1951:
URL: https://github.com/apache/fineract/pull/1951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] jdailey commented on pull request #1951: Idempotency Support (FINERACT-1420)
Posted by GitBox <gi...@apache.org>.
jdailey commented on pull request #1951:
URL: https://github.com/apache/fineract/pull/1951#issuecomment-960300857
This looks like a good set of changes. What is failing on the Travis CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1951: Idempotency Support (FINERACT-1420)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1951:
URL: https://github.com/apache/fineract/pull/1951#issuecomment-960344756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1951: Idempotency Support (FINERACT-1420)
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1951:
URL: https://github.com/apache/fineract/pull/1951#issuecomment-961055212
You will have to rebase this ontop of fineract develop and squash the commits..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1951: Idempotency Support (FINERACT-1420)
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1951:
URL: https://github.com/apache/fineract/pull/1951#issuecomment-960333145
Hello James,
It is queued, not running in TravisCI, waiting for the excution
https://app.travis-ci.com/github/apache/fineract/builds/241137906
El mié, 3 nov 2021 a las 17:50, James D ***@***.***>)
escribió:
> This looks like a good set of changes. What is failing on the Travis CI?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1951#issuecomment-960300857>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZAWSUIN7IRFCI2VO5SDUKHKDXANCNFSM5HJY6I2Q>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1951: Idempotency Support (FINERACT-1420)
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1951:
URL: https://github.com/apache/fineract/pull/1951#issuecomment-961054105
The commit history looks weird.. Seems you started implementing this change on a branch with was not upto date with Fineract upstream develop branch...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1951: Idempotency Support (FINERACT-1420)
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1951:
URL: https://github.com/apache/fineract/pull/1951#issuecomment-961058627
I have seen something similar to this PR.. here: https://github.com/apache/fineract/pull/515
https://issues.apache.org/jira/browse/FINERACT-698, is there something we can learn from that ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] jdailey commented on pull request #1951: Idempotency Support (FINERACT-1420)
Posted by GitBox <gi...@apache.org>.
jdailey commented on pull request #1951:
URL: https://github.com/apache/fineract/pull/1951#issuecomment-960300857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] jdailey commented on pull request #1951: Idempotency Support (FINERACT-1420)
Posted by GitBox <gi...@apache.org>.
jdailey commented on pull request #1951:
URL: https://github.com/apache/fineract/pull/1951#issuecomment-960300857
This looks like a good set of changes. What is failing on the Travis CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1951: Idempotency Support (FINERACT-1420)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1951:
URL: https://github.com/apache/fineract/pull/1951#issuecomment-1000590127
Rebased in #2000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org