You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "yuzhiyang1 (via GitHub)" <gi...@apache.org> on 2026/08/27 11:00:23 UTC
[PR] test(desktop): cover safe renderer sends [maka]
yuzhiyang1 opened a new pull request, #4015:
URL: https://github.com/apache/maka/pull/4015
## Summary
Extract the existing main-window safe-send guard into a small behavior-testable helper without changing its call surface. The tests verify delivery to a live target and no-op behavior for destroyed BrowserWindow and webContents instances.
Update the Desktop README to describe the real behavior coverage instead of a nonexistent fixed-list source scanner.
Fixes #4003
## Verification
- Mutation check: temporarily removed the webContents destruction guard; the destroyed-target test failed, then passed after restoration.
- safe-renderer-send.test.js: 3 passed.
- Affected Desktop tests: 15 passed.
- npm run lint
- npm run format:check
- npm run build
- npm run typecheck
- npx knip --workspace apps/desktop
- npx knip --workspace packages/ui
- npm run check:asf-headers
- Full Desktop lane was also attempted on Windows: 1556 passed, 10 failed, and 8 were cancelled. The failures were in existing Windows symlink, native fixture, and Computer Use executable cases; none involved the changed files. Electron window/E2E tests were not run because the local dependency install intentionally skipped the Electron binary download.
## AI use
Select exactly one:
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: OpenAI Codex assisted with repository analysis, refactoring, tests, verification, documentation, and PR drafting. The human contributor reviewed the change and remains responsible for it.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [ ] Yes — described under Summary above
- [x] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] docs(desktop): correct safe-send documentation [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #4015:
URL: https://github.com/apache/maka/pull/4015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] docs(desktop): correct safe-send documentation [maka]
Posted by "yuzhiyang1 (via GitHub)" <gi...@apache.org>.
yuzhiyang1 commented on PR #4015:
URL: https://github.com/apache/maka/pull/4015#issuecomment-5473890538
Addressed in commit 2990c0f22. The net PR diff is now README-only: the in-place `safeSendToRenderer` implementation is restored, and the extracted helper plus behavior tests are removed. The README no longer claims a fixed-list scanner or behavior-test coverage; it documents the existing guard and routing convention. The title and PR description now reflect the documentation-only scope. A behavior seam is deferred until there is a current reproduction to protect.
Format, lint, build, typecheck, both Knip checks, the ASF header audit, and `git diff --check` pass.
_Automated response from OpenAI Codex at @yuzhiyang1's direction._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org