[PATCH] scan_script_header_err fails to kill timeout on error

["Roy T. Fielding" <fi...@kiwi.ICS.UCI.EDU>]

This is a simple bug fix, probably unrelated to the CGI script problems.
 
.....Roy

Index: util_script.c
===================================================================
RCS file: /export/home/cvs/apache/src/util_script.c,v
retrieving revision 1.41
diff -c -r1.41 util_script.c
*** util_script.c	1997/01/20 04:28:17	1.41
--- util_script.c	1997/02/04 08:00:11
***************
*** 306,311 ****
--- 306,312 ----
      while(1) {
  
  	if (fgets(w, MAX_STRING_LEN-1, f) == NULL) {
+ 	    kill_timeout (r);
  	    log_reason ("Premature end of script headers", r->filename, r);
  	    return SERVER_ERROR;
          }

Re: [PATCH] scan_script_header_err fails to kill timeout on error

[Rob Hartill <ro...@imdb.com>]

On Tue, 4 Feb 1997, Roy T. Fielding wrote:

> This is a simple bug fix, probably unrelated to the CGI script problems.
>  

talking of which. It sounds a bit like the problem we had back in the
summer with CGI that forked a child to continue working and parent
returning fast response to the client. I forget what the cure to that one
was but I remember adding a "close" to the http_main's main loop. The close
was wrong but I think it gave enough of a clue for someone to find
the real cause. If someone wants to trawl the archives, it would have
been before Aug 1st.

There's been a lot of work recently in http_main.c 

Re: [PATCH] scan_script_header_err fails to kill timeout on error

[Dean Gaudet <dg...@arctic.org>]

Why is the kill_timeout() necessary here but not in other error
situations?  Like I notice mod_include does it, but default_handler
doesn't... 

Dean

On Tue, 4 Feb 1997, Roy T. Fielding wrote:

> This is a simple bug fix, probably unrelated to the CGI script problems.
>  
> .....Roy
> 
> Index: util_script.c
> ===================================================================
> RCS file: /export/home/cvs/apache/src/util_script.c,v
> retrieving revision 1.41
> diff -c -r1.41 util_script.c
> *** util_script.c	1997/01/20 04:28:17	1.41
> --- util_script.c	1997/02/04 08:00:11
> ***************
> *** 306,311 ****
> --- 306,312 ----
>       while(1) {
>   
>   	if (fgets(w, MAX_STRING_LEN-1, f) == NULL) {
> + 	    kill_timeout (r);
>   	    log_reason ("Premature end of script headers", r->filename, r);
>   	    return SERVER_ERROR;
>           }
> 

Re: [PATCH] scan_script_header_err fails to kill timeout on error

[Ed Korthof <ed...@organic.com>]

+1 -- looks correct to me.

     -- Ed Korthof        |  Web Server Engineer --
     -- ed@organic.com    |  Organic Online, Inc --
     -- (415) 278-5676    |  Fax: (415) 284-6891 --

On Tue, 4 Feb 1997, Roy T. Fielding wrote:

> This is a simple bug fix, probably unrelated to the CGI script problems.
>  
> .....Roy
> 
[snip]