You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "leaves12138 (via GitHub)" <gi...@apache.org> on 2026/02/05 08:11:59 UTC
[PR] [flink] [spark] Write blob with adaptive match blob-descriptor [paimon]
leaves12138 opened a new pull request, #7216:
URL: https://github.com/apache/paimon/pull/7216
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #xxx
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] [spark] Write blob with adaptive match blob-descriptor [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #7216:
URL: https://github.com/apache/paimon/pull/7216#discussion_r2788607230
##########
paimon-common/src/main/java/org/apache/paimon/data/BlobDescriptor.java:
##########
@@ -113,10 +114,11 @@ public byte[] serialize() {
byte[] uriBytes = uri.getBytes(UTF_8);
int uriLength = uriBytes.length;
- int totalSize = 1 + 4 + uriLength + 8 + 8;
+ int totalSize = 8 + 1 + 4 + uriLength + 8 + 8;
ByteBuffer buffer = ByteBuffer.allocate(totalSize);
buffer.order(ByteOrder.LITTLE_ENDIAN);
+ buffer.putLong(MAGIC);
Review Comment:
I think in order to be compatible with older versions, we should design Magic Numbers after the version number, and Linux kernel images are designed in this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Introduce blob v2 [paimon]
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #7216:
URL: https://github.com/apache/paimon/pull/7216#issuecomment-3901351099
> Due to compatibility issues with this PR, I suggest that we modify all relevant content in this PR, including:
>
> 1. Blob-descriptor V2 and write blob with adaptive match blob-descriptor.
> 2. Support blob-store-descriptor.
> 3. Modify PyPaimon to support *1 and *2
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] [spark] Write blob with adaptive match blob-descriptor [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #7216:
URL: https://github.com/apache/paimon/pull/7216#issuecomment-3888473081
Due to compatibility issues with this PR, I suggest that we modify all relevant content in this PR, including:
1. Blob-descriptor V2 and write blob with adaptive match blob-descriptor.
2. Support blob-store-descriptor.
3. Modify PyPaimon to support *1 and *2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] [spark] Write blob with adaptive match blob-descriptor [paimon]
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on code in PR #7216:
URL: https://github.com/apache/paimon/pull/7216#discussion_r2791530534
##########
paimon-common/src/main/java/org/apache/paimon/data/BlobDescriptor.java:
##########
@@ -113,10 +114,11 @@ public byte[] serialize() {
byte[] uriBytes = uri.getBytes(UTF_8);
int uriLength = uriBytes.length;
- int totalSize = 1 + 4 + uriLength + 8 + 8;
+ int totalSize = 8 + 1 + 4 + uriLength + 8 + 8;
ByteBuffer buffer = ByteBuffer.allocate(totalSize);
buffer.order(ByteOrder.LITTLE_ENDIAN);
+ buffer.putLong(MAGIC);
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org