You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/04/11 18:30:28 UTC
Review Request 46005: Updated agent work_dir references to Option
type.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46005/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064
Repository: mesos
Description
-------
Updated references to `flags.work_dir` in the agent code to use `.get()` now that the work directory is an `Option`. We enforce that `flags.work_dir.isSome()` in the agent initialization code and in 'src/slave/main.cpp', so we don't have to perform this check elsewhere in the agent code.
Diffs
-----
src/slave/containerizer/containerizer.cpp d0cae79834e451594d7675f00c5f7d2d2cd3a264
src/slave/containerizer/docker.cpp 9c24227171c88ee89b567ebc5200a9563dfff5be
src/slave/containerizer/external_containerizer.cpp cf4384cce44172a028c890f52f71ceb8ae109383
src/slave/containerizer/mesos/containerizer.cpp c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 01c0ad6dbb6d509e62e769365586b3d23dcb240d
src/slave/containerizer/mesos/provisioner/provisioner.cpp 8a4938ebe4e00779e88e7c538445e9ffd51202e2
src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059
src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3
src/slave/status_update_manager.cpp d616fd4e4f140666bb691752cc93f0bc6fcd6e6e
src/tests/container_logger_tests.cpp efadceafca5721bce4dbffadb35f54fd5365abb0
src/tests/containerizer/docker_containerizer_tests.cpp 7accd32fba5eed196a82b1a171cb16d37b9e0539
src/tests/containerizer/external_containerizer_test.cpp 226eac56725e908040abda306a2e5e3c96bce9d7
src/tests/containerizer/filesystem_isolator_tests.cpp 51e60c2e8c6c8b76b51de0e7761ecbb0ca9c3304
src/tests/containerizer/isolator_tests.cpp 7b4d47bd9e99b71269093d7c11559f3b74a3e22b
src/tests/containerizer/port_mapping_tests.cpp 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf
src/tests/containerizer/provisioner_appc_tests.cpp 84fe52b6937c3b7d7628b17a2f045eec2f386b4d
src/tests/fetcher_cache_tests.cpp 9ffcd2375f1203bd3d7c5d0cc898e955d5cb124e
src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5
src/tests/master_contender_detector_tests.cpp 1426a173b1f458d67b748016aee311ac008b054a
src/tests/persistent_volume_tests.cpp d246f35046fff469b847c908de2b305ae629212f
src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391
src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
src/tests/status_update_manager_tests.cpp f5313a124c59eba3da86a173817d0c2a6a943e17
Diff: https://reviews.apache.org/r/46005/diff/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 46005: Updated references to agent work_dir to
Option type.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46005/
-----------------------------------------------------------
(Updated April 12, 2016, 5:50 p.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Updated references to agent work_dir to Option type.
Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064
Repository: mesos
Description
-------
Updated references to `flags.work_dir` in the agent code to use `.get()`
now that the work directory is an `Option`. We enforce that
`flags.work_dir.isSome()` in the agent initialization code and in
'src/slave/main.cpp', so we don't have to perform this check elsewhere
in the agent code.
Diffs (updated)
-----
src/slave/containerizer/containerizer.cpp d0cae79834e451594d7675f00c5f7d2d2cd3a264
src/slave/containerizer/docker.cpp 9c24227171c88ee89b567ebc5200a9563dfff5be
src/slave/containerizer/external_containerizer.cpp cf4384cce44172a028c890f52f71ceb8ae109383
src/slave/containerizer/mesos/containerizer.cpp c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 01c0ad6dbb6d509e62e769365586b3d23dcb240d
src/slave/containerizer/mesos/provisioner/provisioner.cpp 8a4938ebe4e00779e88e7c538445e9ffd51202e2
src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059
src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3
src/slave/status_update_manager.cpp d616fd4e4f140666bb691752cc93f0bc6fcd6e6e
src/tests/container_logger_tests.cpp efadceafca5721bce4dbffadb35f54fd5365abb0
src/tests/containerizer/docker_containerizer_tests.cpp 7accd32fba5eed196a82b1a171cb16d37b9e0539
src/tests/containerizer/external_containerizer_test.cpp 226eac56725e908040abda306a2e5e3c96bce9d7
src/tests/containerizer/filesystem_isolator_tests.cpp 51e60c2e8c6c8b76b51de0e7761ecbb0ca9c3304
src/tests/containerizer/isolator_tests.cpp 7b4d47bd9e99b71269093d7c11559f3b74a3e22b
src/tests/containerizer/port_mapping_tests.cpp 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf
src/tests/containerizer/provisioner_appc_tests.cpp 84fe52b6937c3b7d7628b17a2f045eec2f386b4d
src/tests/fetcher_cache_tests.cpp 9ffcd2375f1203bd3d7c5d0cc898e955d5cb124e
src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5
src/tests/master_contender_detector_tests.cpp 1426a173b1f458d67b748016aee311ac008b054a
src/tests/persistent_volume_tests.cpp d246f35046fff469b847c908de2b305ae629212f
src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391
src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
src/tests/status_update_manager_tests.cpp f5313a124c59eba3da86a173817d0c2a6a943e17
Diff: https://reviews.apache.org/r/46005/diff/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 46005: Updated agent work_dir references to Option
type.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46005/
-----------------------------------------------------------
(Updated April 11, 2016, 9:08 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064
Repository: mesos
Description (updated)
-------
Updated references to `flags.work_dir` in the agent code to use `.get()`
now that the work directory is an `Option`. We enforce that
`flags.work_dir.isSome()` in the agent initialization code and in
'src/slave/main.cpp', so we don't have to perform this check elsewhere
in the agent code.
Diffs
-----
src/slave/containerizer/containerizer.cpp d0cae79834e451594d7675f00c5f7d2d2cd3a264
src/slave/containerizer/docker.cpp 9c24227171c88ee89b567ebc5200a9563dfff5be
src/slave/containerizer/external_containerizer.cpp cf4384cce44172a028c890f52f71ceb8ae109383
src/slave/containerizer/mesos/containerizer.cpp c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 01c0ad6dbb6d509e62e769365586b3d23dcb240d
src/slave/containerizer/mesos/provisioner/provisioner.cpp 8a4938ebe4e00779e88e7c538445e9ffd51202e2
src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059
src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3
src/slave/status_update_manager.cpp d616fd4e4f140666bb691752cc93f0bc6fcd6e6e
src/tests/container_logger_tests.cpp efadceafca5721bce4dbffadb35f54fd5365abb0
src/tests/containerizer/docker_containerizer_tests.cpp 7accd32fba5eed196a82b1a171cb16d37b9e0539
src/tests/containerizer/external_containerizer_test.cpp 226eac56725e908040abda306a2e5e3c96bce9d7
src/tests/containerizer/filesystem_isolator_tests.cpp 51e60c2e8c6c8b76b51de0e7761ecbb0ca9c3304
src/tests/containerizer/isolator_tests.cpp 7b4d47bd9e99b71269093d7c11559f3b74a3e22b
src/tests/containerizer/port_mapping_tests.cpp 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf
src/tests/containerizer/provisioner_appc_tests.cpp 84fe52b6937c3b7d7628b17a2f045eec2f386b4d
src/tests/fetcher_cache_tests.cpp 9ffcd2375f1203bd3d7c5d0cc898e955d5cb124e
src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5
src/tests/master_contender_detector_tests.cpp 1426a173b1f458d67b748016aee311ac008b054a
src/tests/persistent_volume_tests.cpp d246f35046fff469b847c908de2b305ae629212f
src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391
src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
src/tests/status_update_manager_tests.cpp f5313a124c59eba3da86a173817d0c2a6a943e17
Diff: https://reviews.apache.org/r/46005/diff/
Testing
-------
`sudo make check`
Thanks,
Greg Mann