You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/16 21:37:21 UTC

[GitHub] [calcite] xndai commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

xndai commented on a change in pull request #2027:
URL: https://github.com/apache/calcite/pull/2027#discussion_r441156674



##########
File path: core/src/main/java/org/apache/calcite/plan/ConventionTraitDef.java
##########
@@ -234,10 +234,10 @@ private ConversionData getConversionData(RelOptPlanner planner) {
       return pathMap;
     }
 
-    public List<Convention> getShortestPath(
+    public int getShortestDistance(

Review comment:
       Can you also fix the getPaths() to return shortest paths first? This is to make sure we choose the shortest path during convert.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org