You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/06/18 15:53:27 UTC
Review Request 67633: Removed PICOJSON_USE_INT64 from libprocess build
system.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67633/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
It is no longer necessary, since the macro is now set
directly within <stout/json.hpp>.
Diffs
-----
3rdparty/libprocess/Makefile.am 8910416ce4313a0d70721cf1bb1d1453aaf691f9
Diff: https://reviews.apache.org/r/67633/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 67633: Removed PICOJSON_USE_INT64 from libprocess
build system.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67633/#review205304
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On June 18, 2018, 8:53 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67633/
> -----------------------------------------------------------
>
> (Updated June 18, 2018, 8:53 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It is no longer necessary, since the macro is now set
> directly within <stout/json.hpp>.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 8910416ce4313a0d70721cf1bb1d1453aaf691f9
>
>
> Diff: https://reviews.apache.org/r/67633/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67633: Removed PICOJSON_USE_INT64 from libprocess
build system.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67633/#review204990
-----------------------------------------------------------
Fix it, then Ship it!
Thanks for the cleanup, Benno!
Could you update the _Testing done_ section documenting that this patch can only be tested after one has also applied https://reviews.apache.org/r/67632/ and https://reviews.apache.org/r/67634/?
3rdparty/libprocess/Makefile.am
Lines 160-162 (original), 160-161 (patched)
<https://reviews.apache.org/r/67633/#comment287843>
We can put this on a single line now.
- Benjamin Bannier
On June 18, 2018, 5:53 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67633/
> -----------------------------------------------------------
>
> (Updated June 18, 2018, 5:53 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It is no longer necessary, since the macro is now defined
> directly within <stout/json.hpp>.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 8910416ce4313a0d70721cf1bb1d1453aaf691f9
>
>
> Diff: https://reviews.apache.org/r/67633/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>