You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2024/12/06 12:30:36 UTC
(maven-plugin-testing) branch todo created (now fb1781c)
This is an automated email from the ASF dual-hosted git repository.
elharo pushed a change to branch todo
in repository https://gitbox.apache.org/repos/asf/maven-plugin-testing.git
at fb1781c Remove TODOs
This branch includes the following new commits:
new fb1781c Remove TODOs
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(maven-plugin-testing) 01/01: Remove TODOs
Posted by el...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch todo
in repository https://gitbox.apache.org/repos/asf/maven-plugin-testing.git
commit fb1781c6a3b453f482f30e40a007c4c809358e5c
Author: Elliotte Rusty Harold <el...@ibiblio.org>
AuthorDate: Fri Dec 6 07:30:24 2024 -0500
Remove TODOs
---
.../org/apache/maven/plugin/testing/AbstractMojoTestCase.java | 9 ---------
.../src/main/java/org/apache/maven/plugin/testing/SilentLog.java | 2 --
.../org/apache/maven/plugin/testing/resources/TestResources.java | 1 -
.../org/apache/maven/plugin/testing/PluginArtifactFileTest.java | 3 +--
4 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java
index 8c11a8f..b0d8d48 100644
--- a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java
+++ b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java
@@ -79,15 +79,6 @@ import org.codehaus.plexus.util.xml.Xpp3Dom;
import org.codehaus.plexus.util.xml.Xpp3DomBuilder;
/**
- * TODO: add a way to use the plugin POM for the lookup so that the user doesn't have to provide the a:g:v:goal
- * as the role hint for the mojo lookup.
- * TODO: standardize the execution of the mojo and looking at the results, but could simply have a template method
- * for verifying the state of the mojo post execution
- * TODO: need a way to look at the state of the mojo without adding getters, this could be where we finally specify
- * the expressions which extract values from the mojo.
- * TODO: create a standard directory structure for picking up POMs to make this even easier, we really just need a testing
- * descriptor and make this entirely declarative!
- *
* @author jesse
*/
public abstract class AbstractMojoTestCase extends PlexusTestCase {
diff --git a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/SilentLog.java b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/SilentLog.java
index e94d81b..566f6cc 100644
--- a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/SilentLog.java
+++ b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/SilentLog.java
@@ -324,7 +324,5 @@ public class SilentLog implements Log, Logger {
@Override
public void setThreshold(int threshold) {
- // TODO Auto-generated method stub
-
}
}
diff --git a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/resources/TestResources.java b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/resources/TestResources.java
index 54343f1..1541506 100644
--- a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/resources/TestResources.java
+++ b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/resources/TestResources.java
@@ -86,7 +86,6 @@ public class TestResources extends TestWatcher {
// static helpers
public static void cp(File basedir, String from, String to) throws IOException {
- // TODO ensure destination lastModified timestamp changes
FileUtils.copyFile(new File(basedir, from), new File(basedir, to));
}
diff --git a/maven-plugin-testing-harness/src/test/java/org/apache/maven/plugin/testing/PluginArtifactFileTest.java b/maven-plugin-testing-harness/src/test/java/org/apache/maven/plugin/testing/PluginArtifactFileTest.java
index 6025f21..1414c3a 100644
--- a/maven-plugin-testing-harness/src/test/java/org/apache/maven/plugin/testing/PluginArtifactFileTest.java
+++ b/maven-plugin-testing-harness/src/test/java/org/apache/maven/plugin/testing/PluginArtifactFileTest.java
@@ -27,7 +27,7 @@ public class PluginArtifactFileTest extends AbstractMojoTestCase {
private static final String FS = System.getProperty("file.separator");
public void testArtifact() throws Exception {
- MojoExecution execution = newMojoExecution("parameters"); // TODO dedicated test mojo
+ MojoExecution execution = newMojoExecution("parameters");
List<Artifact> artifacts =
execution.getMojoDescriptor().getPluginDescriptor().getArtifacts();
@@ -41,5 +41,4 @@ public class PluginArtifactFileTest extends AbstractMojoTestCase {
assertTrue(artifact.getFile().getAbsolutePath().endsWith(FS + "target" + FS + "test-classes"));
}
- // TODO find a way to automate testing of jar:file:/ test plugin URLs
}