You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/05/20 12:34:31 UTC
[GitHub] [druid] cryptoe opened a new pull request, #12552: object[] handling for DimensionHandlers for arrays
cryptoe opened a new pull request, #12552:
URL: https://github.com/apache/druid/pull/12552
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
<!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
### Description
Fixes a bug when running q's like
```sql
SELECT cntarray,
Count(*)
FROM (SELECT dim1,
dim2,
Array_agg(cnt) AS cntarray
FROM (SELECT dim1,
dim2,
dim3,
Count(*) AS cnt
FROM foo
GROUP BY 1,
2,
3)
GROUP BY 1,
2)
GROUP BY 1
```
This generates an error:
```
org.apache.druid.java.util.common.ISE: Unable to convert type [Ljava.lang.Object; to org.apache.druid.segment.data.ComparableList
at org.apache.druid.segment.DimensionHandlerUtils.convertToList(DimensionHandlerUtils.java:405) ~[druid-xx]
```
Because it's an array of numbers it looks like it does the `convertToList` call, which looks like:
``` java
@Nullable
public static ComparableList convertToList(Object obj)
{
if (obj == null) {
return null;
}
if (obj instanceof List) {
return new ComparableList((List) obj);
}
if (obj instanceof ComparableList) {
return (ComparableList) obj;
}
throw new ISE("Unable to convert type %s to %s", obj.getClass().getName(), ComparableList.class.getName());
}
```
I.e. it doesn't know about arrays. Added the array handling as part of this PR.
Also, there is another code path that knows about arrays. but that has a typo.
```java
Objects[] objects = (Objects[]) obj;
String[] delegate = new String[objects.length];
for (int i = 0; i < objects.length; i++) {
delegate[i] = convertObjectToString(objects[i]);
}
return ComparableStringArray.of(delegate);
```
it should be `object[]` and not `objects[]`.
Added test cases to handle this case along with the change.
Thanks, @imply-cheddar for finding this bug.
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
<!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
<!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
##### Key changed/added classes in this PR
* `processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java`
* `sql/src/test/java/org/apache/druid/sql/calcite/CalciteArraysQueryTest.java`
* `TheirBaz`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] imply-cheddar commented on a diff in pull request #12552: object[] handling for DimensionHandlers for arrays
Posted by GitBox <gi...@apache.org>.
imply-cheddar commented on code in PR #12552:
URL: https://github.com/apache/druid/pull/12552#discussion_r878939325
##########
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java:
##########
@@ -402,7 +424,14 @@ public static ComparableList convertToList(Object obj)
if (obj instanceof ComparableList) {
return (ComparableList) obj;
}
- throw new ISE("Unable to convert type %s to %s", obj.getClass().getName(), ComparableList.class.getName());
+ if (obj instanceof Object[]) {
+ List<T> delegateList = new ArrayList<T>();
+ for (Object eachObj : (Object[]) obj) {
+ delegateList.add(convertFunction.apply(eachObj));
Review Comment:
This code is not symmetrical with the `List<>` case above. Is there a specific reason why objects need conversion when they are an array and not when they are a `List<>`? It seems like they should generally be the same code path, so if `return new ComparableList((List) obj);` is correct for List, why can it not also be correct for the Object[] case? Or, vice-versa, if the converted form is correct, then I think the `List<>` case above needs update.
Do we know which code path tickles the `List<>` case above? Is there a test that covers it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a diff in pull request #12552: object[] handling for DimensionHandlers for arrays
Posted by GitBox <gi...@apache.org>.
clintropolis commented on code in PR #12552:
URL: https://github.com/apache/druid/pull/12552#discussion_r880168358
##########
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java:
##########
@@ -402,7 +424,14 @@ public static ComparableList convertToList(Object obj)
if (obj instanceof ComparableList) {
return (ComparableList) obj;
}
- throw new ISE("Unable to convert type %s to %s", obj.getClass().getName(), ComparableList.class.getName());
+ if (obj instanceof Object[]) {
+ List<T> delegateList = new ArrayList<T>();
+ for (Object eachObj : (Object[]) obj) {
+ delegateList.add(convertFunction.apply(eachObj));
Review Comment:
to be consistent with the behavior of other calls to `DimensionHandlerUtils.convertObjectToX`, which is used by the grouper to ensure everything is expected and consistent type (both to handle schema differences between segments and also handle jackson changing types like doubles to floats, longs to ints, etc), these methods should be coercing the elements I think, so the List case is probably wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #12552: object[] handling for DimensionHandlers for arrays
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 merged PR #12552:
URL: https://github.com/apache/druid/pull/12552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a diff in pull request #12552: object[] handling for DimensionHandlers for arrays
Posted by GitBox <gi...@apache.org>.
clintropolis commented on code in PR #12552:
URL: https://github.com/apache/druid/pull/12552#discussion_r881209668
##########
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java:
##########
@@ -381,8 +386,12 @@ public static Comparable<?> convertObjectToType(
switch (type.getElementType().getType()) {
case STRING:
return convertToComparableStringArray(obj);
- default:
- return convertToList(obj);
+ case LONG:
+ return convertToListWithObjectFunction(obj, CONVERT_OBJECT_TO_LONG_FUNCTION);
Review Comment:
nit: any reason not to use `DimensionHandlerUtils::convertObjectToLong` instead of static fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe commented on a diff in pull request #12552: object[] handling for DimensionHandlers for arrays
Posted by GitBox <gi...@apache.org>.
cryptoe commented on code in PR #12552:
URL: https://github.com/apache/druid/pull/12552#discussion_r881240528
##########
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java:
##########
@@ -381,8 +386,12 @@ public static Comparable<?> convertObjectToType(
switch (type.getElementType().getType()) {
case STRING:
return convertToComparableStringArray(obj);
- default:
- return convertToList(obj);
+ case LONG:
+ return convertToListWithObjectFunction(obj, CONVERT_OBJECT_TO_LONG_FUNCTION);
Review Comment:
`DimensionHandlerUtils::convertObjectToLong` seems better thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe commented on a diff in pull request #12552: object[] handling for DimensionHandlers for arrays
Posted by GitBox <gi...@apache.org>.
cryptoe commented on code in PR #12552:
URL: https://github.com/apache/druid/pull/12552#discussion_r881240528
##########
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java:
##########
@@ -381,8 +386,12 @@ public static Comparable<?> convertObjectToType(
switch (type.getElementType().getType()) {
case STRING:
return convertToComparableStringArray(obj);
- default:
- return convertToList(obj);
+ case LONG:
+ return convertToListWithObjectFunction(obj, CONVERT_OBJECT_TO_LONG_FUNCTION);
Review Comment:
This seems better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe commented on a diff in pull request #12552: object[] handling for DimensionHandlers for arrays
Posted by GitBox <gi...@apache.org>.
cryptoe commented on code in PR #12552:
URL: https://github.com/apache/druid/pull/12552#discussion_r880373627
##########
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java:
##########
@@ -402,7 +424,14 @@ public static ComparableList convertToList(Object obj)
if (obj instanceof ComparableList) {
return (ComparableList) obj;
}
- throw new ISE("Unable to convert type %s to %s", obj.getClass().getName(), ComparableList.class.getName());
+ if (obj instanceof Object[]) {
+ List<T> delegateList = new ArrayList<T>();
+ for (Object eachObj : (Object[]) obj) {
+ delegateList.add(convertFunction.apply(eachObj));
Review Comment:
Acked!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe commented on a diff in pull request #12552: object[] handling for DimensionHandlers for arrays
Posted by GitBox <gi...@apache.org>.
cryptoe commented on code in PR #12552:
URL: https://github.com/apache/druid/pull/12552#discussion_r879419823
##########
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java:
##########
@@ -402,7 +424,14 @@ public static ComparableList convertToList(Object obj)
if (obj instanceof ComparableList) {
return (ComparableList) obj;
}
- throw new ISE("Unable to convert type %s to %s", obj.getClass().getName(), ComparableList.class.getName());
+ if (obj instanceof Object[]) {
+ List<T> delegateList = new ArrayList<T>();
+ for (Object eachObj : (Object[]) obj) {
+ delegateList.add(convertFunction.apply(eachObj));
Review Comment:
Yes, there is a test case for it.
`GroupByQueryTestRunner#testGroupByWithLongArrays()`
on further inspection, its returning doubles in the output. That looks incorrect to me.
Which means we might have to transform the list as well. Similar argument can be made for the String Array stuff as well.
WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe commented on a diff in pull request #12552: object[] handling for DimensionHandlers for arrays
Posted by GitBox <gi...@apache.org>.
cryptoe commented on code in PR #12552:
URL: https://github.com/apache/druid/pull/12552#discussion_r881623522
##########
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java:
##########
@@ -381,8 +386,12 @@ public static Comparable<?> convertObjectToType(
switch (type.getElementType().getType()) {
case STRING:
return convertToComparableStringArray(obj);
- default:
- return convertToList(obj);
+ case LONG:
+ return convertToListWithObjectFunction(obj, CONVERT_OBJECT_TO_LONG_FUNCTION);
Review Comment:
Suggested changes look less verbose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org