[GitHub] [dubbo] vio-lin commented on a change in pull request #8943: optimise compile error message in jdk compiler.(#8942)

[GitBox <gi...@apache.org>]

vio-lin commented on a change in pull request #8943:
URL: https://github.com/apache/dubbo/pull/8943#discussion_r718104863



##########
File path: dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JdkCompilerTest.java
##########
@@ -84,4 +88,17 @@ public void test_compileJavaClass1_java8() throws Exception {
             Assertions.assertEquals("Hello world!", sayHello.invoke(instance));
         });
     }
+
+    @Test
+    public void test_getCompileErrorMessage() {

Review comment:
       DONE
   

##########
File path: dubbo-common/src/test/java/org/apache/dubbo/common/compiler/support/JavaCodeTest.java
##########
@@ -98,4 +98,17 @@ String getSimpleCodeWithWithExtends() {
         code.append("}");
         return code.toString();
     }
+
+    String getSimpleCodeWithError() {
+        StringBuilder code = new StringBuilder();
+        code.append("package org.apache.dubbo.common.compiler.support;");
+
+        code.append("public class HelloServiceImpl" + SUBFIX.getAndIncrement() + " implements HelloService {");

Review comment:
       DONE




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org