[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9909: graphics: in smp sched_lock is not enough to prevent preemption

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #9909:
URL: https://github.com/apache/nuttx/pull/9909#discussion_r1275146648


##########
graphics/nxterm/nxterm_kbdin.c:
##########
@@ -128,6 +129,7 @@ ssize_t nxterm_read(FAR struct file *filep, FAR char *buffer, size_t len)
            * to wake us up.
            */
 
+          flags = enter_critical_section();

Review Comment:
   but already protected by priv->lock



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org