[GitHub] [netbeans] mbien commented on a diff in pull request #5897: [NETBEANS-5719] Add option to disable tooltips for parameter completion.

["mbien (via GitHub)" <gi...@apache.org>]

mbien commented on code in PR #5897:
URL: https://github.com/apache/netbeans/pull/5897#discussion_r1180888367


##########
ide/editor.completion/src/org/netbeans/modules/editor/completion/CompletionImpl.java:
##########
@@ -1414,16 +1414,18 @@ boolean hideDocumentationPane(boolean documentationOnly) {
      * May be called from any thread but it will be rescheduled into AWT.
      */
     public void showToolTip() {
-        if (!SwingUtilities.isEventDispatchThread()) {
-            // Re-call this method in AWT if necessary
-            SwingUtilities.invokeLater(new ParamRunnable(ParamRunnable.SHOW_TOOL_TIP));
-            return;
-        }
-
-        if (ensureActiveProviders()) {
-            toolTipCancel();
-            toolTipQuery();
-        }
+		if (CompletionSettings.getInstance(getActiveComponent()).completionDisplayTooltip()) {

Review Comment:
   nitpick: you are using tabs here, please use spaces if possible (but read other message first).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists