You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/12/19 22:29:31 UTC

[GitHub] Mogball commented on issue #4091: Fix merge_extra_filters

Mogball commented on issue #4091: Fix merge_extra_filters
URL: https://github.com/apache/incubator-superset/pull/4091#issuecomment-352906247
 
 
   @nbonnotte I'm not sure what filters with `None` as `col` are for (or if that is the result of another issue). Is there something particular about your dataset?
   
   In any case I might change `return f['col'] + '__' + f['op']` to `return f['col'] if f['col'] else '__none' + '__' + f['op']` in case a filter with `None` as `col` shows up in both `filters` and `extra_filters`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services