You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streampipes.apache.org by ri...@apache.org on 2022/01/06 16:59:27 UTC

[incubator-streampipes] 02/03: [hotfix] Do not trigger field selection before component is rendered

This is an automated email from the ASF dual-hosted git repository.

riemer pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampipes.git

commit a9601039e9b5cf78ba8b5edffb65c35253edd70a
Author: Dominik Riemer <do...@gmail.com>
AuthorDate: Thu Jan 6 16:56:11 2022 +0100

    [hotfix] Do not trigger field selection before component is rendered
---
 .../data-explorer-widget-data-settings.component.ts            | 10 ++++++----
 .../config/time-series-chart-widget-config.component.ts        |  1 -
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/ui/src/app/data-explorer/components/designer-panel/data-settings/data-explorer-widget-data-settings.component.ts b/ui/src/app/data-explorer/components/designer-panel/data-settings/data-explorer-widget-data-settings.component.ts
index dfae898..b959045 100644
--- a/ui/src/app/data-explorer/components/designer-panel/data-settings/data-explorer-widget-data-settings.component.ts
+++ b/ui/src/app/data-explorer/components/designer-panel/data-settings/data-explorer-widget-data-settings.component.ts
@@ -16,7 +16,7 @@
  *
  */
 
-import {Component, ElementRef, EventEmitter, Input, OnInit, Output, ViewChild} from '@angular/core';
+import { Component, EventEmitter, Input, OnInit, Output, ViewChild } from '@angular/core';
 import { DataExplorerWidgetModel, DataLakeMeasure } from '../../../../core-model/gen/streampipes-model';
 import { DataViewDataExplorerService } from '../../../../platform-services/apis/data-view-data-explorer.service';
 import { MatSelectChange } from '@angular/material/select';
@@ -25,7 +25,7 @@ import { DatalakeRestService } from '../../../../platform-services/apis/datalake
 import { zip } from 'rxjs';
 import { DataExplorerDataConfig, SourceConfig } from '../../../models/dataview-dashboard.model';
 import { WidgetConfigurationService } from '../../../services/widget-configuration.service';
-import {FieldSelectionPanelComponent} from "./field-selection-panel/field-selection-panel.component";
+import { FieldSelectionPanelComponent } from './field-selection-panel/field-selection-panel.component';
 
 @Component({
   selector: 'sp-data-explorer-widget-data-settings',
@@ -44,7 +44,7 @@ export class DataExplorerWidgetDataSettingsComponent implements OnInit {
   @Output() dataLakeMeasureChange: EventEmitter<DataLakeMeasure> = new EventEmitter<DataLakeMeasure>();
   @Output() configureVisualizationEmitter: EventEmitter<void> = new EventEmitter<void>();
 
-  @ViewChild("fieldSelectionPanel")
+  @ViewChild('fieldSelectionPanel')
   fieldSelectionPanel: FieldSelectionPanelComponent;
 
   availablePipelines: DataLakeMeasure[];
@@ -84,7 +84,9 @@ export class DataExplorerWidgetDataSettingsComponent implements OnInit {
   updateMeasure(sourceConfig: SourceConfig, event: MatSelectChange) {
     sourceConfig.measure = this.findMeasure(event.value);
     sourceConfig.queryConfig.fields = [];
-    this.fieldSelectionPanel.applyDefaultFields();
+    if (this.fieldSelectionPanel) {
+      this.fieldSelectionPanel.applyDefaultFields();
+    }
 
   }
 
diff --git a/ui/src/app/data-explorer/components/widgets/time-series-chart/config/time-series-chart-widget-config.component.ts b/ui/src/app/data-explorer/components/widgets/time-series-chart/config/time-series-chart-widget-config.component.ts
index 9dfb812..fcb4834 100644
--- a/ui/src/app/data-explorer/components/widgets/time-series-chart/config/time-series-chart-widget-config.component.ts
+++ b/ui/src/app/data-explorer/components/widgets/time-series-chart/config/time-series-chart-widget-config.component.ts
@@ -46,7 +46,6 @@ export class TimeSeriesChartWidgetConfigComponent
 
   setSelectedProperties(selectedColumns: DataExplorerField[]) {
     this.currentlyConfiguredWidget.visualizationConfig.selectedTimeSeriesChartProperties = selectedColumns;
-    console.log(selectedColumns);
     // this.currentlyConfiguredWidget.dataConfig.yKeys = this.getRuntimeNames(selectedColumns);
     this.triggerDataRefresh();
   }