You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "sudo87 (via GitHub)" <gi...@apache.org> on 2025/06/10 09:27:31 UTC
[PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
sudo87 opened a new pull request, #10997:
URL: https://github.com/apache/cloudstack/pull/10997
### Description
This PR introduces new value: "COMBINED" for config: "host.capacityType.to.order.clusters"
COMBINED will work with "host.capacityType.to.order.clusters.cputomemoryweight" and overall capacity for cluster/pod/host will be computed based on CPU and memory using weight factor.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#discussion_r2149409089
##########
server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java:
##########
@@ -407,6 +405,54 @@ private List<? extends Host> reorderHostsByCapacity(DeploymentPlan plan, List<?
return reorderedHosts;
}
+ private Pair<List<Long>, Map<Long, Double>> getOrderedHostsByCapacity(Long zoneId, Long clusterId) {
+ double cpuToMemoryWeight = ConfigurationManager.HostCapacityTypeCpuMemoryWeight.value();
+ // Get capacity by which we should reorder
+ short capacityType = getCapacityType(cpuToMemoryWeight);
+ if (capacityType >= 0) { // for CPU or RAM
+ return _capacityDao.orderHostsByFreeCapacity(zoneId, clusterId, capacityType);
+ }
+ List<CapacityVO> capacities = _capacityDao.listHostCapacityByCapacityTypes(zoneId, clusterId,
+ List.of(Capacity.CAPACITY_TYPE_CPU, Capacity.CAPACITY_TYPE_MEMORY));
+ Map<Long, Double> hostByComputedCapacity = getHostByCombinedCapacities(capacities, cpuToMemoryWeight);
+ return new Pair<>(new ArrayList<>(hostByComputedCapacity.keySet()), hostByComputedCapacity);
+ }
+
+ short getCapacityType(double cpuToMemoryWeight) {
+ String capacityTypeToOrder = _configDao.getValue(Config.HostCapacityTypeToOrderClusters.key());
+ short capacityType = CapacityVO.CAPACITY_TYPE_CPU;
+ if (ApiConstants.RAM.equalsIgnoreCase(capacityTypeToOrder)){
+ capacityType = CapacityVO.CAPACITY_TYPE_MEMORY;
+ } else if (ApiConstants.COMBINED_CAPACITY_ORDERING.equalsIgnoreCase(capacityTypeToOrder)) {
+ capacityType = -1;
+ }
+
Review Comment:
the method should return if capacityType > 0 here
##########
server/src/main/java/com/cloud/deploy/FirstFitPlanner.java:
##########
@@ -517,6 +514,91 @@ protected Pair<List<Long>, Map<Long, Double>> listPodsByCapacity(long zoneId, in
}
+ private Pair<List<Long>, Map<Long, Double>> getOrderedPodsByCapacity(long zoneId) {
+ double cpuToMemoryWeight = ConfigurationManager.HostCapacityTypeCpuMemoryWeight.value();
+ short capacityType = getCapacityType(cpuToMemoryWeight);
+ if (capacityType >= 0) { // for capacityType other than COMBINED
+ return capacityDao.orderPodsByAggregateCapacity(zoneId, capacityType);
+ }
+ List<CapacityVO> capacities = capacityDao.listPodCapacityByCapacityTypes(zoneId, List.of(Capacity.CAPACITY_TYPE_CPU, Capacity.CAPACITY_TYPE_MEMORY));
+ Map<Long, Double> podsByCombinedCapacities = getPodByCombinedCapacities(capacities, cpuToMemoryWeight);
+ return new Pair<>(new ArrayList<>(podsByCombinedCapacities.keySet()), podsByCombinedCapacities);
+ }
+
+ // order pods by combining cpu and memory capacity considering cpuToMemoeryWeight
+ private Map<Long, Double> getPodByCombinedCapacities(List<CapacityVO> capacities, double cpuToMemoryWeight) {
+ Map<Long, Double> podByCombinedCapacity = new HashMap<>();
+ for (CapacityVO capacityVO : capacities) {
+ boolean isCPUCapacity = capacityVO.getCapacityType() == Capacity.CAPACITY_TYPE_CPU;
+ long podId = capacityVO.getPodId();
+ double applicableWeight = isCPUCapacity ? cpuToMemoryWeight : 1 - cpuToMemoryWeight;
+ String overCommitRatioParam = isCPUCapacity ? ApiConstants.CPU_OVERCOMMIT_RATIO : ApiConstants.MEMORY_OVERCOMMIT_RATIO;
+ ClusterDetailsVO overCommitRatioVO = clusterDetailsDao.findDetail(capacityVO.getClusterId(), overCommitRatioParam);
+ float overCommitRatio = Float.parseFloat(overCommitRatioVO.getValue());
+ double capacityMetric = applicableWeight *
+ (capacityVO.getUsedCapacity() + capacityVO.getReservedCapacity())/(capacityVO.getTotalCapacity() * overCommitRatio);
+ podByCombinedCapacity.merge(podId, capacityMetric, Double::sum);
+ }
+ return podByCombinedCapacity.entrySet()
+ .stream()
+ .sorted(Map.Entry.comparingByValue())
+ .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue, (e1, e2) -> e1, LinkedHashMap::new));
+ }
+
+
+ private Pair<List<Long>, Map<Long, Double>> getOrderedClustersByCapacity(long id, long vmId, boolean isZone) {
+ double cpuToMemoryWeight = ConfigurationManager.HostCapacityTypeCpuMemoryWeight.value();
+ short capacityType = getCapacityType(cpuToMemoryWeight);
+ if (capacityType >= 0) { // for capacityType other than COMBINED
+ return capacityDao.orderClustersByAggregateCapacity(id, vmId, capacityType, isZone);
+ }
+
+ Long zoneId = isZone ? id : null;
+ Long podId = isZone ? null : id;
+ List<CapacityVO> capacities = capacityDao.listClusterCapacityByCapacityTypes(zoneId, podId, vmId,
+ List.of(Capacity.CAPACITY_TYPE_CPU, Capacity.CAPACITY_TYPE_MEMORY));
+
+ Map<Long, Double> clusterByCombinedCapacities = getClusterByCombinedCapacities(capacities, cpuToMemoryWeight);
+ return new Pair<>(new ArrayList<>(clusterByCombinedCapacities.keySet()), clusterByCombinedCapacities);
+ }
+
+ private Map<Long, Double> getClusterByCombinedCapacities(List<CapacityVO> capacities, double cpuToMemoryWeight) {
+ Map<Long, Double> clusterByCombinedCapacity = new HashMap<>();
+ for (CapacityVO capacityVO : capacities) {
+ boolean isCPUCapacity = capacityVO.getCapacityType() == Capacity.CAPACITY_TYPE_CPU;
+ long clusterId = capacityVO.getClusterId();
+ double applicableWeight = isCPUCapacity ? cpuToMemoryWeight : 1 - cpuToMemoryWeight;
+ String overCommitRatioParam = isCPUCapacity ? ApiConstants.CPU_OVERCOMMIT_RATIO : ApiConstants.MEMORY_OVERCOMMIT_RATIO;
+ ClusterDetailsVO overCommitRatioVO = clusterDetailsDao.findDetail(clusterId, overCommitRatioParam);
+ float overCommitRatio = Float.parseFloat(overCommitRatioVO.getValue());
+ double capacityMetric = applicableWeight *
+ (capacityVO.getUsedCapacity() + capacityVO.getReservedCapacity())/(capacityVO.getTotalCapacity() * overCommitRatio);
+ clusterByCombinedCapacity.merge(clusterId, capacityMetric, Double::sum);
+ }
+ return clusterByCombinedCapacity.entrySet()
+ .stream()
+ .sorted(Map.Entry.comparingByValue())
+ .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue, (e1, e2) -> e1, LinkedHashMap::new));
+ }
+
+ short getCapacityType(double cpuToMemoryWeight) {
+ String capacityTypeToOrder = configDao.getValue(Config.HostCapacityTypeToOrderClusters.key());
+ short capacityType = CapacityVO.CAPACITY_TYPE_CPU;
+ if (ApiConstants.RAM.equalsIgnoreCase(capacityTypeToOrder)){
+ capacityType = CapacityVO.CAPACITY_TYPE_MEMORY;
+ } else if (ApiConstants.COMBINED_CAPACITY_ORDERING.equalsIgnoreCase(capacityTypeToOrder)) {
+ capacityType = -1;
+ }
+
Review Comment:
return capacityType if > 0 here
##########
engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java:
##########
@@ -1068,7 +1068,65 @@ public Pair<List<Long>, Map<Long, Double>> orderHostsByFreeCapacity(Long zoneId,
}
@Override
- public List<Long> listPodsByHostCapacities(long zoneId, int requiredCpu, long requiredRam, short capacityType) {
+ public List<CapacityVO> listHostCapacityByCapacityTypes(Long zoneId, Long clusterId, List<Short> capacityTypes) {
+ SearchBuilder<CapacityVO> sb = createSearchBuilder();
+ sb.and("zoneId", sb.entity().getDataCenterId(), SearchCriteria.Op.EQ);
+ sb.and("clusterId", sb.entity().getClusterId(), SearchCriteria.Op.EQ);
+ sb.and("capacityTypes", sb.entity().getCapacityType(), SearchCriteria.Op.IN);
+ sb.and("capacityState", sb.entity().getCapacityState(), Op.EQ);
+ sb.done();
+
+ SearchCriteria<CapacityVO> sc = sb.create();
+ sc.setParameters("capacityState", "Enabled");
+ if (zoneId != null) {
+ sc.setParameters("zoneId", zoneId);
+ }
+ if (clusterId != null) {
+ sc.setParameters("clusterId", clusterId);
+ }
+ sc.setParameters("capacityTypes", capacityTypes.toArray());
+ return listBy(sc);
+ }
+
+ @Override
+ public List<CapacityVO> listPodCapacityByCapacityTypes(Long zoneId, List<Short> capacityTypes) {
+ SearchBuilder<CapacityVO> sb = createSearchBuilder();
+ sb.and("zoneId", sb.entity().getDataCenterId(), SearchCriteria.Op.EQ);
+ sb.and("capacityTypes", sb.entity().getCapacityType(), SearchCriteria.Op.IN);
+ sb.and("capacityState", sb.entity().getCapacityState(), Op.EQ);
+ sb.done();
+ SearchCriteria<CapacityVO> sc = sb.create();
+ sc.setParameters("capacityState", "Enabled");
+ if (zoneId != null) {
+ sc.setParameters("zoneId", zoneId);
+ }
+ sc.setParameters("capacityTypes", capacityTypes.toArray());
+ return listBy(sc);
+ }
+
+ @Override
+ public List<CapacityVO> listClusterCapacityByCapacityTypes(Long zoneId, Long podId, long vmId, List<Short> capacityTypes) {
Review Comment:
is `vmId` used in this method ?
##########
server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java:
##########
@@ -407,6 +405,54 @@ private List<? extends Host> reorderHostsByCapacity(DeploymentPlan plan, List<?
return reorderedHosts;
}
+ private Pair<List<Long>, Map<Long, Double>> getOrderedHostsByCapacity(Long zoneId, Long clusterId) {
+ double cpuToMemoryWeight = ConfigurationManager.HostCapacityTypeCpuMemoryWeight.value();
+ // Get capacity by which we should reorder
+ short capacityType = getCapacityType(cpuToMemoryWeight);
+ if (capacityType >= 0) { // for CPU or RAM
+ return _capacityDao.orderHostsByFreeCapacity(zoneId, clusterId, capacityType);
+ }
+ List<CapacityVO> capacities = _capacityDao.listHostCapacityByCapacityTypes(zoneId, clusterId,
+ List.of(Capacity.CAPACITY_TYPE_CPU, Capacity.CAPACITY_TYPE_MEMORY));
+ Map<Long, Double> hostByComputedCapacity = getHostByCombinedCapacities(capacities, cpuToMemoryWeight);
+ return new Pair<>(new ArrayList<>(hostByComputedCapacity.keySet()), hostByComputedCapacity);
+ }
+
+ short getCapacityType(double cpuToMemoryWeight) {
+ String capacityTypeToOrder = _configDao.getValue(Config.HostCapacityTypeToOrderClusters.key());
+ short capacityType = CapacityVO.CAPACITY_TYPE_CPU;
+ if (ApiConstants.RAM.equalsIgnoreCase(capacityTypeToOrder)){
+ capacityType = CapacityVO.CAPACITY_TYPE_MEMORY;
+ } else if (ApiConstants.COMBINED_CAPACITY_ORDERING.equalsIgnoreCase(capacityTypeToOrder)) {
+ capacityType = -1;
+ }
+
+ if (cpuToMemoryWeight == 1) {
+ capacityType = CapacityVO.CAPACITY_TYPE_CPU;
+ }
+ if (cpuToMemoryWeight == 0) {
+ capacityType = CapacityVO.CAPACITY_TYPE_MEMORY;
+ }
+ return capacityType;
+ }
+
+
+ @NotNull
+ private static Map<Long, Double> getHostByCombinedCapacities(List<CapacityVO> capacities, double cpuToMemoryWeight) {
Review Comment:
can you write a unit test for this method ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3052330746
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2966721926
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3060596029
@rosi-shapeblue a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 commented on code in PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#discussion_r2204526040
##########
server/src/main/java/com/cloud/deploy/FirstFitPlanner.java:
##########
@@ -517,6 +514,104 @@ protected Pair<List<Long>, Map<Long, Double>> listPodsByCapacity(long zoneId, in
}
+ private Pair<List<Long>, Map<Long, Double>> getOrderedPodsByCapacity(long zoneId) {
+ double cpuToMemoryWeight = ConfigurationManager.HostCapacityTypeCpuMemoryWeight.value();
+ short capacityType = getHostCapacityTypeToOrderCluster(
+ configDao.getValue(Config.HostCapacityTypeToOrderClusters.key()), cpuToMemoryWeight);
+
+ logger.debug("CapacityType: {} is used for Pod ordering", getCapacityTypeName(capacityType));
+ if (capacityType >= 0) { // for capacityType other than COMBINED
+ return capacityDao.orderPodsByAggregateCapacity(zoneId, capacityType);
+ }
+ List<CapacityVO> capacities = capacityDao.listPodCapacityByCapacityTypes(zoneId, List.of(Capacity.CAPACITY_TYPE_CPU, Capacity.CAPACITY_TYPE_MEMORY));
+ Map<Long, Double> podsByCombinedCapacities = getPodByCombinedCapacities(capacities, cpuToMemoryWeight);
+ return new Pair<>(new ArrayList<>(podsByCombinedCapacities.keySet()), podsByCombinedCapacities);
+ }
+
+ // order pods by combining cpu and memory capacity considering cpuToMemoeryWeight
Review Comment:
Sure @DaanHoogland, will remove comment in next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3068080227
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3072615732
<b>[SF] Trillian test result (tid-13764)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 87838 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10997-t13764-kvm-ol8.zip
Smoke tests completed. 130 look OK, 11 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_nic_secondaryip_add_remove | `Error` | 1517.30 | test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
ContextSuite context=TestIpv6Network>:setup | `Error` | 0.00 | test_network_ipv6.py
test_delete_account | `Error` | 1516.61 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 1.23 | test_network.py
test_deploy_vm_l2network | `Error` | 1.19 | test_network.py
test_l2network_restart | `Error` | 2.31 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 3.53 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 11.38 | test_network.py
test_reboot_router | `Failure` | 0.09 | test_network.py
test_releaseIP | `Error` | 5.63 | test_network.py
test_releaseIP_using_IP | `Error` | 5.95 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 6.03 | test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup | `Error` | 1520.97 | test_network.py
ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
ContextSuite context=TestNonStrictAffinityGroups>:setup | `Error` | 0.00 | test_nonstrict_affinity_group.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
ContextSuite context=TestProjectSuspendActivate>:setup | `Error` | 1527.13 | test_projects.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2966020793
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#discussion_r2194879873
##########
server/src/main/java/com/cloud/deploy/FirstFitPlanner.java:
##########
@@ -517,6 +514,104 @@ protected Pair<List<Long>, Map<Long, Double>> listPodsByCapacity(long zoneId, in
}
+ private Pair<List<Long>, Map<Long, Double>> getOrderedPodsByCapacity(long zoneId) {
+ double cpuToMemoryWeight = ConfigurationManager.HostCapacityTypeCpuMemoryWeight.value();
+ short capacityType = getHostCapacityTypeToOrderCluster(
+ configDao.getValue(Config.HostCapacityTypeToOrderClusters.key()), cpuToMemoryWeight);
+
+ logger.debug("CapacityType: {} is used for Pod ordering", getCapacityTypeName(capacityType));
+ if (capacityType >= 0) { // for capacityType other than COMBINED
+ return capacityDao.orderPodsByAggregateCapacity(zoneId, capacityType);
+ }
+ List<CapacityVO> capacities = capacityDao.listPodCapacityByCapacityTypes(zoneId, List.of(Capacity.CAPACITY_TYPE_CPU, Capacity.CAPACITY_TYPE_MEMORY));
+ Map<Long, Double> podsByCombinedCapacities = getPodByCombinedCapacities(capacities, cpuToMemoryWeight);
+ return new Pair<>(new ArrayList<>(podsByCombinedCapacities.keySet()), podsByCombinedCapacities);
+ }
+
+ // order pods by combining cpu and memory capacity considering cpuToMemoeryWeight
Review Comment:
should this be javadoc? (it seems the method name already is self-documenting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3034898567
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3051987703
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2986614727
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2986787423
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2981119557
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2982743324
<b>[SF] Trillian test result (tid-13554)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 2456 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10997-t13554-kvm-ol8.zip
Smoke tests completed. 8 look OK, 133 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
runTest | `Error` | 0.00 | test_2fa.py
runTest | `Error` | 0.00 | test_account_access.py
runTest | `Error` | 0.00 | test_accounts.py
runTest | `Error` | 0.00 | test_affinity_groups_projects.py
runTest | `Error` | 0.00 | test_affinity_groups.py
runTest | `Error` | 0.00 | test_annotations.py
runTest | `Error` | 0.00 | test_async_job.py
runTest | `Error` | 0.00 | test_attach_multiple_volumes.py
runTest | `Error` | 0.00 | test_backup_recovery_dummy.py
runTest | `Error` | 0.00 | test_backup_recovery_veeam.py
runTest | `Error` | 0.00 | test_direct_download.py
runTest | `Error` | 0.00 | test_certauthority_root.py
runTest | `Error` | 0.00 | test_cluster_drs.py
runTest | `Error` | 0.00 | test_console_endpoint.py
runTest | `Error` | 0.00 | test_create_list_domain_account_project.py
runTest | `Error` | 0.00 | test_create_network.py
runTest | `Error` | 0.00 | test_deploy_vgpu_enabled_vm.py
runTest | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
runTest | `Error` | 0.00 | test_deploy_vm_extra_config_data.py
runTest | `Error` | 0.00 | test_deploy_vm_iso.py
runTest | `Error` | 0.00 | test_deploy_vm_iso_uefi.py
runTest | `Error` | 0.00 | test_deploy_vm_root_resize.py
runTest | `Error` | 0.00 | test_deploy_vms_in_parallel.py
runTest | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
runTest | `Error` | 0.00 | test_deploy_vm_with_userdata.py
runTest | `Error` | 0.00 | test_diagnostics.py
runTest | `Error` | 0.00 | test_disk_offerings.py
runTest | `Error` | 0.00 | test_disk_provisioning_types.py
runTest | `Error` | 0.00 | test_domain_disk_offerings.py
runTest | `Error` | 0.00 | test_domain_network_offerings.py
runTest | `Error` | 0.00 | test_domain_service_offerings.py
runTest | `Error` | 0.00 | test_guest_os.py
runTest | `Error` | 0.00 | test_domain_vpc_offerings.py
runTest | `Error` | 0.00 | test_enable_account_settings_for_domain.py
runTest | `Error` | 0.00 | test_metrics_api.py
runTest | `Error` | 0.00 | test_events_resource.py
runTest | `Error` | 0.00 | test_gateway_on_shared_networks.py
runTest | `Error` | 0.00 | test_global_acls.py
runTest | `Error` | 0.00 | test_global_settings.py
runTest | `Error` | 0.00 | test_guest_vlan_range.py
runTest | `Error` | 0.00 | test_host_control_state.py
runTest | `Error` | 0.00 | test_hostha_simulator.py
runTest | `Error` | 0.00 | test_host_ping.py
runTest | `Error` | 0.00 | test_image_store_object_migration.py
runTest | `Error` | 0.00 | test_import_unmanage_volumes.py
runTest | `Error` | 0.00 | test_internal_lb.py
runTest | `Error` | 0.00 | test_ipv4_routing.py
runTest | `Error` | 0.00 | test_ipv6_infra.py
runTest | `Error` | 0.00 | test_iso.py
runTest | `Error` | 0.00 | test_kubernetes_clusters.py
runTest | `Error` | 0.00 | test_kubernetes_supported_versions.py
runTest | `Error` | 0.00 | test_list_accounts.py
runTest | `Error` | 0.00 | test_list_disk_offerings.py
runTest | `Error` | 0.00 | test_list_domains.py
runTest | `Error` | 0.00 | test_list_hosts.py
runTest | `Error` | 0.00 | test_list_ids_parameter.py
runTest | `Error` | 0.00 | test_list_service_offerings.py
runTest | `Error` | 0.00 | test_list_storage_pools.py
runTest | `Error` | 0.00 | test_list_volumes.py
runTest | `Error` | 0.00 | test_loadbalance.py
runTest | `Error` | 0.00 | test_login.py
runTest | `Error` | 0.00 | test_migration.py
runTest | `Error` | 0.00 | test_ms_maintenance_and_safe_shutdown.py
runTest | `Error` | 0.00 | test_multipleips_per_nic.py
runTest | `Error` | 0.00 | test_nested_virtualization.py
runTest | `Error` | 0.00 | test_network_acl.py
runTest | `Error` | 0.00 | test_network_ipv6.py
runTest | `Error` | 0.00 | test_network_permissions.py
runTest | `Error` | 0.00 | test_network.py
runTest | `Error` | 0.00 | test_nic_adapter_type.py
runTest | `Error` | 0.00 | test_nic.py
runTest | `Error` | 0.00 | test_non_contigiousvlan.py
runTest | `Error` | 0.00 | test_nonstrict_affinity_group.py
runTest | `Error` | 0.00 | test_outofbandmanagement_nestedplugin.py
runTest | `Error` | 0.00 | test_outofbandmanagement.py
runTest | `Error` | 0.00 | test_over_provisioning.py
runTest | `Error` | 0.00 | test_password_server.py
runTest | `Error` | 0.00 | test_persistent_network.py
runTest | `Error` | 0.00 | test_portable_publicip.py
runTest | `Error` | 0.00 | test_portforwardingrules.py
runTest | `Error` | 0.00 | test_primary_storage.py
runTest | `Error` | 0.00 | test_primary_storage_scope.py
runTest | `Error` | 0.00 | test_privategw_acl_ovs_gre.py
runTest | `Error` | 0.00 | test_privategw_acl.py
runTest | `Error` | 0.00 | test_projects.py
runTest | `Error` | 0.00 | test_public_ip_range.py
runTest | `Error` | 0.00 | test_purge_expunged_vms.py
runTest | `Error` | 0.00 | test_pvlan.py
runTest | `Error` | 0.00 | test_quarantined_ips.py
runTest | `Error` | 0.00 | test_regions.py
runTest | `Error` | 0.00 | test_register_userdata.py
runTest | `Error` | 0.00 | test_reset_configuration_settings.py
runTest | `Error` | 0.00 | test_reset_vm_on_reboot.py
runTest | `Error` | 0.00 | test_resource_accounting.py
runTest | `Error` | 0.00 | test_resource_detail.py
runTest | `Error` | 0.00 | test_resource_names.py
runTest | `Error` | 0.00 | test_restore_vm.py
runTest | `Error` | 0.00 | test_router_dhcphosts.py
runTest | `Error` | 0.00 | test_router_dns.py
runTest | `Error` | 0.00 | test_router_dnsservice.py
runTest | `Error` | 0.00 | test_routers_iptables_default_policy.py
runTest | `Error` | 0.00 | test_routers_network_ops.py
runTest | `Error` | 0.00 | test_routers.py
runTest | `Error` | 0.00 | test_scale_vm.py
runTest | `Error` | 0.00 | test_secondary_storage.py
runTest | `Error` | 0.00 | test_service_offerings.py
runTest | `Error` | 0.00 | test_set_sourcenat.py
runTest | `Error` | 0.00 | test_sharedfs_lifecycle.py
runTest | `Error` | 0.00 | test_snapshots.py
runTest | `Error` | 0.00 | test_ssvm.py
runTest | `Error` | 0.00 | test_storage_policy.py
runTest | `Error` | 0.00 | test_templates.py
runTest | `Error` | 0.00 | test_update_security_group.py
runTest | `Error` | 0.00 | test_usage_events.py
runTest | `Error` | 0.00 | test_usage.py
runTest | `Error` | 0.00 | test_vm_autoscaling.py
runTest | `Error` | 0.00 | test_vm_deployment_planner.py
runTest | `Error` | 0.00 | test_vm_life_cycle.py
runTest | `Error` | 0.00 | test_vm_lifecycle_unmanage_import.py
runTest | `Error` | 0.00 | test_vm_schedule.py
runTest | `Error` | 0.00 | test_vm_snapshot_kvm.py
runTest | `Error` | 0.00 | test_vm_snapshots.py
runTest | `Error` | 0.00 | test_vm_strict_host_tags.py
runTest | `Error` | 0.00 | test_vnf_templates.py
runTest | `Error` | 0.00 | test_volumes.py
runTest | `Error` | 0.00 | test_vpc_ipv6.py
runTest | `Error` | 0.00 | test_vpc_redundant.py
runTest | `Error` | 0.00 | test_vpc_router_nics.py
runTest | `Error` | 0.00 | test_vpc_vpn.py
runTest | `Error` | 0.00 | test_webhook_delivery.py
runTest | `Error` | 0.00 | test_webhook_lifecycle.py
runTest | `Error` | 0.00 | test_host_maintenance.py
runTest | `Error` | 0.00 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3031268602
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2970622621
@sudo87 will you create a doc PR for this as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2970770626
> @sudo87 will you create a doc PR for this as well?
Yes @DaanHoogland, doc pr will be needed for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2981129094
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#discussion_r2191977419
##########
server/src/test/java/com/cloud/vm/FirstFitPlannerTest.java:
##########
@@ -505,4 +573,70 @@ public boolean match(MetadataReader mdr, MetadataReaderFactory arg1) throws IOEx
}
}
}
+
+ List<CapacityVO> getClusterCapacities() {
+ CapacityVO cpuCapacity1 = mock(CapacityVO.class);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(cpuCapacity1.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity1.getUsedCapacity()).thenReturn(1000L);
+ when(cpuCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO cpuCapacity2 = mock(CapacityVO.class);
+ when(cpuCapacity2.getClusterId()).thenReturn(2L);
+ when(cpuCapacity2.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity2.getUsedCapacity()).thenReturn(750L);
+ when(cpuCapacity2.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO memCapacity1 = mock(CapacityVO.class);
+ when(memCapacity1.getClusterId()).thenReturn(1L);
+ when(memCapacity1.getTotalCapacity()).thenReturn(8589934592L);
+ when(memCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(memCapacity1.getUsedCapacity()).thenReturn(536870912L);
+ when(memCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
+
+ CapacityVO memCapacity2 = mock(CapacityVO.class);
+ when(memCapacity2.getClusterId()).thenReturn(2L);
+ when(memCapacity2.getTotalCapacity()).thenReturn(8589934592L);
+ when(memCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(memCapacity2.getUsedCapacity()).thenReturn(1073741824L);
+ when(memCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
+ return Arrays.asList(cpuCapacity1, memCapacity1, cpuCapacity2, memCapacity2);
+ }
+
+ List<CapacityVO> getPodCapacities() {
+ CapacityVO cpuCapacity1 = mock(CapacityVO.class);
+ when(cpuCapacity1.getPodId()).thenReturn(1L);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(cpuCapacity1.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity1.getUsedCapacity()).thenReturn(500L);
+ when(cpuCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO cpuCapacity2 = mock(CapacityVO.class);
+ when(cpuCapacity2.getPodId()).thenReturn(2L);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(cpuCapacity2.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity2.getUsedCapacity()).thenReturn(500L);
+ when(cpuCapacity2.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO memCapacity1 = mock(CapacityVO.class);
+ when(memCapacity1.getPodId()).thenReturn(1L);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(memCapacity1.getTotalCapacity()).thenReturn(8589934592L);
+ when(memCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(memCapacity1.getUsedCapacity()).thenReturn(536870912L);
+ when(memCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
+
+ CapacityVO memCapacity2 = mock(CapacityVO.class);
+ when(memCapacity2.getPodId()).thenReturn(2L);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(memCapacity2.getTotalCapacity()).thenReturn(8589934592L);
+ when(memCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(memCapacity2.getUsedCapacity()).thenReturn(1073741824L);
+ when(memCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
Review Comment:
This stub should target memCapacity2, not memCapacity1, to set the second memory mock correctly.
```suggestion
when(memCapacity2.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
```
##########
server/src/test/java/com/cloud/vm/FirstFitPlannerTest.java:
##########
@@ -505,4 +573,70 @@ public boolean match(MetadataReader mdr, MetadataReaderFactory arg1) throws IOEx
}
}
}
+
+ List<CapacityVO> getClusterCapacities() {
+ CapacityVO cpuCapacity1 = mock(CapacityVO.class);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(cpuCapacity1.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity1.getUsedCapacity()).thenReturn(1000L);
+ when(cpuCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO cpuCapacity2 = mock(CapacityVO.class);
+ when(cpuCapacity2.getClusterId()).thenReturn(2L);
+ when(cpuCapacity2.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity2.getUsedCapacity()).thenReturn(750L);
+ when(cpuCapacity2.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO memCapacity1 = mock(CapacityVO.class);
+ when(memCapacity1.getClusterId()).thenReturn(1L);
+ when(memCapacity1.getTotalCapacity()).thenReturn(8589934592L);
+ when(memCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(memCapacity1.getUsedCapacity()).thenReturn(536870912L);
+ when(memCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
+
+ CapacityVO memCapacity2 = mock(CapacityVO.class);
+ when(memCapacity2.getClusterId()).thenReturn(2L);
+ when(memCapacity2.getTotalCapacity()).thenReturn(8589934592L);
+ when(memCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(memCapacity2.getUsedCapacity()).thenReturn(1073741824L);
+ when(memCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
+ return Arrays.asList(cpuCapacity1, memCapacity1, cpuCapacity2, memCapacity2);
+ }
+
+ List<CapacityVO> getPodCapacities() {
+ CapacityVO cpuCapacity1 = mock(CapacityVO.class);
+ when(cpuCapacity1.getPodId()).thenReturn(1L);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(cpuCapacity1.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity1.getUsedCapacity()).thenReturn(500L);
+ when(cpuCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO cpuCapacity2 = mock(CapacityVO.class);
+ when(cpuCapacity2.getPodId()).thenReturn(2L);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
Review Comment:
This stub should reference cpuCapacity2.getClusterId(), not cpuCapacity1.
```suggestion
when(cpuCapacity2.getClusterId()).thenReturn(1L);
```
##########
server/src/test/java/com/cloud/vm/FirstFitPlannerTest.java:
##########
@@ -505,4 +573,70 @@ public boolean match(MetadataReader mdr, MetadataReaderFactory arg1) throws IOEx
}
}
}
+
+ List<CapacityVO> getClusterCapacities() {
+ CapacityVO cpuCapacity1 = mock(CapacityVO.class);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(cpuCapacity1.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity1.getUsedCapacity()).thenReturn(1000L);
+ when(cpuCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO cpuCapacity2 = mock(CapacityVO.class);
+ when(cpuCapacity2.getClusterId()).thenReturn(2L);
+ when(cpuCapacity2.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity2.getUsedCapacity()).thenReturn(750L);
+ when(cpuCapacity2.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO memCapacity1 = mock(CapacityVO.class);
+ when(memCapacity1.getClusterId()).thenReturn(1L);
+ when(memCapacity1.getTotalCapacity()).thenReturn(8589934592L);
+ when(memCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(memCapacity1.getUsedCapacity()).thenReturn(536870912L);
+ when(memCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
+
+ CapacityVO memCapacity2 = mock(CapacityVO.class);
+ when(memCapacity2.getClusterId()).thenReturn(2L);
+ when(memCapacity2.getTotalCapacity()).thenReturn(8589934592L);
+ when(memCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(memCapacity2.getUsedCapacity()).thenReturn(1073741824L);
+ when(memCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
Review Comment:
This stub is intended for memCapacity2, not memCapacity1—change the mock reference accordingly.
```suggestion
when(memCapacity2.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
```
##########
server/src/test/java/com/cloud/vm/FirstFitPlannerTest.java:
##########
@@ -505,4 +573,70 @@ public boolean match(MetadataReader mdr, MetadataReaderFactory arg1) throws IOEx
}
}
}
+
+ List<CapacityVO> getClusterCapacities() {
+ CapacityVO cpuCapacity1 = mock(CapacityVO.class);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(cpuCapacity1.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity1.getUsedCapacity()).thenReturn(1000L);
+ when(cpuCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO cpuCapacity2 = mock(CapacityVO.class);
+ when(cpuCapacity2.getClusterId()).thenReturn(2L);
+ when(cpuCapacity2.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity2.getUsedCapacity()).thenReturn(750L);
+ when(cpuCapacity2.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO memCapacity1 = mock(CapacityVO.class);
+ when(memCapacity1.getClusterId()).thenReturn(1L);
+ when(memCapacity1.getTotalCapacity()).thenReturn(8589934592L);
+ when(memCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(memCapacity1.getUsedCapacity()).thenReturn(536870912L);
+ when(memCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
+
+ CapacityVO memCapacity2 = mock(CapacityVO.class);
+ when(memCapacity2.getClusterId()).thenReturn(2L);
+ when(memCapacity2.getTotalCapacity()).thenReturn(8589934592L);
+ when(memCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(memCapacity2.getUsedCapacity()).thenReturn(1073741824L);
+ when(memCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
+ return Arrays.asList(cpuCapacity1, memCapacity1, cpuCapacity2, memCapacity2);
+ }
+
+ List<CapacityVO> getPodCapacities() {
+ CapacityVO cpuCapacity1 = mock(CapacityVO.class);
+ when(cpuCapacity1.getPodId()).thenReturn(1L);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(cpuCapacity1.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity1.getUsedCapacity()).thenReturn(500L);
+ when(cpuCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO cpuCapacity2 = mock(CapacityVO.class);
+ when(cpuCapacity2.getPodId()).thenReturn(2L);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(cpuCapacity2.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity2.getUsedCapacity()).thenReturn(500L);
+ when(cpuCapacity2.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO memCapacity1 = mock(CapacityVO.class);
+ when(memCapacity1.getPodId()).thenReturn(1L);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(memCapacity1.getTotalCapacity()).thenReturn(8589934592L);
+ when(memCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(memCapacity1.getUsedCapacity()).thenReturn(536870912L);
+ when(memCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
+
+ CapacityVO memCapacity2 = mock(CapacityVO.class);
+ when(memCapacity2.getPodId()).thenReturn(2L);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
Review Comment:
For memCapacity2, stub memCapacity2.getClusterId(), not cpuCapacity1.
```suggestion
when(memCapacity2.getClusterId()).thenReturn(1L);
```
##########
server/src/test/java/com/cloud/vm/FirstFitPlannerTest.java:
##########
@@ -505,4 +573,70 @@ public boolean match(MetadataReader mdr, MetadataReaderFactory arg1) throws IOEx
}
}
}
+
+ List<CapacityVO> getClusterCapacities() {
+ CapacityVO cpuCapacity1 = mock(CapacityVO.class);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(cpuCapacity1.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity1.getUsedCapacity()).thenReturn(1000L);
+ when(cpuCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO cpuCapacity2 = mock(CapacityVO.class);
+ when(cpuCapacity2.getClusterId()).thenReturn(2L);
+ when(cpuCapacity2.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity2.getUsedCapacity()).thenReturn(750L);
+ when(cpuCapacity2.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO memCapacity1 = mock(CapacityVO.class);
+ when(memCapacity1.getClusterId()).thenReturn(1L);
+ when(memCapacity1.getTotalCapacity()).thenReturn(8589934592L);
+ when(memCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(memCapacity1.getUsedCapacity()).thenReturn(536870912L);
+ when(memCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
+
+ CapacityVO memCapacity2 = mock(CapacityVO.class);
+ when(memCapacity2.getClusterId()).thenReturn(2L);
+ when(memCapacity2.getTotalCapacity()).thenReturn(8589934592L);
+ when(memCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(memCapacity2.getUsedCapacity()).thenReturn(1073741824L);
+ when(memCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_MEMORY);
+ return Arrays.asList(cpuCapacity1, memCapacity1, cpuCapacity2, memCapacity2);
+ }
+
+ List<CapacityVO> getPodCapacities() {
+ CapacityVO cpuCapacity1 = mock(CapacityVO.class);
+ when(cpuCapacity1.getPodId()).thenReturn(1L);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(cpuCapacity1.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity1.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity1.getUsedCapacity()).thenReturn(500L);
+ when(cpuCapacity1.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO cpuCapacity2 = mock(CapacityVO.class);
+ when(cpuCapacity2.getPodId()).thenReturn(2L);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
+ when(cpuCapacity2.getTotalCapacity()).thenReturn(32000L);
+ when(cpuCapacity2.getReservedCapacity()).thenReturn(0L);
+ when(cpuCapacity2.getUsedCapacity()).thenReturn(500L);
+ when(cpuCapacity2.getCapacityType()).thenReturn(CapacityVO.CAPACITY_TYPE_CPU);
+
+ CapacityVO memCapacity1 = mock(CapacityVO.class);
+ when(memCapacity1.getPodId()).thenReturn(1L);
+ when(cpuCapacity1.getClusterId()).thenReturn(1L);
Review Comment:
For memCapacity1, stub memCapacity1.getClusterId(), not cpuCapacity1.
```suggestion
when(memCapacity1.getClusterId()).thenReturn(1L);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3073022788
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3063915732
<b>[SF] Trillian test result (tid-13752)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55396 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10997-t13752-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_template | `Error` | 15.63 | test_templates.py
test_CreateTemplateWithDuplicateName | `Error` | 21.24 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.63 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.65 | test_templates.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2965734216
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3034650703
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2962528368
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2966406166
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2987474371
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 commented on code in PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#discussion_r2156506428
##########
engine/components-api/src/main/java/com/cloud/configuration/ConfigurationManager.java:
##########
@@ -65,6 +65,12 @@ public interface ConfigurationManager {
"allow.non.rfc1918.compliant.ips", "Advanced", "false",
"Allows non-compliant RFC 1918 IPs for Shared, Isolated networks and VPCs", true, null);
+ ConfigKey<Float> HostCapacityTypeCpuMemoryWeight = new ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, Float.class,
+ "host.capacityType.to.order.clusters.cputomemoryweight",
+ "0.5",
+ "CPU to Memory weight used for COMBINED capacityTye to order cluster and host",
Review Comment:
sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2981342158
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2982575565
@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2982572553
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#discussion_r2154103833
##########
engine/components-api/src/main/java/com/cloud/configuration/ConfigurationManager.java:
##########
@@ -65,6 +65,12 @@ public interface ConfigurationManager {
"allow.non.rfc1918.compliant.ips", "Advanced", "false",
"Allows non-compliant RFC 1918 IPs for Shared, Isolated networks and VPCs", true, null);
+ ConfigKey<Float> HostCapacityTypeCpuMemoryWeight = new ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, Float.class,
+ "host.capacityType.to.order.clusters.cputomemoryweight",
+ "0.5",
+ "CPU to Memory weight used for COMBINED capacityTye to order cluster and host",
Review Comment:
maybe give an example of the value ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2965727750
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2966410022
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3034653800
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "rosi-shapeblue (via GitHub)" <gi...@apache.org>.
rosi-shapeblue commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3060593637
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2986613002
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2987472772
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2987728480
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3051982040
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-2958389089
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10997?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 3.96%. Comparing base [(`41b4f0a`)](https://app.codecov.io/gh/apache/cloudstack/commit/41b4f0afd5321e987973b615b566365e48228c6e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`10cd150`)](https://app.codecov.io/gh/apache/cloudstack/commit/10cd150554c0a9c862138d92acf4408ac7639241?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (41b4f0a) and HEAD (10cd150). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (41b4f0a) | HEAD (10cd150) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #10997 +/- ##
=============================================
- Coverage 16.57% 3.96% -12.62%
=============================================
Files 5719 405 -5314
Lines 507200 32959 -474241
Branches 61574 5869 -55705
=============================================
- Hits 84093 1307 -82786
+ Misses 413688 31502 -382186
+ Partials 9419 150 -9269
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10997/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10997/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.96% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10997/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10997?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CPU to Memory weight based algorithm to order cluster [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10997:
URL: https://github.com/apache/cloudstack/pull/10997#issuecomment-3068085433
@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org