You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by TimBarham <gi...@git.apache.org> on 2015/03/27 14:29:12 UTC
[GitHub] cordova-lib pull request: CB-8756 Make 'plugin --save' work more l...
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/195
CB-8756 Make 'plugin --save' work more like 'npm install'
1. `plugin add --save` now always saves version (in the form `^x.y.z`)
2. `plugin add --save` now always overwrites an existing entry.
3. `plugin add` now honors an existing version specified in `config.xml` when a plugin is added without a specific version, even if the `--save` flag is specified.
I also fixed a bug in `isUrl()` (in `util.js`) - `url.protocol` includes the colon, so the protocol for a windows path is something like `c:` - 2 characters, not one.
Note that I'm current finishing off a similar change for `platform add --save`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-8756
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/195.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #195
----
commit b79ca83e64dd8f485209370d9ff1b113ba32d9f2
Author: Tim Barham <ti...@microsoft.com>
Date: 2015-03-27T13:22:20Z
CB-8756 Make plugin --save work more like npm install.
1. 'plugin add --save' now always saves version (in the form '^x.y.z')
2. 'plugin add --save' now always overwrites an existing entry.
3. 'plugin add' now honors an existing version specified in config.xml when a plugin is added without a specific version, even if the '--save' flag is specified.
I also fixed a bug in isUrl() in util.js - url.protocol includes the colon, so the protocol for a windows path is something like "c:" - 2 characters, not one.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8756 Make 'plugin --save' work more l...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham closed the pull request at:
https://github.com/apache/cordova-lib/pull/195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8756 Make 'plugin --save' work more l...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/195#issuecomment-86949466
Sorry, this PR points to the wrong JIRA issue (a bug I closed as a dup of the one this PR should point to). Will close and open a new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org