You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "dweiss (via GitHub)" <gi...@apache.org> on 2025/05/16 14:38:14 UTC
[PR] Fix termination condition in TestStressNRTReplication. [lucene]
dweiss opened a new pull request, #14665:
URL: https://github.com/apache/lucene/pull/14665
Cleans up the code a bit too. Fixes #14664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix termination condition in TestStressNRTReplication. [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on code in PR #14665:
URL: https://github.com/apache/lucene/pull/14665#discussion_r2088329682
##########
lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.java:
##########
@@ -994,26 +998,26 @@ public void run() {
} finally {
starting[idx] = false;
startupThreads.remove(Thread.currentThread());
+ message("N" + idx + ": top: removed thread");
}
}
};
+ startupThreads.add(t);
t.setName("start R" + idx);
t.start();
- startupThreads.add(t);
}
Review Comment:
This is the actual fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix termination condition in TestStressNRTReplication. [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14665:
URL: https://github.com/apache/lucene/pull/14665#issuecomment-2879192882
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org