[GitHub] [spark] amaliujia commented on a diff in pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38415:
URL: https://github.com/apache/spark/pull/38415#discussion_r1007553459


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -47,6 +47,13 @@ message Relation {
 
     Unknown unknown = 999;
   }
+  // Optional. Every relation might have an alias.
+  Alias alias = 200;
+
+  // Relation alias.
+  message Alias {

Review Comment:
   do you think if we need to care client  call `xx.as("")`? Does client side should reject this? If so we can just use a string.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org