You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Pankraz76 (via GitHub)" <gi...@apache.org> on 2025/05/12 11:53:30 UTC
[PR] Remove unused `DefaultPluginXmlFactory#fromXml` [maven]
Pankraz76 opened a new pull request, #2327:
URL: https://github.com/apache/maven/pull/2327
Remove unused `DefaultPluginXmlFactory#fromXml`
- https://github.com/apache/maven/pull/2312
- https://github.com/apache/maven/pull/2326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused `DefaultPluginXmlFactory#fromXml/toXml` [maven]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #2327:
URL: https://github.com/apache/maven/pull/2327#issuecomment-2877621681
wait for enabler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused `DefaultPluginXmlFactory#fromXml/toXml` [maven]
Posted by "hgschmie (via GitHub)" <gi...@apache.org>.
hgschmie commented on PR #2327:
URL: https://github.com/apache/maven/pull/2327#issuecomment-2892671230
Those methods may be used by other code that integrates with Maven. We do not remove public APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused `DefaultPluginXmlFactory#fromXml/toXml` [maven]
Posted by "hgschmie (via GitHub)" <gi...@apache.org>.
hgschmie closed pull request #2327: Remove unused `DefaultPluginXmlFactory#fromXml/toXml`
URL: https://github.com/apache/maven/pull/2327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused `DefaultPluginXmlFactory#fromXml/toXml` [maven]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #2327:
URL: https://github.com/apache/maven/pull/2327#issuecomment-2893102128
> other code that integrates with Maven
where is this code? Will be notice on ci level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused `DefaultPluginXmlFactory#fromXml/toXml` [maven]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #2327:
URL: https://github.com/apache/maven/pull/2327#issuecomment-2893103086
> may be
is kind of random. We should know about our clients and user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused `DefaultPluginXmlFactory#fromXml/toXml` [maven]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 closed pull request #2327: Remove unused `DefaultPluginXmlFactory#fromXml/toXml`
URL: https://github.com/apache/maven/pull/2327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused `DefaultPluginXmlFactory#fromXml/toXml` [maven]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #2327:
URL: https://github.com/apache/maven/pull/2327#discussion_r2084519529
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##########
@@ -100,28 +100,4 @@ public void write(XmlWriterRequest<PluginDescriptor> request) throws XmlWriterEx
throw new XmlWriterException("Unable to write plugin: " + getMessage(e), getLocation(e), e);
}
}
-
- /**
- * Simply parse the given xml string.
- *
- * @param xml the input XML string
- * @return the parsed object
- * @throws XmlReaderException if an error occurs during the parsing
- * @see #toXmlString(Object)
- */
- public static PluginDescriptor fromXml(@Nonnull String xml) throws XmlReaderException {
- return new DefaultPluginXmlFactory().fromXmlString(xml);
- }
Review Comment:
is this actively in use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org