[GitHub] [superset] geido commented on pull request #18784: feat(native-filters): Re-arrange controls in FilterBar

[GitBox <gi...@apache.org>]

geido commented on pull request #18784:
URL: https://github.com/apache/superset/pull/18784#issuecomment-1044678171


   Hey @kgabryje some points / thoughts after manual testing it.
   
   - When scrolling the filter bar changes height and the button is also changing its vertical position
   
   https://user-images.githubusercontent.com/60598000/154705825-1bf9f078-9b24-42f3-b126-4c0b25cee897.mp4
   
   - Don't want to oppose anything but as a personal opinion, I also agree with @michael-s-molina that the transparent bottom actions on scroll look weird. It required a second look to understand it was a design choice. 
   
   <img width="1177" alt="Screen Shot 2022-02-18 at 16 56 53" src="https://user-images.githubusercontent.com/60598000/154707917-a7735284-58e8-444e-81f0-797b8cd6a724.png">
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org