You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/17 07:25:12 UTC

[GitHub] [arrow] jorisvandenbossche opened a new pull request #7467: ARROW-9159: [Python] Enable Array.isnull method

jorisvandenbossche opened a new pull request #7467:
URL: https://github.com/apache/arrow/pull/7467


   Instead of having the NotImplementedError


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorisvandenbossche commented on pull request #7467: ARROW-9159: [Python] Implement Array.isnull/isvalid methods

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #7467:
URL: https://github.com/apache/arrow/pull/7467#issuecomment-646281984


   Thanks for finishing this!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #7467: ARROW-9159: [Python] Enable Array.isnull method

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #7467:
URL: https://github.com/apache/arrow/pull/7467#discussion_r441432896



##########
File path: python/pyarrow/tests/test_compute.py
##########
@@ -313,3 +313,16 @@ def test_compare_chunked_array_mixed():
         arr_chunked == arr_chunked2,
     ]:
         assert result.equals(expected)
+
+
+def test_isnull():
+

Review comment:
       No specific reason, no, removed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wesm commented on pull request #7467: ARROW-9159: [Python] Implement Array.isnull/isvalid methods

Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7467:
URL: https://github.com/apache/arrow/pull/7467#issuecomment-646182878


   Let's do the underscores version. Maybe people will curse us but "a foolish consistency is the hobgoblin of little minds"


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorisvandenbossche commented on pull request #7467: ARROW-9159: [Python] Enable Array.isnull method

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #7467:
URL: https://github.com/apache/arrow/pull/7467#issuecomment-645933837


   Added `isvalid` as well. Two more questions:
   
   - Do we rather prefer the underscore version (`is_valid`, `is_null`)? Since the existing `isnull` wasn't working yet, I don't think we necessarily need to keep the name for the reason that it already existed. 
     Personally, I generally prefer the `_` versions (and which makes it also consistent with the name in the function registry), although for `isnull` the resemblance with pandas is nice as well.
   - Do I also add them as functions in `pyarrow.compute`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #7467: ARROW-9159: [Python] Enable Array.isnull method

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7467:
URL: https://github.com/apache/arrow/pull/7467#issuecomment-645205008


   https://issues.apache.org/jira/browse/ARROW-9159


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on a change in pull request #7467: ARROW-9159: [Python] Enable Array.isnull method

Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7467:
URL: https://github.com/apache/arrow/pull/7467#discussion_r441411194



##########
File path: python/pyarrow/tests/test_compute.py
##########
@@ -313,3 +313,16 @@ def test_compare_chunked_array_mixed():
         arr_chunked == arr_chunked2,
     ]:
         assert result.equals(expected)
+
+
+def test_isnull():
+

Review comment:
       Any reason for the empty line here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wesm commented on pull request #7467: ARROW-9159: [Python] Enable Array.isnull method

Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7467:
URL: https://github.com/apache/arrow/pull/7467#issuecomment-645351456


   Can you add isvalid while you are at it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wesm closed pull request #7467: ARROW-9159: [Python] Implement Array.isnull/isvalid methods

Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7467:
URL: https://github.com/apache/arrow/pull/7467


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] wesm commented on pull request #7467: ARROW-9159: [Python] Implement Array.isnull/isvalid methods

Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7467:
URL: https://github.com/apache/arrow/pull/7467#issuecomment-646184679


   I'm making the change quickly


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org