[GitHub] [skywalking] simonluo345 commented on a diff in pull request #11330: [OSPP] PHP E2E

["simonluo345 (via GitHub)" <gi...@apache.org>]

simonluo345 commented on code in PR #11330:
URL: https://github.com/apache/skywalking/pull/11330#discussion_r1339475879


##########
test/e2e-v2/cases/php/expected/trace-info-detail.yml:
##########
@@ -15,30 +15,34 @@
 
 spans:
   {{- contains .spans }}
-  - traceid: {{ .traceid }}
-    segmentid: {{ .segmentid }}
+  - traceid: "{{ .traceid }}"
+    segmentid: "{{ .segmentid }}"
     spanid: {{ .spanid }}
     parentspanid: {{ .parentspanid }}
     refs: []
     servicecode: php
     serviceinstancename: {{ notEmpty .serviceinstancename }}
     starttime: {{ gt .starttime 0 }}
     endtime: {{ gt .endtime 0 }}
-    endpointname: /php/info
+    endpointname: POST:/php/info
     type: Entry
-    peer: {{ notEmpty .peer }}
+    peer: ""
     component: PHP
     iserror: false
     layer: Http
     tags:
       {{- contains .tags }}
       - key: url
         value: {{ notEmpty .value }}
+      - key: http.method
+        value: {{ notEmpty .value }}
+      - key: http.status_code
+        value: {{ notEmpty .value }}

Review Comment:
   Hi sir, after I locked the value and ran the local test, the e2e testing was not going to pass because the order of the testing was wrong. I think it is a bug from the e2e testing tool. Can I change it back to {{notEmpty .value}} instead of a fixed value?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org