[GitHub] [dolphinscheduler] guoshupei commented on pull request #10563: [improve-10506] [server] add MasterHeartBeat and WorkerHeartBeat to extend HeartBeat

[GitBox <gi...@apache.org>]

guoshupei commented on PR #10563:
URL: https://github.com/apache/dolphinscheduler/pull/10563#issuecomment-1164447535

   Worker fields are needed in some places. like host manager, Of course, it can also be obtained by split string of heartbeat ,but it is not graceful.
   
   发自我的iPhone
   
   > 在 2022年6月23日，21:48，Wenjun Ruan ***@***.***> 写道：
   > 
   > 
   > @ruanwenjun commented on this pull request.
   > 
   > In dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/registry/RegistryClient.java:
   > 
   > > @@ -97,7 +98,7 @@ public List<Server> getServerList(NodeType nodeType) {
   >  
   >          List<Server> serverList = new ArrayList<>();
   >          for (Map.Entry<String, String> entry : serverMaps.entrySet()) {
   > -            HeartBeat heartBeat = HeartBeat.decodeHeartBeat(entry.getValue());
   > +            HeartBeatModel heartBeat = HeartBeatUtils.decodeHeartBeat(entry.getValue(), nodeType);
   > You can make HeartBeatUtil.decodeHeartBeat return AbstractHeartBeat , then the HeartBeatModel can be removed.
   > 
   > —
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   > You are receiving this because you were assigned.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org