[GitHub] [flink] zhuzhurk commented on issue #11148: [FLINK-16180][runtime] Replace the nullable vertexExecution in ScheduledUnit with a non-null executionVertexId

[GitBox <gi...@apache.org>]

zhuzhurk commented on issue #11148: [FLINK-16180][runtime] Replace the nullable vertexExecution in ScheduledUnit with a non-null executionVertexId
URL: https://github.com/apache/flink/pull/11148#issuecomment-591453331
 
 
   @GJL
   
   > In [f58f5c0](https://github.com/apache/flink/commit/f58f5c06cad5f4fd0da9ef1d81e37d1a458ba190) it is not clear to me what issue you are trying to solve. The commit message mentions that it fixes potential NPEs but does not specify where exactly. Moreover, I think that a commit of that size is beyond the scope of a hotfix and warrants a separate ticket.
   
   The NPE issue happens because `getID()` is not mocked in `SchedulerTestUtils`. So that several test would break with the change on {{ScheduledUnit}}.
   And you are right that we can have a separate PR to ticket to remove this mockito dependency in `SchedulerTestUtils`. I will open a new ticket for it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services