You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/07/01 03:25:27 UTC
[GitHub] Menardi commented on a change in pull request #461: Remove old
builders code
Menardi commented on a change in pull request #461: Remove old builders code
URL: https://github.com/apache/cordova-android/pull/461#discussion_r199337129
##########
File path: bin/templates/cordova/Api.js
##########
@@ -56,41 +55,27 @@ function setupEvents (externalEventEmitter) {
function Api (platform, platformRootDir, events) {
this.platform = PLATFORM;
this.root = path.resolve(__dirname, '..');
- this.builder = 'gradle';
+ this.builder = 'studio';
Review comment:
I wasn't sure if other things relied on `Api.builder` so I left it alone. The refactor could do a lot more, but I was reluctant to change too much given that I am still relatively unfamiliar with the codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org