You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "psiroky (via GitHub)" <gi...@apache.org> on 2023/03/07 10:08:47 UTC
[GitHub] [maven-mvnd] psiroky opened a new pull request, #801: Run client connection handler inside new thread, fixes #798
psiroky opened a new pull request, #801:
URL: https://github.com/apache/maven-mvnd/pull/801
* same as https://github.com/apache/maven-mvnd/pull/799 but for master branch
* I quickly tested this locally and master was suffering from the same thread leak issue as the 0.10.x. If we decided this is the solution, then it should be applied to master as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] gnodet merged pull request #801: Run client connection handler inside new thread, fixes #798
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #801:
URL: https://github.com/apache/maven-mvnd/pull/801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] psiroky commented on a diff in pull request #801: Run client connection handler inside new thread, fixes #798
Posted by "psiroky (via GitHub)" <gi...@apache.org>.
psiroky commented on code in PR #801:
URL: https://github.com/apache/maven-mvnd/pull/801#discussion_r1127632451
##########
daemon/src/main/java/org/mvndaemon/mvnd/daemon/Server.java:
##########
@@ -270,7 +279,7 @@ private void client(SocketChannel socket) {
updateState(DaemonState.Idle);
return;
}
- LOGGER.info("Request received: " + message);
+ LOGGER.info("Request received: {}", message);
Review Comment:
Forgot about this one, it is technically not related to the issue, but easy enough fix so I bundled it here (it is even the same class, so hopefully that's ok).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org