You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kanna Karanam (JIRA)" <ji...@apache.org> on 2012/07/30 18:39:34 UTC

[jira] [Created] (HIVE-3319) Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.

Kanna Karanam created HIVE-3319:
-----------------------------------

             Summary: Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.
                 Key: HIVE-3319
                 URL: https://issues.apache.org/jira/browse/HIVE-3319
             Project: Hive
          Issue Type: Sub-task
          Components: Tests, Windows
    Affects Versions: 0.10.0, 0.9.1
            Reporter: Kanna Karanam
            Assignee: Kanna Karanam


TestHiveConf : Location of the “hive-site.xml” path on Unix is different from Windows so need to compare the paths after generating the OS independent URI path.

TestHiveHistory: Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows

TestExecDriver: 
1) Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
2) change the absolute path to relative path of the “Cat” utility to make it work on windows with CygWin tools in the Windows Path.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HIVE-3319) Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.

Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425042#comment-13425042 ] 

Kanna Karanam commented on HIVE-3319:
-------------------------------------

@Edward – These unit tests are failing on Windows even with CygWin support because of the Unix absolute paths. We are taking dependency on “Cat, & TR” Cygwin utilities to run the unit tests on windows. (We are using them as part of Script Descriptor) Thanks
                
> Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-3319
>                 URL: https://issues.apache.org/jira/browse/HIVE-3319
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Tests, Windows
>    Affects Versions: 0.10.0, 0.9.1
>            Reporter: Kanna Karanam
>            Assignee: Kanna Karanam
>              Labels: Windows
>         Attachments: HIVE-3319.1.patch.txt
>
>
> TestHiveConf : Location of the “hive-site.xml” path on Unix is different from Windows so need to compare the paths after generating the OS independent URI path.
> TestHiveHistory: Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> TestExecDriver: 
> 1) Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> 2) change the absolute path to relative path of the “Cat” utility to make it work on windows with CygWin tools in the Windows Path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HIVE-3319) Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427152#comment-13427152 ] 

Hudson commented on HIVE-3319:
------------------------------

Integrated in Hive-trunk-h0.21 #1585 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1585/])
    HIVE-3319 : Fix the TestHiveHistory, TestHiveConf, TestExecDriver unit tests on Windows by fixing the path related issues. (Kanna Karanam via Ashutosh Chauhan) (Revision 1368330)

     Result = SUCCESS
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368330
Files : 
* /hive/trunk/common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java
* /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java
* /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java

                
> Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-3319
>                 URL: https://issues.apache.org/jira/browse/HIVE-3319
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Tests, Windows
>    Affects Versions: 0.10.0, 0.9.1
>            Reporter: Kanna Karanam
>            Assignee: Kanna Karanam
>              Labels: Windows
>             Fix For: 0.10.0
>
>         Attachments: HIVE-3319.1.patch.txt
>
>
> TestHiveConf : Location of the “hive-site.xml” path on Unix is different from Windows so need to compare the paths after generating the OS independent URI path.
> TestHiveHistory: Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> TestExecDriver: 
> 1) Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> 2) change the absolute path to relative path of the “Cat” utility to make it work on windows with CygWin tools in the Windows Path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HIVE-3319) Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.

Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425004#comment-13425004 ] 

Edward Capriolo commented on HIVE-3319:
---------------------------------------

Just wondering. Does this work on windows because dos has a cat operator?

  Operator<ScriptDesc> op2 = OperatorFactory.get(new ScriptDesc("cat",

or is the unit test only testing the plan?
                
> Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-3319
>                 URL: https://issues.apache.org/jira/browse/HIVE-3319
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Tests, Windows
>    Affects Versions: 0.10.0, 0.9.1
>            Reporter: Kanna Karanam
>            Assignee: Kanna Karanam
>              Labels: Windows
>         Attachments: HIVE-3319.1.patch.txt
>
>
> TestHiveConf : Location of the “hive-site.xml” path on Unix is different from Windows so need to compare the paths after generating the OS independent URI path.
> TestHiveHistory: Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> TestExecDriver: 
> 1) Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> 2) change the absolute path to relative path of the “Cat” utility to make it work on windows with CygWin tools in the Windows Path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HIVE-3319) Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.

Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kanna Karanam updated HIVE-3319:
--------------------------------

    Status: Patch Available  (was: Open)
    
> Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-3319
>                 URL: https://issues.apache.org/jira/browse/HIVE-3319
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Tests, Windows
>    Affects Versions: 0.10.0, 0.9.1
>            Reporter: Kanna Karanam
>            Assignee: Kanna Karanam
>              Labels: Windows
>         Attachments: HIVE-3319.1.patch.txt
>
>
> TestHiveConf : Location of the “hive-site.xml” path on Unix is different from Windows so need to compare the paths after generating the OS independent URI path.
> TestHiveHistory: Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> TestExecDriver: 
> 1) Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> 2) change the absolute path to relative path of the “Cat” utility to make it work on windows with CygWin tools in the Windows Path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HIVE-3319) Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426806#comment-13426806 ] 

Ashutosh Chauhan commented on HIVE-3319:
----------------------------------------

+1. Running tests.
                
> Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-3319
>                 URL: https://issues.apache.org/jira/browse/HIVE-3319
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Tests, Windows
>    Affects Versions: 0.10.0, 0.9.1
>            Reporter: Kanna Karanam
>            Assignee: Kanna Karanam
>              Labels: Windows
>         Attachments: HIVE-3319.1.patch.txt
>
>
> TestHiveConf : Location of the “hive-site.xml” path on Unix is different from Windows so need to compare the paths after generating the OS independent URI path.
> TestHiveHistory: Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> TestExecDriver: 
> 1) Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> 2) change the absolute path to relative path of the “Cat” utility to make it work on windows with CygWin tools in the Windows Path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HIVE-3319) Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-3319:
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.10.0
           Status: Resolved  (was: Patch Available)

Committed to trunk. Thanks, Kanna!
                
> Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-3319
>                 URL: https://issues.apache.org/jira/browse/HIVE-3319
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Tests, Windows
>    Affects Versions: 0.10.0, 0.9.1
>            Reporter: Kanna Karanam
>            Assignee: Kanna Karanam
>              Labels: Windows
>             Fix For: 0.10.0
>
>         Attachments: HIVE-3319.1.patch.txt
>
>
> TestHiveConf : Location of the “hive-site.xml” path on Unix is different from Windows so need to compare the paths after generating the OS independent URI path.
> TestHiveHistory: Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> TestExecDriver: 
> 1) Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> 2) change the absolute path to relative path of the “Cat” utility to make it work on windows with CygWin tools in the Windows Path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HIVE-3319) Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.

Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kanna Karanam updated HIVE-3319:
--------------------------------

    Attachment: HIVE-3319.1.patch.txt

Attached the patch. CR is available at https://reviews.apache.org/r/6214/. Thanks
                
> Fix the “TestHiveHistory”, “TestHiveConf”, & “TestExecDriver” unit tests on Windows by fixing the path related issues.
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-3319
>                 URL: https://issues.apache.org/jira/browse/HIVE-3319
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Tests, Windows
>    Affects Versions: 0.10.0, 0.9.1
>            Reporter: Kanna Karanam
>            Assignee: Kanna Karanam
>              Labels: Windows
>         Attachments: HIVE-3319.1.patch.txt
>
>
> TestHiveConf : Location of the “hive-site.xml” path on Unix is different from Windows so need to compare the paths after generating the OS independent URI path.
> TestHiveHistory: Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> TestExecDriver: 
> 1) Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows
> 2) change the absolute path to relative path of the “Cat” utility to make it work on windows with CygWin tools in the Windows Path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira