You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/08/13 20:25:00 UTC

[GitHub] [maven-checkstyle-plugin] michael-o opened a new pull request, #87: [MCHECKSTYLE-417] Upgrade Maven Reporting API to 3.1.1/Maven Reportin…

michael-o opened a new pull request, #87:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/87

   …g Impl to 3.2.0
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCHECKSTYLE) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MCHECKSTYLE-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-checkstyle-plugin] slawekjaranowski commented on a diff in pull request #87: [MCHECKSTYLE-417] Upgrade Maven Reporting API to 3.1.1/Maven Reportin…

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #87:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/87#discussion_r950289733


##########
pom.xml:
##########
@@ -64,11 +64,14 @@ under the License.
 
   <properties>
     <javaVersion>8</javaVersion>
+    <aetherVersion>1.0.0.v20140518</aetherVersion>
     <mavenVersion>3.2.5</mavenVersion>
     <checkstyleVersion>9.3</checkstyleVersion>
     <doxiaVersion>1.11.1</doxiaVersion>
-    <sitePluginVersion>3.9.1</sitePluginVersion>
-    <surefire.version>2.22.2</surefire.version>
+    <doxiaSitetoolsVersion>1.11.1</doxiaSitetoolsVersion>
+    <sitePluginVersion>3.12.1</sitePluginVersion>
+    <jxrPluginVersion>3.3.0</jxrPluginVersion>
+    <surefire.version>3.0.0-M7</surefire.version>

Review Comment:
   `surefire.version` the same value in parent 37



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-checkstyle-plugin] michael-o commented on a diff in pull request #87: [MCHECKSTYLE-417] Upgrade Maven Reporting API to 3.1.1/Maven Reportin…

Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #87:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/87#discussion_r950316588


##########
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java:
##########
@@ -292,7 +292,7 @@
      * @since 2.2
      */
     @Parameter( property = "encoding", defaultValue = "${project.build.sourceEncoding}" )
-    private String encoding;
+    private String inputEncoding;

Review Comment:
   That is correct, have a look at the commit message. With M-R-Impl 3.2.0 this is a problem. I do admit. I haven't really thought about how to solve it since this is a transient issue. What would be your proposal?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-checkstyle-plugin] asfgit merged pull request #87: [MCHECKSTYLE-417] Upgrade Maven Reporting API to 3.1.1/Maven Reportin…

Posted by GitBox <gi...@apache.org>.
asfgit merged PR #87:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/87


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-checkstyle-plugin] michael-o commented on pull request #87: [MCHECKSTYLE-417] Upgrade Maven Reporting API to 3.1.1/Maven Reportin…

Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #87:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/87#issuecomment-1220607920

   @slawekjaranowski JXR 3.3.0 is out, please review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-checkstyle-plugin] slawekjaranowski commented on pull request #87: [MCHECKSTYLE-417] Upgrade Maven Reporting API to 3.1.1/Maven Reportin…

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #87:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/87#issuecomment-1218367868

   After #90 we will see what is wrong with test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-checkstyle-plugin] michael-o commented on a diff in pull request #87: [MCHECKSTYLE-417] Upgrade Maven Reporting API to 3.1.1/Maven Reportin…

Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #87:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/87#discussion_r950315409


##########
pom.xml:
##########
@@ -64,11 +64,14 @@ under the License.
 
   <properties>
     <javaVersion>8</javaVersion>
+    <aetherVersion>1.0.0.v20140518</aetherVersion>
     <mavenVersion>3.2.5</mavenVersion>
     <checkstyleVersion>9.3</checkstyleVersion>
     <doxiaVersion>1.11.1</doxiaVersion>
-    <sitePluginVersion>3.9.1</sitePluginVersion>
-    <surefire.version>2.22.2</surefire.version>
+    <doxiaSitetoolsVersion>1.11.1</doxiaSitetoolsVersion>
+    <sitePluginVersion>3.12.1</sitePluginVersion>
+    <jxrPluginVersion>3.3.0</jxrPluginVersion>
+    <surefire.version>3.0.0-M7</surefire.version>

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-checkstyle-plugin] michael-o commented on pull request #87: [MCHECKSTYLE-417] Upgrade Maven Reporting API to 3.1.1/Maven Reportin…

Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #87:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/87#issuecomment-1218370247

   > After #90 we will see what is wrong with test
   
   The current failure is expected because JXR isn't out yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-checkstyle-plugin] slawekjaranowski commented on a diff in pull request #87: [MCHECKSTYLE-417] Upgrade Maven Reporting API to 3.1.1/Maven Reportin…

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #87:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/87#discussion_r950292397


##########
src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java:
##########
@@ -292,7 +292,7 @@
      * @since 2.2
      */
     @Parameter( property = "encoding", defaultValue = "${project.build.sourceEncoding}" )
-    private String encoding;
+    private String inputEncoding;

Review Comment:
   breaking change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org