You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/05/26 15:17:45 UTC

[GitHub] [flink] twalthr opened a new pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

twalthr opened a new pull request #16008:
URL: https://github.com/apache/flink/pull/16008


   ## What is the purpose of the change
   
   This is a major cleanup of the Python module that drops support for `BatchTableEnvironment` and old planner.
   
   Some tests might need to be reintroduced in followup issues. We might need several cleanup iterations to make the API clean and concise again. Also the documentation.
   
   ## Brief change log
   
   Removes usages of:
   - DataSet
   - BatchTableEnvironment
   - Legacy planner
   - ExecutionEnvironment
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): yes
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16008:
URL: https://github.com/apache/flink/pull/16008#issuecomment-848895159


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e9fe49b634fdc240053fe24c06c11191b2deea9f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18350",
       "triggerID" : "e9fe49b634fdc240053fe24c06c11191b2deea9f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "881ebf08dd46138f537c021fd213c06a95db9c06",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18388",
       "triggerID" : "881ebf08dd46138f537c021fd213c06a95db9c06",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e9fe49b634fdc240053fe24c06c11191b2deea9f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18350) 
   * 881ebf08dd46138f537c021fd213c06a95db9c06 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18388) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16008:
URL: https://github.com/apache/flink/pull/16008#issuecomment-848895159


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e9fe49b634fdc240053fe24c06c11191b2deea9f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e9fe49b634fdc240053fe24c06c11191b2deea9f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e9fe49b634fdc240053fe24c06c11191b2deea9f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16008:
URL: https://github.com/apache/flink/pull/16008#issuecomment-848895159


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e9fe49b634fdc240053fe24c06c11191b2deea9f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18350",
       "triggerID" : "e9fe49b634fdc240053fe24c06c11191b2deea9f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e9fe49b634fdc240053fe24c06c11191b2deea9f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18350) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] HuangXingBo commented on pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on pull request #16008:
URL: https://github.com/apache/flink/pull/16008#issuecomment-850230239


   Hi @twalthr  I have pushed two commits about reverting some python tests and removing python serializers used in old planner. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16008:
URL: https://github.com/apache/flink/pull/16008#issuecomment-848895159


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e9fe49b634fdc240053fe24c06c11191b2deea9f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18350",
       "triggerID" : "e9fe49b634fdc240053fe24c06c11191b2deea9f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e9fe49b634fdc240053fe24c06c11191b2deea9f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18350) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr commented on pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #16008:
URL: https://github.com/apache/flink/pull/16008#issuecomment-850260656


   Thanks for the additional commits @HuangXingBo. I'm fine to merge this PR now once the build turns green. Are you also giving your ok or are we expecting another review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16008:
URL: https://github.com/apache/flink/pull/16008#issuecomment-848861290


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 881ebf08dd46138f537c021fd213c06a95db9c06 (Sat Aug 28 12:13:01 UTC 2021)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] HuangXingBo commented on pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on pull request #16008:
URL: https://github.com/apache/flink/pull/16008#issuecomment-849488088


   @twalthr Thanks a lot for the work. I will take a look asap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16008:
URL: https://github.com/apache/flink/pull/16008#issuecomment-848895159


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e9fe49b634fdc240053fe24c06c11191b2deea9f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18350",
       "triggerID" : "e9fe49b634fdc240053fe24c06c11191b2deea9f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "881ebf08dd46138f537c021fd213c06a95db9c06",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18388",
       "triggerID" : "881ebf08dd46138f537c021fd213c06a95db9c06",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 881ebf08dd46138f537c021fd213c06a95db9c06 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18388) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr commented on pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #16008:
URL: https://github.com/apache/flink/pull/16008#issuecomment-848861627


   CC @dianfu @HuangXingBo
   I'm sure I forgot something. Feel free to push commits to this pull request if you think some tests should remain in a modified version. My Python deletion skills are better than my Python programming skills ;-) Also the Python shell needs an update as it does not use the unified TableEnvironment yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16008:
URL: https://github.com/apache/flink/pull/16008#issuecomment-848895159


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e9fe49b634fdc240053fe24c06c11191b2deea9f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18350",
       "triggerID" : "e9fe49b634fdc240053fe24c06c11191b2deea9f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "881ebf08dd46138f537c021fd213c06a95db9c06",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "881ebf08dd46138f537c021fd213c06a95db9c06",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e9fe49b634fdc240053fe24c06c11191b2deea9f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18350) 
   * 881ebf08dd46138f537c021fd213c06a95db9c06 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr closed pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #16008:
URL: https://github.com/apache/flink/pull/16008


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16008: [FLINK-22619][python] Drop usages of BatchTableEnvironment and old planner in Python

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16008:
URL: https://github.com/apache/flink/pull/16008#issuecomment-848861290


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit e9fe49b634fdc240053fe24c06c11191b2deea9f (Wed May 26 15:20:37 UTC 2021)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org