You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/11/15 09:40:06 UTC

[GitHub] PaulAngus commented on a change in pull request #3028: Adding zone disablement during deletion of the range plus one more tr…

PaulAngus commented on a change in pull request #3028: Adding zone disablement during deletion of the range plus one more tr…
URL: https://github.com/apache/cloudstack/pull/3028#discussion_r233771509
 
 

 ##########
 File path: test/integration/smoke/test_public_ip_range.py
 ##########
 @@ -377,8 +393,45 @@ def test_dedicate_public_ip_range_for_system_vms_02_cpvm(self):
             "vlan":self.services["vlan"]
         }
 
-        self.base_system_vm(
-            services,
-            'consoleproxy'
-        )
+        try:
+            self.base_system_vm(
+                services,
+                'secondarystoragevm'
 
 Review comment:
   copy and paste fail here.  This should be the consoleproxy being tested in this test
   ```suggestion
                   'consoleproxy'
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services