You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "LucaCappelletti94 (via GitHub)" <gi...@apache.org> on 2026/10/18 10:29:30 UTC
[PR] Refactoring: Merge the `IN` expression variants into `Expr::In` [datafusion-sqlparser-rs]
LucaCappelletti94 opened a new pull request, #2679:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2679
`Expr` had three variants for the `IN` predicate, `InList`, `InSubquery` and `InUnnest`, each repeating the left-hand expression and the `NOT` flag, two of them repeating ClickHouse's `GLOBAL` flag, and each with its own copy of the `Display`, `Spanned` and parser code. Supporting another right-hand side, such as SQLite's `IN table_name`, meant a fourth copy.
They are now one `Expr::In { expr, target, negated, global }`, where `target` is an `InTarget`: `List`, `Subquery` or `Unnest`. The SQL that parses and the text printed back are unchanged, `GLOBAL` is still only accepted before a list or subquery, and `size_of::<Expr>()` stays at 328 bytes. This is a breaking change for code that builds or matches `Expr::InList`, `Expr::InSubquery` or `Expr::InUnnest`, which now match `Expr::In` with the corresponding `InTarget`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Refactoring: Merge the `IN` expression variants into `Expr::In` [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 merged PR #2679:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Refactoring: Merge the `IN` expression variants into `Expr::In` [datafusion-sqlparser-rs]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2679:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2679#issuecomment-6248780078
## [Codecov](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2679?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `78.57143%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 81.27%. Comparing base ([`4ad8784`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/4ad878405805b0a0c0df347acd91845c4745cff5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`653d166`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/653d1668fade74d2302f395e1fd492ee76e89c7b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2679?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [src/ast/spans.rs](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2679?src=pr&el=tree&filepath=src%2Fast%2Fspans.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL2FzdC9zcGFucy5ycw==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2679 +/- ##
=======================================
Coverage 81.26% 81.27%
=======================================
Files 42 42
Lines 33913 33914 +1
Branches 33913 33914 +1
=======================================
+ Hits 27559 27563 +4
+ Misses 2789 2786 -3
Partials 3565 3565
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2679?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org