You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/05/26 12:33:14 UTC

[GitHub] [qpid-proton] jiridanek opened a new pull request #317: PROTON-2254 Use more modern CMake install machinery for better config.cmake

jiridanek opened a new pull request #317:
URL: https://github.com/apache/qpid-proton/pull/317


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] jiridanek commented on pull request #317: PROTON-2254 Use more modern CMake install machinery for better config.cmake

Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #317:
URL: https://github.com/apache/qpid-proton/pull/317#issuecomment-869776008


   With DISPATCH-2178 merged, Dispatch should no longer need to build position-independent static libraries here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] jiridanek merged pull request #317: PROTON-2254 Use more modern CMake install machinery for better config.cmake

Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #317:
URL: https://github.com/apache/qpid-proton/pull/317


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #317: PROTON-2254 Use more modern CMake install machinery for better config.cmake

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #317:
URL: https://github.com/apache/qpid-proton/pull/317#issuecomment-848816517


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#317](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3a2a2b) into [main](https://codecov.io/gh/apache/qpid-proton/commit/ae6c741e3377787ec725fd6e6ebe0aedfcb1e110?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae6c741) will **increase** coverage by `19.36%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head d3a2a2b differs from pull request most recent head f4817bc. Consider uploading reports for the commit f4817bc to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/317/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##             main     #317       +/-   ##
   ===========================================
   + Coverage   68.60%   87.96%   +19.36%     
   ===========================================
     Files         351       47      -304     
     Lines       70276     2394    -67882     
   ===========================================
   - Hits        48212     2106    -46106     
   + Misses      22064      288    -21776     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [ruby/lib/util/error\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvdXRpbC9lcnJvcl9oYW5kbGVyLnJi) | `59.37% <0.00%> (-28.13%)` | :arrow_down: |
   | [cpp/src/reconnect\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9yZWNvbm5lY3RfdGVzdC5jcHA=) | | |
   | [c/tests/pn\_test.hpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9wbl90ZXN0LmhwcA==) | | |
   | [c/tests/pn\_test\_proactor.hpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9wbl90ZXN0X3Byb2FjdG9yLmhwcA==) | | |
   | [python/tests/proton-test](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbi10ZXN0) | | |
   | [c/src/messenger/messenger.c](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvbWVzc2VuZ2VyL21lc3Nlbmdlci5j) | | |
   | [cpp/src/value.cpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy92YWx1ZS5jcHA=) | | |
   | [cpp/include/proton/timestamp.hpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3RpbWVzdGFtcC5ocHA=) | | |
   | [c/src/proactor/proactor-internal.h](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvcHJvYWN0b3IvcHJvYWN0b3ItaW50ZXJuYWwuaA==) | | |
   | [c/tools/include/pncompat/misc\_funcs.inc](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90b29scy9pbmNsdWRlL3BuY29tcGF0L21pc2NfZnVuY3MuaW5j) | | |
   | ... and [295 more](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ae6c741...f4817bc](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #317: PROTON-2254 Use more modern CMake install machinery for better config.cmake

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #317:
URL: https://github.com/apache/qpid-proton/pull/317#issuecomment-848816517


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#317](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3a2a2b) into [main](https://codecov.io/gh/apache/qpid-proton/commit/ae6c741e3377787ec725fd6e6ebe0aedfcb1e110?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae6c741) will **increase** coverage by `19.36%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head d3a2a2b differs from pull request most recent head f4817bc. Consider uploading reports for the commit f4817bc to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/317/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##             main     #317       +/-   ##
   ===========================================
   + Coverage   68.60%   87.96%   +19.36%     
   ===========================================
     Files         351       47      -304     
     Lines       70276     2394    -67882     
   ===========================================
   - Hits        48212     2106    -46106     
   + Misses      22064      288    -21776     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [ruby/lib/util/error\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvdXRpbC9lcnJvcl9oYW5kbGVyLnJi) | `59.37% <0.00%> (-28.13%)` | :arrow_down: |
   | [cpp/include/proton/transport.hpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3RyYW5zcG9ydC5ocHA=) | | |
   | [cpp/src/source.cpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zb3VyY2UuY3Bw) | | |
   | [c/src/proactor/epoll\_timer.c](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGxfdGltZXIuYw==) | | |
   | [c/src/sasl/sasl.c](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvc2FzbC9zYXNsLmM=) | | |
   | [python/tests/proton\_tests/ssl.py](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbl90ZXN0cy9zc2wucHk=) | | |
   | [c/examples/send-ssl.c](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9leGFtcGxlcy9zZW5kLXNzbC5j) | | |
   | [c/src/core/init.c](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9pbml0LmM=) | | |
   | [build/python/cproton.py](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVpbGQvcHl0aG9uL2Nwcm90b24ucHk=) | | |
   | [python/tests/proton\_tests/codec.py](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbl90ZXN0cy9jb2RlYy5weQ==) | | |
   | ... and [295 more](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ae6c741...f4817bc](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #317: PROTON-2254 Use more modern CMake install machinery for better config.cmake

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #317:
URL: https://github.com/apache/qpid-proton/pull/317#issuecomment-848816517


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#317](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3a2a2b) into [main](https://codecov.io/gh/apache/qpid-proton/commit/ae6c741e3377787ec725fd6e6ebe0aedfcb1e110?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae6c741) will **increase** coverage by `19.74%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head d3a2a2b differs from pull request most recent head f4817bc. Consider uploading reports for the commit f4817bc to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/317/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##             main     #317       +/-   ##
   ===========================================
   + Coverage   68.60%   88.34%   +19.74%     
   ===========================================
     Files         351       47      -304     
     Lines       70276     2394    -67882     
   ===========================================
   - Hits        48212     2115    -46097     
   + Misses      22064      279    -21785     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [cpp/include/proton/terminus.hpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3Rlcm1pbnVzLmhwcA==) | | |
   | [c/tests/proactor\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9wcm9hY3Rvcl90ZXN0LmNwcA==) | | |
   | [c/src/messenger/store.c](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvbWVzc2VuZ2VyL3N0b3JlLmM=) | | |
   | [python/proton/\_url.py](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Byb3Rvbi9fdXJsLnB5) | | |
   | [c/tests/refcount\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9yZWZjb3VudF90ZXN0LmNwcA==) | | |
   | [cpp/src/binary.cpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9iaW5hcnkuY3Bw) | | |
   | [cpp/examples/flow\_control.cpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL2Zsb3dfY29udHJvbC5jcHA=) | | |
   | [python/tests/proton\_tests/reactor.py](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbl90ZXN0cy9yZWFjdG9yLnB5) | | |
   | [python/proton/\_message.py](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Byb3Rvbi9fbWVzc2FnZS5weQ==) | | |
   | [c/tests/fuzz/StandaloneFuzzTargetInit.c](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9mdXp6L1N0YW5kYWxvbmVGdXp6VGFyZ2V0SW5pdC5j) | | |
   | ... and [294 more](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ae6c741...f4817bc](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] codecov-commenter commented on pull request #317: PROTON-2254 Use more modern CMake install machinery for better config.cmake

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #317:
URL: https://github.com/apache/qpid-proton/pull/317#issuecomment-848816517


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#317](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3a2a2b) into [main](https://codecov.io/gh/apache/qpid-proton/commit/ae6c741e3377787ec725fd6e6ebe0aedfcb1e110?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae6c741) will **increase** coverage by `19.36%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head d3a2a2b differs from pull request most recent head f4817bc. Consider uploading reports for the commit f4817bc to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/317/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##             main     #317       +/-   ##
   ===========================================
   + Coverage   68.60%   87.96%   +19.36%     
   ===========================================
     Files         351       47      -304     
     Lines       70276     2394    -67882     
   ===========================================
   - Hits        48212     2106    -46106     
   + Misses      22064      288    -21776     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [ruby/lib/util/error\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvdXRpbC9lcnJvcl9oYW5kbGVyLnJi) | `59.37% <0.00%> (-28.13%)` | :arrow_down: |
   | [cpp/src/sasl.cpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zYXNsLmNwcA==) | | |
   | [cpp/include/proton/work\_queue.hpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3dvcmtfcXVldWUuaHBw) | | |
   | [c/src/core/object/object.c](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9vYmplY3Qvb2JqZWN0LmM=) | | |
   | [c/src/core/message.c](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9tZXNzYWdlLmM=) | | |
   | [python/proton/\_\_init\_\_.py](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Byb3Rvbi9fX2luaXRfXy5weQ==) | | |
   | [cpp/src/connection\_driver\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9jb25uZWN0aW9uX2RyaXZlcl90ZXN0LmNwcA==) | | |
   | [cpp/src/type\_id.cpp](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy90eXBlX2lkLmNwcA==) | | |
   | [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | | |
   | [python/proton/\_reactor.py](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Byb3Rvbi9fcmVhY3Rvci5weQ==) | | |
   | ... and [295 more](https://codecov.io/gh/apache/qpid-proton/pull/317/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ae6c741...f4817bc](https://codecov.io/gh/apache/qpid-proton/pull/317?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] jiridanek commented on pull request #317: PROTON-2254 Use more modern CMake install machinery for better config.cmake

Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #317:
URL: https://github.com/apache/qpid-proton/pull/317#issuecomment-895967538


   This seems to work at this point. There is one little problem. In `version.h`, there is `#define PN_INSTALL_PREFIX` that is used for deriving path to the json connect config file. The path there ends up being absolute.
   
   The most reasonable anchor point to make it relative is probably the location of proton .so library; however that would not work for static builds, and looking up the lib is quite messy. So I propose to ignore this one remaining instance of absolute paths in the install.
   
   I got a review on this on https://github.com/apache/qpid-proton/pull/312 already, and I fixed there the objection (there is no longer any PIC present; but it can be still opted in on CMake command line if needed).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] jiridanek commented on pull request #317: PROTON-2254 Use more modern CMake install machinery for better config.cmake

Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #317:
URL: https://github.com/apache/qpid-proton/pull/317#issuecomment-869776008


   With DISPATCH-2178 merged, Dispatch should no longer need to build position-independent static libraries here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org