You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2017/07/10 23:55:23 UTC
[native-toolchain-CR] Prevent leaking AWS credentials to the log.
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7391
Change subject: Prevent leaking AWS credentials to the log.
......................................................................
Prevent leaking AWS credentials to the log.
Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
---
M functions.sh
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/91/7391/1
--
To view, visit http://gerrit.cloudera.org:8080/7391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[native-toolchain-CR] Prevent leaking AWS credentials to the log.
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: Prevent leaking AWS credentials to the log.
......................................................................
Patch Set 2: Code-Review+1
Lars asked me to look at this as well, and I feel the same way.
Tim Wood is better at bash than me. I'll confer with him, then +2 if things check out.
--
To view, visit http://gerrit.cloudera.org:8080/7391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] Prevent leaking AWS credentials to the log.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Prevent leaking AWS credentials to the log.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] Prevent leaking AWS credentials to the log.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged.
Change subject: Prevent leaking AWS credentials to the log.
......................................................................
Prevent leaking AWS credentials to the log.
Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
---
M functions.sh
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
David Knupp: Looks good to me, approved
Lars Volker: Verified
Matthew Jacobs: Looks good to me, but someone else must approve
Tim Wood: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/7391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
[native-toolchain-CR] Prevent leaking AWS credentials to the log.
Posted by "Tim Wood (Code Review)" <ge...@cloudera.org>.
Tim Wood has posted comments on this change.
Change subject: Prevent leaking AWS credentials to the log.
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] Prevent leaking AWS credentials to the log.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has uploaded a new patch set (#2).
Change subject: Prevent leaking AWS credentials to the log.
......................................................................
Prevent leaking AWS credentials to the log.
Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
---
M functions.sh
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/91/7391/2
--
To view, visit http://gerrit.cloudera.org:8080/7391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[native-toolchain-CR] Prevent leaking AWS credentials to the log.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Prevent leaking AWS credentials to the log.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7391/2/functions.sh
File functions.sh:
Line 380: if set +o | grep -q "set -o xtrace"; then
Should we parse "set -o" here instead?
--
To view, visit http://gerrit.cloudera.org:8080/7391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[native-toolchain-CR] Prevent leaking AWS credentials to the log.
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: Prevent leaking AWS credentials to the log.
......................................................................
Patch Set 2: Code-Review+1
I think this makes sense (bash flags are weird). It'd be good to get someone more familiar with bash to check as well.
--
To view, visit http://gerrit.cloudera.org:8080/7391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] Prevent leaking AWS credentials to the log.
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: Prevent leaking AWS credentials to the log.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] Prevent leaking AWS credentials to the log.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Prevent leaking AWS credentials to the log.
......................................................................
Patch Set 2:
Thank you all for the quick reviews!
--
To view, visit http://gerrit.cloudera.org:8080/7391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43ae8d6f347d0ce3d223bd6e86759bb33f2520e6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-HasComments: No