You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by filmaj <gi...@git.apache.org> on 2017/05/25 18:56:30 UTC
[GitHub] cordova-android pull request #382: CB-12859: document how to run the native ...
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-android/pull/382
CB-12859: document how to run the native tests
Please review @infil00p.
FYI @dpogue @purplecabbage @shazron @jcesarmobile @alsorokin.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database: [CB-12859](https://issues.apache.org/jira/browse/CB-12859).
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/filmaj/cordova-android native-tests-docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/382.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #382
----
commit c350b392636c12dc66a7d5258b3c4b840b006115
Author: filmaj <ma...@gmail.com>
Date: 2017-05-25T18:54:25Z
CB-12859: document how to run the native tests. add a README to the test/ project.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #382: CB-12859: document how to run the native tests
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/382
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/382?src=pr&el=h1) Report
> Merging [#382](https://codecov.io/gh/apache/cordova-android/pull/382?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/f396712f59a515dadd1f48d80104dee6a770360e?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/382?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #382 +/- ##
=======================================
Coverage 39.52% 39.52%
=======================================
Files 16 16
Lines 1551 1551
Branches 277 277
=======================================
Hits 613 613
Misses 938 938
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/382?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/382?src=pr&el=footer). Last update [f396712...c350b39](https://codecov.io/gh/apache/cordova-android/pull/382?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #382: CB-12859: document how to run the native ...
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/382#discussion_r118572485
--- Diff: test/README.md ---
@@ -0,0 +1,58 @@
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+-->
+
+# Cordova Android Test Project
+
+The project in this directory is an Android Test project that enables those
+interested in further developing cordova-android to validate their changes.
+
+## Requirements
+
+The requirements in the top-level README still apply. In addition, ensure you
+have installed Gradle, and that it is (at the time of this writing) at least
+version 3.3 or newer.
+
+## Getting Started
+
+You can run this test project from both the command line as well as from
+Android Studio.
+
+### Command Line
+
+Ensure you have the gradle wrapper script, `gradlew`, in this directory. If
+you do not, you can run the following to generate it:
+
+ $ cd cordova-android/test
+ $ gradle :wrapper -b build.gradle
+
+You can then see a list of all tasks available to run with `gradlew tasks`.
+
+The two different kinds of tests one typically wants to run are unit tests and
+end-to-end, or instrumented, tests. Unit tests do not require any particular
+environment to run int, but the instrumented tests, however, require a
--- End diff --
int -> in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #382: CB-12859: document how to run the native tests
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/382
Adjusted based on comments. Thanks y'all! Once tests pass I will merge in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #382: CB-12859: document how to run the native ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/382
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #382: CB-12859: document how to run the native ...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/382#discussion_r118570607
--- Diff: README.md ---
@@ -62,3 +62,9 @@ These commands live in a generated Cordova Android project. Any interactions wit
1. Create a project
2. Import it via "Non-Android Studio Project"
+
+## Running the Native Tests
+
+The `test/` directory in this project contains an Android test project that can
+be used to run different kinds of native tests. Check out the README contained
--- End diff --
wonder if you could link to the nested README here. I know, i'm lazy
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org