You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/16 02:29:51 UTC
[GitHub] [incubator-eventmesh] sclark268626 opened a new pull request, #1613: [ISSUE #1536] Method uses integer based for loops to iterate over a List [Subscription]
sclark268626 opened a new pull request, #1613:
URL: https://github.com/apache/incubator-eventmesh/pull/1613
Fixes #1536.
### Motivation
There are two for loops in the method writeTo that use integer based loops to iterate over the subscriptionItems list. Because the integer is not used for any other reason, it's better to use an iterator or a for-each loop.
### Modifications
I changed the integer based for loops in the writeTo method to for-each loops
### Documentation
none
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #1613: [ISSUE #1536] Method uses integer based for loops to iterate over a List [Subscription]
Posted by GitBox <gi...@apache.org>.
qqeasonchen merged PR #1613:
URL: https://github.com/apache/incubator-eventmesh/pull/1613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] githublaohu commented on pull request #1613: [ISSUE #1536] Method uses integer based for loops to iterate over a List [Subscription]
Posted by GitBox <gi...@apache.org>.
githublaohu commented on PR #1613:
URL: https://github.com/apache/incubator-eventmesh/pull/1613#issuecomment-1280172440
@sclark268626 please check your commit email with your github email, if they are different, this contribution will not be counted in. You need to make sure your commit history in your local environment with your github email, not other email. such like pic below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org