You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Tom Jordahl <to...@macromedia.com> on 2002/09/20 16:10:50 UTC
RE: cvs commit: xml-axis/java/src/org/apache/axis/description Ser
viceDesc.java
Hey Dims,
I put my name on this bug as working on it.
The actual bug is in the ParamReader code, which isn't returning null like the javadocs said it would if it can't find debug info...
But the defensive code you added is good also
--
Tom Jordahl
Macromedia Server Development
-----Original Message-----
From: dims@apache.org [mailto:dims@apache.org]
Sent: Friday, September 20, 2002 10:07 AM
To: xml-axis-cvs@apache.org
Subject: cvs commit: xml-axis/java/src/org/apache/axis/description
ServiceDesc.java
dims 2002/09/20 07:06:52
Modified: java/src/org/apache/axis/description ServiceDesc.java
Log:
Possible fix for Bug 12836 - wsdl:part name is empty "" if not compile with debug
Note: It's difficult to write a test case for this :-)
Revision Changes Path
1.56 +1 -1 xml-axis/java/src/org/apache/axis/description/ServiceDesc.java
Index: ServiceDesc.java
===================================================================
RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/description/ServiceDesc.java,v
retrieving revision 1.55
retrieving revision 1.56
diff -u -r1.55 -r1.56
--- ServiceDesc.java 18 Sep 2002 16:10:43 -0000 1.55
+++ ServiceDesc.java 20 Sep 2002 14:06:52 -0000 1.56
@@ -967,7 +967,7 @@
ParameterDesc paramDesc = new ParameterDesc();
// If we have a name for this param, use it, otherwise call
// it "in*"
- if (paramNames != null) {
+ if (paramNames != null && paramNames[k] != null && paramNames[k].length()>0) {
paramDesc.setName(paramNames[k]);
} else {
paramDesc.setName("in" + k);
RE: cvs commit: xml-axis/java/src/org/apache/axis/description Ser viceDesc.java
Posted by Davanum Srinivas <di...@yahoo.com>.
Sorry Tom, I forgot to check nagoya...Was fixing the problem reported by chris ("in0" not
genreated when no debug) when i decided to clean this up as well.
FYI, now the cache gets cleanup as well when the servicedesc...
Thanks,
dims
--- Tom Jordahl <to...@macromedia.com> wrote:
>
> Hey Dims,
>
> I put my name on this bug as working on it.
>
> The actual bug is in the ParamReader code, which isn't returning null like the javadocs said it
> would if it can't find debug info...
>
> But the defensive code you added is good also
>
> --
> Tom Jordahl
> Macromedia Server Development
>
>
>
> -----Original Message-----
> From: dims@apache.org [mailto:dims@apache.org]
> Sent: Friday, September 20, 2002 10:07 AM
> To: xml-axis-cvs@apache.org
> Subject: cvs commit: xml-axis/java/src/org/apache/axis/description
> ServiceDesc.java
>
>
> dims 2002/09/20 07:06:52
>
> Modified: java/src/org/apache/axis/description ServiceDesc.java
> Log:
> Possible fix for Bug 12836 - wsdl:part name is empty "" if not compile with debug
>
> Note: It's difficult to write a test case for this :-)
>
> Revision Changes Path
> 1.56 +1 -1 xml-axis/java/src/org/apache/axis/description/ServiceDesc.java
>
> Index: ServiceDesc.java
> ===================================================================
> RCS file: /home/cvs/xml-axis/java/src/org/apache/axis/description/ServiceDesc.java,v
> retrieving revision 1.55
> retrieving revision 1.56
> diff -u -r1.55 -r1.56
> --- ServiceDesc.java 18 Sep 2002 16:10:43 -0000 1.55
> +++ ServiceDesc.java 20 Sep 2002 14:06:52 -0000 1.56
> @@ -967,7 +967,7 @@
> ParameterDesc paramDesc = new ParameterDesc();
> // If we have a name for this param, use it, otherwise call
> // it "in*"
> - if (paramNames != null) {
> + if (paramNames != null && paramNames[k] != null && paramNames[k].length()>0) {
> paramDesc.setName(paramNames[k]);
> } else {
> paramDesc.setName("in" + k);
>
>
>
=====
Davanum Srinivas - http://xml.apache.org/~dims/
__________________________________________________
Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
http://sbc.yahoo.com