You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "heguanhui (via GitHub)" <gi...@apache.org> on 2026/05/25 16:05:18 UTC
[PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
heguanhui opened a new pull request, #63638:
URL: https://github.com/apache/doris/pull/63638
### What problem does this PR solve?
Issue Number: close #xxx
Problem Summary: `DROP ROW POLICY ... FOR ROLE <role_name>` does not validate whether the role exists, while `CREATE ROW POLICY ... FOR ROLE <role_name>` does validate. This inconsistency allows dropping a row policy with a non-existent role name without any error.
Additionally, when `IF EXISTS` is specified, the role existence check should be skipped because if the role doesn't exist, the corresponding policy cannot exist either (since creation validates the role). The `IF EXISTS` semantics should silently return in this case.
### Release note
Fix: `DROP ROW POLICY ... FOR ROLE <non_exist_role>` now throws an error when the role does not exist, consistent with `CREATE ROW POLICY` behavior. `DROP ROW POLICY IF EXISTS ... FOR ROLE <non_exist_role>` silently returns as expected.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [x] Yes. `DROP ROW POLICY ... FOR ROLE <non_exist_role>` now throws AnalysisException when role does not exist. `DROP ROW POLICY IF EXISTS ... FOR ROLE <non_exist_role>` silently returns.
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63638:
URL: https://github.com/apache/doris/pull/63638#issuecomment-4562875526
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63638:
URL: https://github.com/apache/doris/pull/63638#issuecomment-4538833024
<details>
<summary>TPC-H: <b>Total hot run time: 31612 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 17819b27aabf9dd03a94c0df62b32482fb4be027, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17692 4031 3964 3964
q2 q3 10791 1426 802 802
q4 4687 479 350 350
q5 7654 2264 2109 2109
q6 243 180 139 139
q7 912 771 631 631
q8 9347 1732 1645 1645
q9 6857 5024 4998 4998
q10 6506 2288 1913 1913
q11 454 279 249 249
q12 699 439 302 302
q13 18206 3349 2799 2799
q14 272 275 239 239
q15 q16 820 776 717 717
q17 992 997 905 905
q18 6885 5895 5552 5552
q19 1205 1395 1137 1137
q20 570 420 275 275
q21 6204 2838 2572 2572
q22 466 384 314 314
Total cold run time: 101462 ms
Total hot run time: 31612 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4991 4778 5085 4778
q2 q3 4899 5242 4661 4661
q4 2186 2303 1428 1428
q5 5035 4839 4767 4767
q6 240 186 140 140
q7 1968 1782 1569 1569
q8 2360 2080 1975 1975
q9 7475 7530 7516 7516
q10 4777 4722 4280 4280
q11 551 392 380 380
q12 751 759 550 550
q13 3102 3422 2832 2832
q14 285 280 256 256
q15 q16 690 710 624 624
q17 1315 1300 1303 1300
q18 7407 6938 7021 6938
q19 1151 1106 1131 1106
q20 2247 2249 1974 1974
q21 5490 4741 4618 4618
q22 514 461 415 415
Total cold run time: 57434 ms
Total hot run time: 52107 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63638:
URL: https://github.com/apache/doris/pull/63638#issuecomment-4538646992
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #63638:
URL: https://github.com/apache/doris/pull/63638#discussion_r3316704407
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DropRowPolicyCommand.java:
##########
@@ -74,6 +76,11 @@ public void validate(ConnectContext ctx) throws AnalysisException {
if (user != null) {
user.analyze();
}
+ if (!ifExists && !StringUtils.isEmpty(roleName)) {
+ if (!Env.getCurrentEnv().getAuth().doesRoleExist(roleName)) {
Review Comment:
If Doris allows the deletion of a role with a row policy, then it would be impossible to check whether the role exists here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63638:
URL: https://github.com/apache/doris/pull/63638#issuecomment-4596783758
# FE Regression Coverage Report
Increment line coverage ` 83.33% (5/6)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63638_b542dae2a9c889b292d112eede87f44cf11b9377_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63638_b542dae2a9c889b292d112eede87f44cf11b9377_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63638:
URL: https://github.com/apache/doris/pull/63638#issuecomment-4595530933
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on code in PR #63638:
URL: https://github.com/apache/doris/pull/63638#discussion_r3336438358
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DropRowPolicyCommand.java:
##########
@@ -74,6 +76,11 @@ public void validate(ConnectContext ctx) throws AnalysisException {
if (user != null) {
user.analyze();
}
+ if (!ifExists && !StringUtils.isEmpty(roleName)) {
+ if (!Env.getCurrentEnv().getAuth().doesRoleExist(roleName)) {
Review Comment:
Doris allows the deletion of roles with row policies, but it does not simultaneously clean up the row policies under the roles, which is a flaw in itself. I fixed this issue in another PR [63313](https://github.com/apache/doris/pull/63313)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63638:
URL: https://github.com/apache/doris/pull/63638#issuecomment-4535595443
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63638:
URL: https://github.com/apache/doris/pull/63638#issuecomment-4538923171
<details>
<summary>TPC-DS: <b>Total hot run time: 171799 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 17819b27aabf9dd03a94c0df62b32482fb4be027, data reload: false
query5 4337 656 518 518
query6 331 217 207 207
query7 4231 575 316 316
query8 329 248 222 222
query9 8850 4221 4135 4135
query10 456 337 302 302
query11 5809 2476 2283 2283
query12 176 131 130 130
query13 1339 606 458 458
query14 6169 5547 5252 5252
query14_1 4547 4570 4489 4489
query15 214 205 191 191
query16 1006 458 443 443
query17 1167 757 625 625
query18 2659 497 383 383
query19 222 211 167 167
query20 142 140 133 133
query21 219 140 121 121
query22 13711 13630 13469 13469
query23 17300 16602 16271 16271
query23_1 16439 16443 16423 16423
query24 7686 1789 1333 1333
query24_1 1386 1305 1334 1305
query25 540 462 411 411
query26 1309 310 169 169
query27 2719 602 346 346
query28 4437 2023 2008 2008
query29 979 603 497 497
query30 311 236 203 203
query31 1132 1085 956 956
query32 90 76 74 74
query33 580 339 288 288
query34 1179 1120 643 643
query35 786 783 692 692
query36 1403 1386 1229 1229
query37 156 104 91 91
query38 3230 3194 3105 3105
query39 935 921 895 895
query39_1 870 905 869 869
query40 236 141 121 121
query41 63 62 63 62
query42 110 108 110 108
query43 335 334 292 292
query44
query45 209 202 198 198
query46 1080 1281 735 735
query47 2413 2429 2282 2282
query48 404 401 305 305
query49 631 495 391 391
query50 1036 343 255 255
query51 4384 4362 4302 4302
query52 105 105 92 92
query53 262 285 211 211
query54 308 279 246 246
query55 91 89 87 87
query56 305 295 293 293
query57 1438 1427 1322 1322
query58 310 272 272 272
query59 1611 1686 1525 1525
query60 327 326 316 316
query61 159 156 154 154
query62 695 654 587 587
query63 248 206 208 206
query64 2391 824 641 641
query65
query66 1743 475 349 349
query67 29770 29770 29590 29590
query68
query69 476 348 308 308
query70 1034 1025 953 953
query71 309 270 262 262
query72 3032 2695 2409 2409
query73 870 776 408 408
query74 5114 4942 4822 4822
query75 2686 2610 2265 2265
query76 2295 1158 801 801
query77 398 411 340 340
query78 12386 12208 11860 11860
query79 1411 1023 749 749
query80 629 519 447 447
query81 455 277 242 242
query82 1330 160 127 127
query83 359 281 246 246
query84 269 140 111 111
query85 878 547 475 475
query86 403 332 332 332
query87 3406 3422 3279 3279
query88 3708 2797 2755 2755
query89 441 388 344 344
query90 1903 187 174 174
query91 177 165 137 137
query92 79 78 71 71
query93 1461 1533 832 832
query94 540 343 317 317
query95 678 471 349 349
query96 1025 798 338 338
query97 2754 2721 2662 2662
query98 255 233 249 233
query99 1166 1161 1023 1023
Total cold run time: 255305 ms
Total hot run time: 171799 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63638:
URL: https://github.com/apache/doris/pull/63638#discussion_r3317303053
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DropRowPolicyCommand.java:
##########
@@ -74,6 +76,11 @@ public void validate(ConnectContext ctx) throws AnalysisException {
if (user != null) {
user.analyze();
}
+ if (!ifExists && !StringUtils.isEmpty(roleName)) {
Review Comment:
This role existence check now runs before the GRANT privilege check below. That means a user without GRANT can issue `DROP ROW POLICY ... FOR ROLE some_role` and distinguish `role not exist` from `ERR_SPECIFIC_ACCESS_DENIED_ERROR`, whereas the pre-existing flow always reached the privilege check before any catalog existence lookup for the role. `CreatePolicyCommand.validate()` also checks `PrivPredicate.GRANT` before validating the target user/role, so DROP should keep the same privilege-first ordering and only look up the role after authorization succeeds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63638:
URL: https://github.com/apache/doris/pull/63638#issuecomment-4595750724
<details>
<summary>TPC-H: <b>Total hot run time: 29451 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b542dae2a9c889b292d112eede87f44cf11b9377, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17586 4072 4070 4070
q2 q3 10759 1397 814 814
q4 4682 479 344 344
q5 7578 1088 588 588
q6 190 176 142 142
q7 762 898 640 640
q8 9361 1740 1657 1657
q9 5777 4549 4540 4540
q10 6760 1825 1535 1535
q11 430 274 255 255
q12 629 425 291 291
q13 18134 3309 2770 2770
q14 266 264 245 245
q15 q16 818 774 711 711
q17 969 967 974 967
q18 6833 5822 5579 5579
q19 1335 1214 1094 1094
q20 518 394 267 267
q21 6146 2821 2609 2609
q22 463 380 333 333
Total cold run time: 99996 ms
Total hot run time: 29451 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 5281 4774 4935 4774
q2 q3 4872 5342 4649 4649
q4 2097 2163 1385 1385
q5 4805 4903 4681 4681
q6 230 181 132 132
q7 1863 1715 1642 1642
q8 2468 2108 2071 2071
q9 7976 7961 7338 7338
q10 4766 4641 4184 4184
q11 520 385 351 351
q12 728 725 518 518
q13 3007 3317 2780 2780
q14 276 278 248 248
q15 q16 670 691 615 615
q17 1279 1250 1239 1239
q18 7084 6615 6926 6615
q19 1102 1113 1115 1113
q20 2197 2217 1940 1940
q21 5273 4518 4378 4378
q22 510 439 395 395
Total cold run time: 57004 ms
Total hot run time: 51048 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63638:
URL: https://github.com/apache/doris/pull/63638#issuecomment-4595826795
<details>
<summary>TPC-DS: <b>Total hot run time: 170353 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b542dae2a9c889b292d112eede87f44cf11b9377, data reload: false
query5 4323 655 521 521
query6 344 213 202 202
query7 4242 590 313 313
query8 334 257 229 229
query9 8767 4000 3977 3977
query10 487 346 298 298
query11 5815 2351 2158 2158
query12 188 133 125 125
query13 1308 611 425 425
query14 6097 5466 5127 5127
query14_1 4456 4463 4453 4453
query15 213 211 188 188
query16 989 487 449 449
query17 1164 755 605 605
query18 2481 504 367 367
query19 224 213 180 180
query20 160 142 134 134
query21 219 141 127 127
query22 13657 13535 13474 13474
query23 17389 16496 16211 16211
query23_1 16313 16377 16313 16313
query24 7439 1750 1312 1312
query24_1 1302 1316 1313 1313
query25 575 492 417 417
query26 1309 324 169 169
query27 2720 557 342 342
query28 4438 1989 2069 1989
query29 979 629 500 500
query30 316 233 196 196
query31 1129 1073 952 952
query32 100 75 75 75
query33 543 353 295 295
query34 1184 1104 656 656
query35 771 788 696 696
query36 1389 1388 1265 1265
query37 157 108 88 88
query38 3211 3151 3050 3050
query39 940 920 898 898
query39_1 882 874 874 874
query40 247 148 127 127
query41 64 62 62 62
query42 114 111 116 111
query43 326 330 288 288
query44
query45 222 212 201 201
query46 1093 1180 752 752
query47 2380 2383 2279 2279
query48 381 421 310 310
query49 641 493 411 411
query50 996 341 258 258
query51 4332 4300 4307 4300
query52 111 113 98 98
query53 258 277 209 209
query54 317 285 254 254
query55 93 91 86 86
query56 306 314 294 294
query57 1441 1414 1317 1317
query58 315 273 273 273
query59 1578 1687 1408 1408
query60 330 315 314 314
query61 157 159 148 148
query62 702 673 581 581
query63 244 204 208 204
query64 2395 808 626 626
query65
query66 1702 475 349 349
query67 29718 29612 29540 29540
query68
query69 466 362 290 290
query70 1063 994 1020 994
query71 310 285 283 283
query72 2970 2901 2377 2377
query73 860 765 440 440
query74 5145 4929 4773 4773
query75 2704 2631 2292 2292
query76 2288 1141 759 759
query77 402 413 335 335
query78 12348 12404 11813 11813
query79 1273 998 762 762
query80 590 541 463 463
query81 447 279 245 245
query82 238 166 127 127
query83 273 275 250 250
query84 259 135 110 110
query85 848 537 441 441
query86 355 351 314 314
query87 3461 3388 3233 3233
query88 3612 2770 2699 2699
query89 428 399 344 344
query90 2193 181 185 181
query91 179 169 142 142
query92 84 81 76 76
query93 1443 1372 890 890
query94 531 361 330 330
query95 666 372 348 348
query96 997 842 358 358
query97 2723 2734 2623 2623
query98 231 227 226 226
query99 1167 1171 1049 1049
Total cold run time: 252681 ms
Total hot run time: 170353 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63638:
URL: https://github.com/apache/doris/pull/63638#issuecomment-4539807462
# FE Regression Coverage Report
Increment line coverage ` 33.33% (2/6)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63638_17819b27aabf9dd03a94c0df62b32482fb4be027_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63638_17819b27aabf9dd03a94c0df62b32482fb4be027_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #63638:
URL: https://github.com/apache/doris/pull/63638#issuecomment-4562498461
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63638:
URL: https://github.com/apache/doris/pull/63638#issuecomment-4562876025
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Add role existence validation in DropRowPolicyCommand [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63638:
URL: https://github.com/apache/doris/pull/63638#issuecomment-4601959288
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org