You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/08/18 04:05:51 UTC
[GitHub] [incubator-iotdb] wyh-ztf opened a new pull request #1633: Enable to stop iotdb server by iotdb.IoTDB
wyh-ztf opened a new pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-684543250
Hi, I start two IoTDB in my mac, the port is 6667 and 6668. When I try to use ./sbin/stop-server.sh under one IoTDB. it prints the following and does not take effect. Please have a check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] wyh-ztf commented on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
wyh-ztf commented on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-684779087
> Hi, I start two IoTDB in my mac, the port is 6667 and 6668. When I try to use ./sbin/stop-server.sh under one IoTDB. it prints the following and does not take effect. Please have a check.
>
> 
Thanks for your advice. I'll check it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-697138525
Hi， please recover the set memory in iotdb-env.bat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-697334567
Hi, I like the changes in `iotdb-env.bat`, good job!
But let's consider the stop script...
Suppose your IoTDB start-server script is at `~/Download/apache/sbin/`,
and your current `pwd` is `~`, then you can start the IoTDB by `~/Download/iotdb/sbin/start-server.sh`.
Then if you want to stop IoTDB using your script, you must make sure you are in `~`.
Suppose you are now in `~/Download`, and if you call `iotdb/sbin/stop-server.sh`, you will get `No IoTDB server to stop`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] wyh-ztf commented on pull request #1633: Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
wyh-ztf commented on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-677987191
> And this issue reminds me another issue: on WinOS, our start-server.bat shell only requires 2GB memory from the OS, while the start-server.sh will use 1/4 memory. I think it also needs to be fixed.
OK, I'll change it. Thank you for your advice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1633: Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-676984457
And this issue reminds me another issue: on WinOS, our start-server.bat shell only requires 2GB memory from the OS, while the start-server.sh will use 1/4 memory. I think it also needs to be fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] wyh-ztf commented on pull request #1633: Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
wyh-ztf commented on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-677992568
> > > plase make sure only the IoTDB instance under the dir can be stopped.
> >
> >
> > big +1
> > By the way, @wyh-ztf can you create a jira issue to describe current behavior and the new behavior after fixing it?
>
> OK, I've created it
https://issues.apache.org/jira/browse/IOTDB-845?jql=issuetype%20%3D%20Improvement%20AND%20assignee%20in%20(EMPTY)%20order%20by%20lastViewed%20DESC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] wyh-ztf edited a comment on pull request #1633: Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
wyh-ztf edited a comment on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-677986861
> > plase make sure only the IoTDB instance under the dir can be stopped.
>
> big +1
>
> By the way, @wyh-ztf can you create a jira issue to describe current behavior and the new behavior after fixing it?
OK, I've created it
jira: https://issues.apache.org/jira/browse/IOTDB-845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1633: Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-676973359
> plase make sure only the IoTDB instance under the dir can be stopped.
big +1
By the way, @wyh-ztf can you create a jira issue to describe current behavior and the new behavior after fixing it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] yhwangBonc commented on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
yhwangBonc commented on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-697349541
> Hi, I like the changes in `iotdb-env.bat`, good job!
>
> But let's consider the stop script...
>
> Suppose your IoTDB start-server script is at `~/Download/apache/sbin/`,
>
> and your current `pwd` is `~`, then you can start the IoTDB by `~/Download/iotdb/sbin/start-server.sh`.
>
> Then if you want to stop IoTDB using your script, you must make sure you are in `~`.
> Suppose you are now in `~/Download`, and if you call `iotdb/sbin/stop-server.sh`, you will get `No IoTDB server to stop`.
You're right. I'll try to stop the service by getting the process number through the port number
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] yhwangBonc edited a comment on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
yhwangBonc edited a comment on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-697349541
> Hi, I like the changes in `iotdb-env.bat`, good job!
>
> But let's consider the stop script...
>
> Suppose your IoTDB start-server script is at `~/Download/apache/sbin/`,
>
> and your current `pwd` is `~`, then you can start the IoTDB by `~/Download/iotdb/sbin/start-server.sh`.
>
> Then if you want to stop IoTDB using your script, you must make sure you are in `~`.
> Suppose you are now in `~/Download`, and if you call `iotdb/sbin/stop-server.sh`, you will get `No IoTDB server to stop`.
You're right. I'll try to get absolute path instead of relative path
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] wyh-ztf commented on pull request #1633: Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
wyh-ztf commented on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-677986861
> > plase make sure only the IoTDB instance under the dir can be stopped.
>
> big +1
>
> By the way, @wyh-ztf can you create a jira issue to describe current behavior and the new behavior after fixing it?
OK, I've created it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] yhwangBonc commented on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
yhwangBonc commented on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-697182130
> Hi， please recover the set memory in iotdb-env.bat
Ok,I annotated one and put it at the end
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] wyh-ztf removed a comment on pull request #1633: Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
wyh-ztf removed a comment on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-677992568
> > > plase make sure only the IoTDB instance under the dir can be stopped.
> >
> >
> > big +1
> > By the way, @wyh-ztf can you create a jira issue to describe current behavior and the new behavior after fixing it?
>
> OK, I've created it
https://issues.apache.org/jira/browse/IOTDB-845?jql=issuetype%20%3D%20Improvement%20AND%20assignee%20in%20(EMPTY)%20order%20by%20lastViewed%20DESC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] yhwangBonc edited a comment on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
yhwangBonc edited a comment on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-697349541
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] yhwangBonc edited a comment on pull request #1633: [IOTDB-845]Enable to stop iotdb server by iotdb.IoTDB
Posted by GitBox <gi...@apache.org>.
yhwangBonc edited a comment on pull request #1633:
URL: https://github.com/apache/incubator-iotdb/pull/1633#issuecomment-697349541
> Hi, I like the changes in `iotdb-env.bat`, good job!
>
> But let's consider the stop script...
>
> Suppose your IoTDB start-server script is at `~/Download/apache/sbin/`,
>
> and your current `pwd` is `~`, then you can start the IoTDB by `~/Download/iotdb/sbin/start-server.sh`.
>
> Then if you want to stop IoTDB using your script, you must make sure you are in `~`.
> Suppose you are now in `~/Download`, and if you call `iotdb/sbin/stop-server.sh`, you will get `No IoTDB server to stop`.
You're right. I'll try to get process number by port number
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org