You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "justinmclean (via GitHub)" <gi...@apache.org> on 2026/07/27 05:21:05 UTC
[I] Update organization-adapters.md: the organizations/ structural check has shipped [magpie]
justinmclean opened a new issue, #935:
URL: https://github.com/apache/magpie/issues/935
## Summary
Rewrite the `Known gaps` bullet in
`tools/spec-loop/specs/organization-adapters.md` that says no validator check
enforces required files under `organizations/<org>/`. The check exists.
## Background
The bullet reads "No structural validator check yet enforces required files in
`organizations/<org>/` (currently README + organization.md by convention)." That
check shipped in #721 as `validate_organization_structure`, and it is a HARD
check, so the requirement is no longer convention-only.
Spec `Known gaps` sections are not just documentation: the spec-loop plan beat
reads them to choose the next work item, so a gap that describes already-shipped
code sends the loop at finished work.
## Where to look
- `tools/spec-loop/specs/organization-adapters.md` line 125 - the bullet to
rewrite.
- `tools/skill-and-tool-validator/src/skill_and_tool_validator/__init__.py` -
`validate_organization_structure` is called at line 3706.
- `organizations/` - the live tree the check runs against. Note that
`_template` is deliberately excluded.
**Verify by finding the call site, not the definition.**
## Acceptance criteria
- [ ] The bullet describes the shipped check instead of claiming it is missing.
- [ ] The description states which files are required, that the check is HARD,
and that `_template` is excluded.
- [ ] `uv run --project tools/spec-validator spec-validate tools/spec-loop/specs/`
passes.
## Estimated effort
~30 minutes for someone new to the codebase.
## Getting started
New to Magpie? Start with
[Your first contribution](https://github.com/apache/magpie/blob/main/CONTRIBUTING.md#your-first-contribution).
Note: this issue was drafted by an AI-assisted mentoring tool and may contain
mistakes. A Magpie maintainer, a real person, will be the next to engage on it.
If something here looks wrong or unclear, please say so on the issue and a
maintainer will follow up. See
[CONTRIBUTING.md](https://github.com/apache/magpie/blob/main/CONTRIBUTING.md)
for how Magpie handles contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update organization-adapters.md: the organizations/ structural check has shipped [magpie]
Posted by "Hashim1999164 (via GitHub)" <gi...@apache.org>.
Hashim1999164 commented on issue #935:
URL: https://github.com/apache/magpie/issues/935#issuecomment-5118757991
I checked the current default branch before editing. `organization-adapters.md` already documents the shipped call site at lines 119–123, including `README.md`, `organization.md`, HARD severity, and the `_template` exclusion, and the stale Known gaps bullet is no longer present. No additional PR appears necessary, so I’m stepping back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update organization-adapters.md: the organizations/ structural check has shipped [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #935: Update organization-adapters.md: the organizations/ structural check has shipped
URL: https://github.com/apache/magpie/issues/935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update organization-adapters.md: the organizations/ structural check has shipped [magpie]
Posted by "Hashim1999164 (via GitHub)" <gi...@apache.org>.
Hashim1999164 commented on issue #935:
URL: https://github.com/apache/magpie/issues/935#issuecomment-5118751968
I’d like to work on this documentation update. I’ll verify the live validator call site and update the Known gaps bullet to reflect the required files, HARD severity, and `_template` exclusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update organization-adapters.md: the organizations/ structural check has shipped [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #935:
URL: https://github.com/apache/magpie/issues/935#issuecomment-5577667987
Fixed in #1159 (3d9b2c98) — though the specific bullet this issue names was
already removed in #994 (481a9b5d), as @Hashim1999164 correctly worked out on
this thread.
Rather than close as stale: the rest of the Known-gaps section turned out to be
stale in the same way, and all three remaining bullets have been replaced. The
template reflow shipped, family-level `organization:` scope and the adapter
discovery index shipped, and the non-ASF smoke suite has grown from one skill
to five. The Validation section now also records the referential checks against
`known_organizations()`.
New gaps recorded in their place: nothing schema-checks `organization.md`
contents, `skill-sources.md` is absent from `_ORG_REQUIRED_FILES`, and no eval
exercises authoring a fresh org from `organizations/_template/`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org