You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@syncope.apache.org by il...@apache.org on 2025/05/14 10:52:33 UTC

(syncope) branch 3_0_X updated: Revert "[SYNCOPE-1882] Not adding placeholder value for multivalue dropdown attributes"

This is an automated email from the ASF dual-hosted git repository.

ilgrosso pushed a commit to branch 3_0_X
in repository https://gitbox.apache.org/repos/asf/syncope.git


The following commit(s) were added to refs/heads/3_0_X by this push:
     new 387a91e6d8 Revert "[SYNCOPE-1882] Not adding placeholder value for multivalue dropdown attributes"
387a91e6d8 is described below

commit 387a91e6d8207a514b76efbc73c631ba5db39366
Author: Francesco Chicchiriccò <il...@apache.org>
AuthorDate: Wed May 14 12:52:21 2025 +0200

    Revert "[SYNCOPE-1882] Not adding placeholder value for multivalue dropdown attributes"
    
    This reverts commit 427d8fad45f6424aaad4d599eac7b459771e1fe5.
---
 .../apache/syncope/client/console/wizards/any/PlainAttrs.java    | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/any/PlainAttrs.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/any/PlainAttrs.java
index e48f8f48d4..aa536bb9c3 100644
--- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/any/PlainAttrs.java
+++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/any/PlainAttrs.java
@@ -37,7 +37,6 @@ import org.apache.syncope.common.lib.to.GroupableRelatableTO;
 import org.apache.syncope.common.lib.to.MembershipTO;
 import org.apache.syncope.common.lib.to.PlainSchemaTO;
 import org.apache.syncope.common.lib.to.UserTO;
-import org.apache.syncope.common.lib.types.AttrSchemaType;
 import org.apache.syncope.common.lib.types.SchemaType;
 import org.apache.wicket.extensions.markup.html.tabs.AbstractTab;
 import org.apache.wicket.markup.html.WebMarkupContainer;
@@ -152,9 +151,7 @@ public class PlainAttrs extends AbstractAttrs<PlainSchemaTO> {
             Attr attr = new Attr();
             attr.setSchema(schema.getKey());
             if (attrMap.get(schema.getKey()) == null || attrMap.get(schema.getKey()).getValues().isEmpty()) {
-                if (schema.getType() != AttrSchemaType.Dropdown && !schema.isMultivalue()) {
-                    attr.getValues().add(StringUtils.EMPTY);
-                }
+                attr.getValues().add("");
             } else {
                 attr = attrMap.get(schema.getKey());
             }
@@ -175,9 +172,7 @@ public class PlainAttrs extends AbstractAttrs<PlainSchemaTO> {
             Attr attr = new Attr();
             attr.setSchema(schema.getKey());
             if (attrMap.get(schema.getKey()) == null || attrMap.get(schema.getKey()).getValues().isEmpty()) {
-                if (schema.getType() != AttrSchemaType.Dropdown && !schema.isMultivalue()) {
-                    attr.getValues().add(StringUtils.EMPTY);
-                }
+                attr.getValues().add(StringUtils.EMPTY);
             } else {
                 attr.getValues().addAll(attrMap.get(schema.getKey()).getValues());
             }