[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #18377: [refactor](planner) In the runtime filter, use crc_hash replace original murmur_hash

["BiteTheDDDDt (via GitHub)" <gi...@apache.org>]

BiteTheDDDDt commented on code in PR #18377:
URL: https://github.com/apache/doris/pull/18377#discussion_r1156938823


##########
be/src/vec/exprs/vbloom_predicate.cpp:
##########
@@ -67,10 +67,20 @@ Status VBloomPredicate::execute(VExprContext* context, Block* block, int* result
     auto ptr = ((ColumnVector<UInt8>*)res_data_column.get())->get_data().data();
     auto type = WhichDataType(remove_nullable(block->get_by_position(arguments[0]).type));
     if (type.is_string_or_fixed_string()) {

Review Comment:
   Why the new hash only used at string type?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org