[GitHub] [incubator-dolphinscheduler] clay4444 commented on issue #1477: [BUG] some tasks would be running all the time when db delayed.

[GitBox <gi...@apache.org>]

clay4444 commented on issue #1477: [BUG] some tasks would be running all the time when db delayed.
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1477#issuecomment-565500081
 
 
   hi, @lenboo 
   
         In reading the source code, I happened to see here and also saw the mailing list. I found that the main problems appeared in the following three places:
   
         1. ProcessDao # submitTaskInstanceToMysql,  saveTaskInstance The method returned true or false to indicate whether the insert was successful, but it is directly ignored here, this may lead to inserting a task to zk that does not exist in db,
        `public TaskInstance submitTaskInstanceToMysql(TaskInstance taskInstance, ProcessInstance processInstance){
           ....
           saveTaskInstance(taskInstance);
           return taskInstance;
       }`
   
         2. ProcessDao # submitTask, submitTaskToQueue also returned true or false to indicate whether the insert was successful, also be ignored here, it's the same question,
        `public TaskInstance submitTask(TaskInstance taskInstance, ProcessInstance processInstance){
             ....... 
              submitTaskToQueue(task); // >>>> 提交到zk队列
           return task; 
       }`
   
       3. and, in the taskQueue.add() method,  the exception was discarded directly, just printed an error log,  but submitTaskToQueue() is to determine whether the addition is successful by catching the exception,  This will cause the method to always return to add successfully even if the task fails to add, 
       
      This is all the problems I found, maybe you can check again if there are other problems, if not, can you allow me to fix thees bug?  I am very willing to do this job, and maybe you can review it after I finish,  I just need a little time to fix it,  thanks, 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services