You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "cheese (via GitHub)" <gi...@apache.org> on 2023/09/05 01:48:12 UTC
[GitHub] [buildstream] cheese opened a new pull request, #1868: Fixes Python 3.12 build for bst-1: Updating versioneer again, properly.
cheese opened a new pull request, #1868:
URL: https://github.com/apache/buildstream/pull/1868
commit cf7ff12fe0c98bd0e3b86a00c9443004a56600fc in master branch
First time around we were using `versioneer install --no-vendor`, and neglecting to remove the `versioneer.py` file from the toplevel, which is still required by BuildStream's setup.py for a few reasons.
Instead, go back to `versioneer install --vendor` and update versioneer files correctly.
Fixes #1855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1868: Fixes Python 3.12 build for bst-1: Updating versioneer again, properly.
Posted by "nanonyme (via GitHub)" <gi...@apache.org>.
nanonyme commented on PR #1868:
URL: https://github.com/apache/buildstream/pull/1868#issuecomment-1708918789
I'm not convinced this will be the last problem. BuildStream 1 has historically completely broken with every Python update due to its mixing of asyncio and multiprocessing in not really supported ways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1868: Fixes Python 3.12 build for bst-1: Updating versioneer again, properly.
Posted by "nanonyme (via GitHub)" <gi...@apache.org>.
nanonyme commented on PR #1868:
URL: https://github.com/apache/buildstream/pull/1868#issuecomment-1707136679
Is there actually demand for this still? BuildStream 1 is now a legacy tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1868: Fixes Python 3.12 build for bst-1: Updating versioneer again, properly.
Posted by "gtristan (via GitHub)" <gi...@apache.org>.
gtristan merged PR #1868:
URL: https://github.com/apache/buildstream/pull/1868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1868: Fixes Python 3.12 build for bst-1: Updating versioneer again, properly.
Posted by "gtristan (via GitHub)" <gi...@apache.org>.
gtristan commented on PR #1868:
URL: https://github.com/apache/buildstream/pull/1868#issuecomment-1709472777
> Is there actually demand for this still? BuildStream 1 is now a legacy tool.
I have client organizations still using bst1, although likely to migrate to bst2.
In any case this is not a concern, our policy since releasing bst2 has been that we are happy to accept bugfix contributions and push out snapshot releases, upstream is not actively maintaining bst1.
> I'm not convinced this will be the last problem. BuildStream 1 has historically completely broken with every Python update due to its mixing of asyncio and multiprocessing in not really supported ways.
Indeed we should at least add Python 3.12 to the tests before making any claims.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org